build: Treat -Wswitch as error when –enable-werror #16424

1. 
   MarcoFalke commented at 7:43 pm on July 19, 2019: member

   By default we set -Wall, which enabled -Wswitch, so this already prints warnings. However, it can be additionally be turned into an error when --enable-werror to be extra safe.
2. build: Treat -Wswitch as error when --enable-werror fabfcb5d8e
3. 
   MarcoFalke commented at 7:44 pm on July 19, 2019: member

   Can be tested by adding a new type to one of our enum classes or removing one from our switches.
4. 
   promag commented at 7:45 pm on July 19, 2019: member

   Concept :clap:
5. DrahtBot added the label Build system on Jul 19, 2019
6. MarcoFalke added the label Needs gitian build on Jul 19, 2019
7. 
   practicalswift commented at 11:38 am on July 20, 2019: contributor

   utACK fabfcb5d8ec35442f81c6e6fd33abff52bbe0fde

   Very nice!

8. 
   Empact commented at 11:19 am on July 21, 2019: member

   ACK https://github.com/bitcoin/bitcoin/pull/16424/commits/fabfcb5d8ec35442f81c6e6fd33abff52bbe0fde
9. 
   fanquake commented at 6:12 am on July 23, 2019: member

   Concept ACK
10. 
    DrahtBot commented at 3:24 am on July 29, 2019: member

    Gitian builds for commit febf3a856bcfb8fef2cb4ddcb8d1e0cab8a22580 (master):

    • 98a2d3c48986f67d7799e77ead66d14c... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
    • d9a1de9f0fc90257bfe9b37106831ec3... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
    • c33790f6dda1d8ff300055c56a9c56ba... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
    • 06f4e79b53d021c532f06c76ebedf404... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
    • 43176e76c6edb3be25ced083cf4fa88b... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
    • ebf3cdebd70b6a768c0aa47cd7251cb3... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
    • 7a16d5d7869f3da3d4887061736b009c... bitcoin-0.18.99-osx-unsigned.dmg
    • b517eb74b51151aebdcb7ccbff3ce038... bitcoin-0.18.99-osx64.tar.gz
    • c1a62933e0f7a2355c1cc1ee96b0129f... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
    • b92fe7f80c35de5b5a14ef133f06bec3... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
    • 01b3f9c3faaae4bc8c473de09c2d7349... bitcoin-0.18.99-win64-debug.zip
    • bcb6478790529b0d4dd8c864e1029719... bitcoin-0.18.99-win64-setup-unsigned.exe
    • d42e58120549a6f0e48cc1e0a3f3545c... bitcoin-0.18.99-win64.zip
    • 38b318c177a1129b91339bc5da4d93bc... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
    • 140dd5d8649113568474a0289ce44352... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
    • cfe81e7048c02a4a7551597d3cfbf221... bitcoin-0.18.99.tar.gz
    • 153757a706b1bb521b269a3dbf5f22ad... bitcoin-core-linux-0.19-res.yml
    • a84f0c977d4ead6ab7d38175ccc4c083... bitcoin-core-osx-0.19-res.yml
    • c00a83e5f27f39ed4ba95b8d2706d8f4... bitcoin-core-win-0.19-res.yml
    • 7746a192678c0afcbd8fb6b0e4c63eb5... linux-build.log
    • 3f756ea0d15eeba80e1fcf5b5486acba... osx-build.log
    • a76eb3c43708df1e47c41014a452366e... win-build.log

    Gitian builds for commit 58f130fd8bb6fff3f5aef79d604fba58411b891c (master and this pull):

    • 6020c834eec2bfe286b8870adf83f0f1... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
    • 3393ff35bff231d2809fd66cd9ca6bb8... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
    • 30f4b4e9481370974d6b12cab7b3b468... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
    • 9a70751ba77abaaa14523ec013f5deec... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
    • c1917420c590c7c372394e7d0e554602... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
    • 7650c549bc862ed243a00679b3db3771... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
    • 610c5898dc2bdcfed8565d04c1c2322f... bitcoin-0.18.99-osx-unsigned.dmg
    • 22b5b24fd44df43636e378c6aeb96da2... bitcoin-0.18.99-osx64.tar.gz
    • 62152ea689f03362d360d2dc65e08745... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
    • fc933bf05ae67674fd213f3b7fa7d92a... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
    • b0a0854cd6d3eb77a94aa8bfec5fe1dd... bitcoin-0.18.99-win64-debug.zip
    • 408a4587b21c723e9b6c8cc0d75c91fd... bitcoin-0.18.99-win64-setup-unsigned.exe
    • 1ac2f19168ac74748f153232869f91f1... bitcoin-0.18.99-win64.zip
    • a20f8f0fc9978294fe22609061727530... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
    • e33c7bf2e21d16645db8b832f8765d11... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
    • 96cc48e6b708f2d9e6f48deaa9465290... bitcoin-0.18.99.tar.gz
    • 4d576531d5f9173b2a639c5446fb0ef1... bitcoin-core-linux-0.19-res.yml
    • 6ef05941defc50e22b1524711a4e93f9... bitcoin-core-linux-0.19-res.yml.diff
    • 5bb9c6b06239bb4048ce326955cd5661... bitcoin-core-osx-0.19-res.yml
    • aed838ff0353a5c00dd0f0ac2f648baf... bitcoin-core-osx-0.19-res.yml.diff
    • c861bb827af1ecc651e2a9371be607ea... bitcoin-core-win-0.19-res.yml
    • 394ad8284783cb919c855242f583a567... bitcoin-core-win-0.19-res.yml.diff
    • 44fe84e06584cd880427088a9e96fc63... linux-build.log
    • a7436ab0370928971c0255f86597b6f7... linux-build.log.diff
    • b02633fdeac2a17904cacda2f30704fc... osx-build.log
    • c02e2140ada6a55924fd6fe427067763... osx-build.log.diff
    • 45ef906654615e0fc1d9f7b8d5aebcb3... win-build.log
    • a1e99f048add23acec35c67767c0865d... win-build.log.diff
11. DrahtBot removed the label Needs gitian build on Jul 29, 2019
12. MarcoFalke referenced this in commit 502ec02272 on Jul 29, 2019
13. MarcoFalke merged this on Jul 29, 2019
14. MarcoFalke closed this on Jul 29, 2019

    ---

15. MarcoFalke deleted the branch on Jul 29, 2019
16. sidhujag referenced this in commit 9f75d3f816 on Jul 30, 2019
17. kittywhiskers referenced this in commit 8243523c21 on Jun 17, 2021
18. kittywhiskers referenced this in commit 4a37d0947b on Jun 17, 2021
19. kittywhiskers referenced this in commit 82c9431f20 on Jun 17, 2021
20. UdjinM6 referenced this in commit 988fa6a235 on Jun 23, 2021
21. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke promag practicalswift Empact fanquake DrahtBot

Labels
Build system