build: Treat -Wswitch as error when --enable-werror #16424

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1907-buildSwitchError changing 1 files +2 −0
  1. MarcoFalke commented at 7:43 PM on July 19, 2019: member

    By default we set -Wall, which enabled -Wswitch, so this already prints warnings. However, it can be additionally be turned into an error when --enable-werror to be extra safe.

  2. build: Treat -Wswitch as error when --enable-werror fabfcb5d8e
  3. MarcoFalke commented at 7:44 PM on July 19, 2019: member

    Can be tested by adding a new type to one of our enum classes or removing one from our switches.

  4. promag commented at 7:45 PM on July 19, 2019: member

    Concept :clap:

  5. DrahtBot added the label Build system on Jul 19, 2019
  6. MarcoFalke added the label Needs gitian build on Jul 19, 2019
  7. practicalswift commented at 11:38 AM on July 20, 2019: contributor

    utACK fabfcb5d8ec35442f81c6e6fd33abff52bbe0fde

    Very nice!

  9. fanquake commented at 6:12 AM on July 23, 2019: member

    Concept ACK

  10. DrahtBot commented at 3:24 AM on July 29, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit febf3a856bcfb8fef2cb4ddcb8d1e0cab8a22580 (master):

    Gitian builds for commit 58f130fd8bb6fff3f5aef79d604fba58411b891c (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Jul 29, 2019
  12. MarcoFalke referenced this in commit 502ec02272 on Jul 29, 2019
  13. MarcoFalke merged this on Jul 29, 2019
  14. MarcoFalke closed this on Jul 29, 2019
  15. MarcoFalke deleted the branch on Jul 29, 2019
  16. sidhujag referenced this in commit 9f75d3f816 on Jul 30, 2019
  17. kittywhiskers referenced this in commit 8243523c21 on Jun 17, 2021
  18. kittywhiskers referenced this in commit 4a37d0947b on Jun 17, 2021
  19. kittywhiskers referenced this in commit 82c9431f20 on Jun 17, 2021
  20. UdjinM6 referenced this in commit 988fa6a235 on Jun 23, 2021
  21. MarcoFalke locked this on Dec 16, 2021
Contributors
MarcoFalkepromagpracticalswiftEmpactfanquakeDrahtBot
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me