travis: use extended 90 minute timeout when available #16595

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-travisNoTimeout changing 1 files +2 −0

MarcoFalke commented at 2:06 PM on August 13, 2019: member

The default is 50 minutes, see https://docs.travis-ci.com/user/customizing-the-build#build-timeouts

Travis is willing to raise the default for the bitcoin/bitcoin repo slug to 90 minutes, see #16595 (comment)

This allows us to bypass the "exit early to save the depends or compiler cache" for bitcoin/bitcoin, but not for forks of this repo.

Fixes #16148
travis: Bump timeout from 50 minutes to 90 fa1e9c68a7
MarcoFalke added the label Tests on Aug 13, 2019
instagibbs commented at 2:36 PM on August 13, 2019: member

Can this get a bit more explanation? I see no references to 50 or 90 minutes aside from comments :)
in .travis.yml:67 in fa1e9c68a7
```
  63 | @@ -64,8 +64,10 @@ before_script:
  64 |  script:
  65 |    - export CONTINUE=1
  66 |    - if [ $SECONDS -gt 1200 ]; then export CONTINUE=0; fi  # Likely the depends build took very long
  67 | +  - if [ $TRAVIS_REPO_SLUG = "bitcoin/bitcoin" ]; then export CONTINUE=1; fi  # Whitelisted repo (90 minutes build time)
```
Sjors commented at 3:37 PM on August 13, 2019:

The normal job timeout is 50 minutes, and we check if more than 20 minutes (1200 seconds) have passed. So with this extended timeout, should we check $SECONDS -gt 3600? Is there a way to directly check the timeout value, rather than relying on a hard coded repo name?

MarcoFalke commented at 4:58 PM on August 13, 2019:

I couldn't find the timeout in https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
Sjors commented at 3:39 PM on August 13, 2019: member

Suggest renaming to travis: use extended 90 minute timeout when available
DrahtBot commented at 4:44 PM on August 13, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16582 (test: Rework ci (Use travis only as fallback env) by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 4:55 PM on August 13, 2019: member

Reference:

Aug 12, 19:03 EDT Hey Marco, Thanks for reaching out! I've proceeded with increasing the timeout of the bitcoin/bitcoin repository to 90 minutes (just in case). Hope this helps and please let me know if there's anything else we can assist you with. Sincerely, -- Dominic.
MarcoFalke renamed this:
~~travis: Bump timeout from 50 minutes to 90~~
travis: use extended 90 minute timeout when available
on Aug 13, 2019
instagibbs commented at 5:05 PM on August 13, 2019: member

perfect, thanks
practicalswift commented at 7:51 AM on August 14, 2019: contributor

ACK fa1e9c68a72fe8a17b6cb1ce473fd79388b2b61e -- diff looks correct
fanquake approved
fanquake commented at 8:16 AM on August 14, 2019: member

ACK fa1e9c68a72fe8a17b6cb1ce473fd79388b2b61e
laanwj commented at 9:25 AM on August 14, 2019: member

ACK fa1e9c68a72fe8a17b6cb1ce473fd79388b2b61e

Thanks Travis / Dominic!
laanwj merged this on Aug 14, 2019
laanwj closed this on Aug 14, 2019
laanwj referenced this in commit b120645e8c on Aug 14, 2019
MarcoFalke deleted the branch on Aug 14, 2019
Sjors commented at 12:12 PM on August 14, 2019: member

I just had a timeout on a backport... maybe backport this?
MarcoFalke referenced this in commit 80cd3f0ba6 on Aug 14, 2019
HashUnlimited referenced this in commit d119ecf8de on Aug 23, 2019
magic53 referenced this in commit 899ea637a6 on Dec 31, 2019
ShengguangXiao referenced this in commit 6d80a79d98 on Aug 28, 2020
tecnovert referenced this in commit 59814ab032 on Oct 27, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16148 Travis timeouts

travis: use extended 90 minute timeout when available #16595

Conflicts