Adds six missing classes to the msbuild bench_bitcoin project.
msbuild: Add missing classes to the bench_bitcoin project #16747
pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:add_missing_bench changing 3 files +198 −78-
sipsorcery commented at 8:27 PM on August 28, 2019: member
-
MarcoFalke commented at 8:33 PM on August 28, 2019: member
Why can't the wildcard
/*.cppbe used as in other build files? -
sipsorcery commented at 8:58 PM on August 28, 2019: member
Based on a quick inspection it seems like the bench_bitcoin.vcxproj file could be auto generated from the makefile. There may have been a reason why @ken2812221 excluded it when he wrote the original python script. I'll put in on my list to look into.
- fanquake added the label Windows on Aug 28, 2019
-
Added the bench_bitcoin project to the list automatically produced by the msvc-autogen python script. 751aec28e2
-
fanquake commented at 4:10 AM on August 29, 2019: member
@sipsorcery Does that mean you want to close this and follow up once you've had time to look, or is this still worth merging now/as-is?
- sipsorcery force-pushed on Aug 29, 2019
-
sipsorcery commented at 6:58 AM on August 29, 2019: member
Will resubmit the msvc-autogen fix on a different PR.
- sipsorcery closed this on Aug 29, 2019
- fanquake referenced this in commit dcfd85acb4 on Aug 29, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels