msbuild: adds bench_bitcoin to auto generated project files #16750

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:autogen_bench changing 2 files +2 −21

sipsorcery commented at 7:12 AM on August 29, 2019: member

As discussed in #16747.

The msbuild bench_bitcoin project is currently missing a number of classes. Rather than add them manually this PR adds bench_bitcoin to the list of project files that are auto generated from the main make files.
Added the bench_bitcoin project to the list automatically produced by the msvc-autogen python script. d53d591230
fanquake added the label Build system on Aug 29, 2019
fanquake added the label Windows on Aug 29, 2019
in build_msvc/msvc-autogen.py:20 in 427b47edfa outdated
```
  16 | @@ -17,6 +17,7 @@
  17 |      'libbitcoin_wallet_tool',
  18 |      'libbitcoin_wallet',
  19 |      'libbitcoin_zmq',
  20 | +    'bench_bitcoin'
```
practicalswift commented at 9:25 AM on August 29, 2019:

Nit: End with , to avoid touching this line next time a new item is added to the end of the libs list?
practicalswift approved
practicalswift commented at 9:26 AM on August 29, 2019: contributor

ACK 427b47edfad64bc900e3c2ef323cfbc799215fac modulo nit -- diff looks correct
sipsorcery force-pushed on Aug 29, 2019
fanquake approved
fanquake commented at 9:53 AM on August 29, 2019: member

ACK d53d591230406f6618b7f0adba27bbdce72f0d35 - Thanks for following up quickly.
practicalswift commented at 10:15 AM on August 29, 2019: contributor

ACK d53d591230406f6618b7f0adba27bbdce72f0d35
fanquake referenced this in commit dcfd85acb4 on Aug 29, 2019
fanquake merged this on Aug 29, 2019
fanquake closed this on Aug 29, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16747 msbuild: Add missing classes to the bench_bitcoin project