Add libtest_util library to msvc build configuration #17571

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:msvc_libtestutil changing 5 files +36 −1

sipsorcery commented at 12:45 PM on November 23, 2019: member

libtest_util was introduced in #17542. This PR adds the msvc build configuration.
fanquake added the label Tests on Nov 23, 2019
fanquake added the label Windows on Nov 23, 2019
laanwj commented at 2:04 PM on November 23, 2019: member

Thanks! ACK if it passes AppVeyor
sipsorcery force-pushed on Nov 23, 2019

fanquake commented at 3:22 PM on November 23, 2019: member

msbuild /p:TrackFileAccess=false /p:CLToolExe=clcache.exe build_msvc\bitcoin.sln /m /v:q /nologo
bench_bench.obj : error LNK2001: unresolved external symbol "public: __cdecl TestingSetup::~TestingSetup(void)" (??1TestingSetup@@QEAA@XZ) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_bench.obj : error LNK2001: unresolved external symbol "public: __cdecl TestingSetup::TestingSetup(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??0TestingSetup@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildSpendingTransaction(class CScript const &,struct CScriptWitness const &,class CTransaction const &)" (?BuildSpendingTransaction@@YA?AUCMutableTransaction@@AEBVCScript@@AEBUCScriptWitness@@AEBVCTransaction@@@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildCreditingTransaction(class CScript const &,int)" (?BuildCreditingTransaction@@YA?AUCMutableTransaction@@AEBVCScript@@H@Z) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
libbitcoin_server.lib(validation.obj) : error LNK2001: unresolved external symbol "class std::function<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl(char const *)> const G_TRANSLATION_FUN" (?G_TRANSLATION_FUN@@3V?$function@$$A6A?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBD@Z@std@@B) [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]
C:\projects\bitcoin\build_msvc\x64\Release\bench_bitcoin.exe : fatal error LNK1120: 5 unresolved externals [C:\projects\bitcoin\build_msvc\bench_bitcoin\bench_bitcoin.vcxproj]

Added libtest_util library to msvc build configuration. b509554433
sipsorcery force-pushed on Nov 23, 2019
sipsorcery renamed this:
~~WIP: Add libtest_util library to msvc build configuration~~
Add libtest_util library to msvc build configuration
on Nov 23, 2019
sipsorcery commented at 5:03 PM on November 23, 2019: member

Appveyor should now pass. Ready for review.
fanquake approved
fanquake commented at 5:28 PM on November 23, 2019: member

ACK b509554433cb4bd32852239d0dd195ec059657f6 - Appveyor looks good.
fanquake referenced this in commit 2c98e2024d on Nov 23, 2019
fanquake merged this on Nov 23, 2019
fanquake closed this on Nov 23, 2019
MarcoFalke commented at 8:34 PM on November 23, 2019: member

Are the gui unit tests not built on appveyor?
sidhujag referenced this in commit c7cea2356d on Nov 23, 2019
sipsorcery deleted the branch on Nov 24, 2019
sipsorcery commented at 9:34 AM on November 24, 2019: member

@MarcoFalke there's no msbuild project for the Qt tests so they have never been built on appveyor. I don't think there's any reason they can't be built. I'll look into it.
MarcoFalke commented at 4:26 PM on November 24, 2019: member

Interestingly, even though this build succeeded, the build on master did not
sipsorcery commented at 5:07 PM on November 24, 2019: member

Did the appveyor job fail at the test stage? I do get occasional failures on a python test. I haven't tracked down the culprit yet.

All my appveyor builds on master since this PR have worked.
MarcoFalke referenced this in commit 8830cb58ab on Dec 30, 2019
sidhujag referenced this in commit 6c70ef5f7b on Jan 2, 2020
sidhujag referenced this in commit 54bf552cae on Nov 10, 2020
sidhujag referenced this in commit 4872d10936 on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17542 build: Create test utility library from src/test/util/#17741 build: Included test_bitcoin-qt in msvc build