Conditional check against fMaster is now redundant as it is already checked as true. This originally made sense as the outer conditional was:
Removal of fQuit happened in the commit below.
refactor: Remove redundant conditional #17971
pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:remove-redundant-conditional changing 1 files +1 −2-
Bushstar commented at 10:52 AM on January 21, 2020: contributor
- fanquake added the label Refactoring on Jan 21, 2020
-
practicalswift commented at 11:46 AM on January 21, 2020: contributor
ACK 647c63c4f3ffe9fb3b5ff091f9e85dc4667e54ee -- redundant code is confusing and obscures the intent of the code
Thanks for linking to the removal that made this redundant - that makes the context clear.
-
Bushstar commented at 11:53 AM on January 21, 2020: contributor
@fanquake the build failed to what seems like an issue unrelated to this commit, same reason the following builds failed on recent commits.
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/30242431 https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/30242115
-
hebasto commented at 12:59 PM on January 21, 2020: member
Is there a unit test for that?
- kristapsk approved
-
kristapsk commented at 1:11 PM on January 21, 2020: contributor
ACK 647c63c4f3ffe9fb3b5ff091f9e85dc4667e54ee
-
emilengler commented at 1:58 PM on January 21, 2020: contributor
ACK 647c63c
Maybe it's better to change the title of the PR and the commit mesage to:
refactor: Remove redundant conditional - Bushstar renamed this:
Remove redundant conditional
refactor: Remove redundant conditional
on Jan 21, 2020 -
refactor: Remove redundant conditional e80317be5f
- Bushstar force-pushed on Jan 21, 2020
-
- theStack approved
-
theStack commented at 2:43 PM on January 21, 2020: member
ACK 647c63c
-
promag commented at 2:55 PM on January 21, 2020: member
ACK e80317be5fc6f6a04ea3b35bfe9991b3a5d29f7a.
Removed condition already checked at line 89.
Restarted appveyor.
-
emilengler commented at 3:04 PM on January 21, 2020: contributor
re-ACK e80317be5fc6f6a04ea3b35bfe9991b3a5d29f7a
-
practicalswift commented at 3:11 PM on January 21, 2020: contributor
ACK e80317be5fc6f6a04ea3b35bfe9991b3a5d29f7a
-
hebasto commented at 4:01 PM on January 21, 2020: member
ACK e80317be5fc6f6a04ea3b35bfe9991b3a5d29f7a, I have reviewed the code, and it looks OK, I agree it can be merged.
- Bushstar force-pushed on Jan 22, 2020
- Bushstar force-pushed on Jan 22, 2020
-
Bushstar commented at 9:50 AM on January 22, 2020: contributor
@fanquake Trying again now that the appveyor issue appears to be fixed.
Note that commit is still https://github.com/bitcoin/bitcoin/commit/e80317be5fc6f6a04ea3b35bfe9991b3a5d29f7a, just changed and changed back to rerun CI.
-
theStack commented at 10:17 AM on January 22, 2020: member
-
Empact commented at 1:38 AM on January 23, 2020: member
- fanquake referenced this in commit e061b8dc8f on Jan 29, 2020
- fanquake merged this on Jan 29, 2020
- fanquake closed this on Jan 29, 2020
- sidhujag referenced this in commit f4e31c50a5 on Feb 1, 2020
- jasonbcox referenced this in commit fd36863a2e on Sep 28, 2020
- sidhujag referenced this in commit 3a7f5b0faa on Nov 10, 2020
- PastaPastaPasta referenced this in commit d08ca08bfd on Jun 27, 2021
- PastaPastaPasta referenced this in commit 8bc824791a on Jun 28, 2021
- PastaPastaPasta referenced this in commit d6e59ad129 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 228f3e659e on Jul 1, 2021
- PastaPastaPasta referenced this in commit f16571e9e3 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 268ab077d4 on Jul 14, 2021
- PastaPastaPasta referenced this in commit 125252c9f6 on Sep 17, 2021
- PastaPastaPasta referenced this in commit 79bdf2c3bd on Sep 18, 2021
- thelazier referenced this in commit 603a7b2443 on Sep 25, 2021
- DrahtBot locked this on Feb 15, 2022
