Display command line usage to console without requiring X Windows #18604

1. 
   rebroad commented at 12:15 pm on April 12, 2020: contributor

   Fixes #18602
2. Display command line usage to console without requiring X Windows

   Fixes #18602

   b8fce8f481
3. fanquake added the label GUI on Apr 12, 2020
4. in src/qt/bitcoin.cpp:437 in b8fce8f481

   432@@ -431,6 +433,32 @@ int GuiMain(int argc, char* argv[])
   433     QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
   434 #endif
   435 
   436+#if defined(WIN32)
   437+#else
   

   ---

   ---

   

   luke-jr commented at 4:33 pm on April 23, 2020:

   0#ifndef WIN32
   

5. in src/qt/bitcoin.cpp:441 in b8fce8f481

   432@@ -431,6 +433,32 @@ int GuiMain(int argc, char* argv[])
   433     QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
   434 #endif
   435 
   436+#if defined(WIN32)
   437+#else
   438+    node->setupServerArgs();
   439+    SetupUIArgs();
   440+    std::string error;
   441+    if (!gArgs.ParseParameters(argc, argv, error))
   

   ---

   ---

   

   luke-jr commented at 4:35 pm on April 23, 2020:

   Instead of duplicating code, perhaps move it to a new function.

   ---

   

   laanwj commented at 1:26 pm on May 4, 2020:

   Agree. I really dislike duplicating all this code. I’m also not convinced that moving ParseParameters to another place in the initialization sequence won’t interfere with some other part of the initialization sequence. It’s quite a fragile sequence, carefully balanced to work for all use cases.
6. luke-jr changes_requested
7. 
   luke-jr commented at 4:39 pm on April 23, 2020: member

   Concept ACK: It seems console-printed --help and errors in command-line options is the norm for other GUI applications as well.
8. 
   practicalswift commented at 3:04 pm on April 24, 2020: contributor

   Concept ACK
9. 
   MarcoFalke commented at 10:47 am on May 17, 2020: member

   Can’t this be worked around by setting QT_QPA_PLATFORM=minimal or so?
10. 
    DrahtBot commented at 8:12 pm on May 29, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19104 (gui, refactor: Register Qt meta types in application constructor by promag)
    • #17877 (qt, refactor: Make enums in BitcoinUnits class scoped by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. DrahtBot added the label Needs rebase on Jun 2, 2020
12. 
    DrahtBot commented at 7:51 am on June 2, 2020: member

    🐙 This pull request conflicts with the target branch and needs rebase.

13. 
    fanquake commented at 3:17 pm on July 9, 2020: member

    This has a couple Concept ACKs, however needs follow up and comments addressing. Suggest moving to the GUI repo: https://github.com/bitcoin-core/gui.
14. fanquake closed this on Jul 9, 2020

    ---

15. DrahtBot locked this on Feb 15, 2022

Contributors
rebroad luke-jr laanwj practicalswift MarcoFalke DrahtBot fanquake

Labels
GUI Needs rebase