qt: remove bug fix for Qt < 5.5 #18769

pull 10xcryptodev wants to merge 1 commits into bitcoin:master from 10xcryptodevforks:pr_qt_remove_todo changing 1 files +0 −8

10xcryptodev commented at 6:13 PM on April 25, 2020: contributor

Remove the code used to fix a Qt bug in versions before Qt 5.5.0 as described in this link https://bugreports.qt.io/browse/QTBUG-43473

Now the minimum requirement is Qt 5.5.1 as described in https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md

This code is not necessary anymore
hebasto commented at 7:16 PM on April 25, 2020: member

Concept ACK.
DrahtBot added the label GUI on Apr 25, 2020
practicalswift commented at 4:47 AM on April 26, 2020: contributor

Concept ACK

Welcome as a contributor @10xcryptodev!

Thanks for removing old cruft! :)
hebasto approved
hebasto commented at 3:32 PM on April 26, 2020: member

ACK 514dfab03f817e806482aecdb98b77a19b6f88f8, tested on Linux Mint 19.3 with system Qt 5.9.5.

In the "Coin Selection" window with "Tree mode" set, clicking on checkbox of a parent with children set state to Qt::Checked, as expected. No regressions are found.

Just for references, history of the removed LOCs: #3846, #7334, #13458.
hebasto commented at 3:41 PM on April 26, 2020: member

@10xcryptodev Thank you for your contributing!

Mind changing the commit message prefix from "todo:" to "qt:" (see: Contributing to Bitcoin Core)? I'll re-ACK then :)
qt: remove todo bug fix for old versions of Qt e3ec4924a7
10xcryptodev force-pushed on Apr 26, 2020
10xcryptodev commented at 5:01 PM on April 26, 2020: contributor

@hebasto updated the commit message. Thanks for reviewing @practicalswift thanks!

It's a honor to contribute with bitcoin code
hebasto approved
hebasto commented at 5:37 PM on April 26, 2020: member

re-ACK e3ec4924a72c33f202b10a82e8498875d8f1b775, since the previous review only the prefix of the commit message has been changed.
fanquake renamed this:
~~qt: todo - remove bug fix for old versions of Qt~~
qt: remove bug fix for Qt < 5.5
on Apr 28, 2020
fanquake merged this on Apr 28, 2020
fanquake closed this on Apr 28, 2020
sidhujag referenced this in commit cac95c87a7 on Apr 28, 2020
10xcryptodev referenced this in commit 557b144d55 on Jun 12, 2020
deadalnix referenced this in commit 6b149463a9 on Jan 21, 2021
ftrader referenced this in commit 511a1e7d09 on Apr 14, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels