Remove references to CreateWalletFromFile #20285

1. 
   fanquake commented at 12:45 pm on November 2, 2020: member

   CWallet::CreateWalletFromFile() was removed in 8b5e7297c02f3100a9cb27bfe206e3fc617ec173 but these references remain.
2. hebasto approved
3. 
   hebasto commented at 12:49 pm on November 2, 2020: member

   Approach ACK 54ac7c87c38d6780389bf1edf38bb6327b099b83

   https://github.com/bitcoin/bitcoin/blob/c5ec0367d718544caa3a1578d6c730fc92ee4e94/test/sanitizer_suppressions/tsan#L35 ?

4. 
   practicalswift commented at 1:48 pm on November 2, 2020: contributor

   Concept ACK: thanks for removing old cruft, but please remove the entry from test/sanitizer_suppressions/tsan too :)
5. DrahtBot added the label Wallet on Nov 2, 2020
6. 
   DrahtBot commented at 2:57 pm on November 2, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19983 (Drop some TSan suppressions by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake force-pushed on Nov 3, 2020
8. 
   fanquake commented at 12:21 pm on November 3, 2020: member

   ? but please remove the entry from test/sanitizer_suppressions/tsan too :)

   Done.

9. dergoegge approved
10. 
    dergoegge commented at 3:22 pm on November 7, 2020: member

    ACK https://github.com/bitcoin/bitcoin/commit/64ffbba0843c123ae1de75847d4b303460d20e2f - All the references to CreateWalletFromFile were removed, except the ones in the release notes.

    Before:

     0[niklas:~/workspace/bitcoin] c5ec0367d* ± ag "CreateWalletFromFile" .
     1test/sanitizer_suppressions/tsan
     235:deadlock:wallet_tests::CreateWalletFromFile
     3
     4doc/release-notes/release-notes-0.19.0.1.md
     5491:- [#16745](/bitcoin-bitcoin/16745/) Translate all initErrors in CreateWalletFromFile (MarcoFalke)
     6495:- [#16796](/bitcoin-bitcoin/16796/) Fix segfault in CreateWalletFromFile (MarcoFalke)
     7
     8src/wallet/test/wallet_tests.cpp
     9691://! Test CreateWalletFromFile function and its behavior handling potential race
    10709:BOOST_FIXTURE_TEST_CASE(CreateWalletFromFile, TestChain100Setup)
    11
    12src/init.cpp
    131148:        // High fee check is done afterward in CWallet::CreateWalletFromFile()
    

    After:

    0[niklas:~/workspace/bitcoin] createwalletfromfilenomore* ± ag "CreateWalletFromFile" .
    1doc/release-notes/release-notes-0.19.0.1.md
    2491:- [#16745](/bitcoin-bitcoin/16745/) Translate all initErrors in CreateWalletFromFile (MarcoFalke)
    3495:- [#16796](/bitcoin-bitcoin/16796/) Fix segfault in CreateWalletFromFile (MarcoFalke)
    

11. Remove references to CreateWalletFromFile

    CWallet::CreateWalletFromFile() was removed in
    8b5e7297c02f3100a9cb27bfe206e3fc617ec173 but these references remain.

    c82336c493
12. in test/sanitizer_suppressions/tsan:35 in 64ffbba084 outdated

    31@@ -32,7 +32,6 @@ deadlock:CConnman::ForNode
    32 deadlock:CConnman::GetNodeStats
    33 deadlock:CChainState::ConnectTip
    34 deadlock:UpdateTip
    35-deadlock:wallet_tests::CreateWalletFromFile
    

    ---

    ---

    

    hebasto commented at 7:37 pm on November 7, 2020:

    This could be removed after #19982 fix. But now I’d suggest s/CreateWalletFromFile/CreateWallet/.

    ---

    

    fanquake commented at 5:13 am on November 12, 2020:

    Ok. I’ve done that.
13. fanquake force-pushed on Nov 12, 2020
14. fanquake force-pushed on Nov 12, 2020
15. hebasto approved
16. 
    hebasto commented at 8:17 am on November 12, 2020: member

    ACK c82336c493b112160d781974d4066fcb956b85f6
17. MarcoFalke added the label Refactoring on Nov 12, 2020
18. MarcoFalke merged this on Nov 12, 2020
19. MarcoFalke closed this on Nov 12, 2020

    ---

20. sidhujag referenced this in commit 62dcd66dc7 on Nov 12, 2020
21. Fabcien referenced this in commit fb6c0e694a on Dec 23, 2021
22. DrahtBot locked this on Feb 15, 2022
23. fanquake deleted the branch on Nov 9, 2022

Contributors
fanquake hebasto practicalswift DrahtBot dergoegge

Labels
Refactoring Wallet