Rather than using cd
to jump all over the place, move up out of
qtbase first, and perform all (q)make
commands from the
top level directory. This is worst in the config commands.
Looking at bash like cd ../../../..
gives me a headache.
Rather than using cd
to jump all over the place, move up out of
qtbase first, and perform all (q)make
commands from the
top level directory. This is worst in the config commands.
Looking at bash like cd ../../../..
gives me a headache.
Rather than using cd to jump all over the place, move up out of
qtbase first, and perform all commands from the top level directory.
../
:)
While touching those lines maybe pass the -makefile
mode to qmake
explicitly?
EDITED: nm, -o Makefile
is expilicit enough.
The macOS build has thrown a spanner in the works:
0x86_64-apple-darwin18-ar cq ../../../lib/libqtlibpng.a .obj/png.o .obj/pngerror.o .obj/pngget.o .obj/pngmem.o .obj/pngpread.o .obj/pngread.o .obj/pngrio.o .obj/pngrtran.o .obj/pngrutil.o .obj/pngset.o .obj/pngtrans.o .obj/pngwio.o .obj/pngwrite.o .obj/pngwtran.o .obj/pngwutil.o
1make[2]: x86_64-apple-darwin18-ar: Command not found
While touching those lines maybe pass the -makefile mode to qmake explicitly?
Sure. I’ll look at that while fixing the macOS issue.
The macOS build has thrown a spanner in the works:
0x86_64-apple-darwin18-ar cq ../../../lib/libqtlibpng.a .obj/png.o .obj/pngerror.o .obj/pngget.o .obj/pngmem.o .obj/pngpread.o .obj/pngread.o .obj/pngrio.o .obj/pngrtran.o .obj/pngrutil.o .obj/pngset.o .obj/pngtrans.o .obj/pngwio.o .obj/pngwrite.o .obj/pngwtran.o .obj/pngwutil.o 1make[2]: x86_64-apple-darwin18-ar: Command not found
Mind testing along with #19882?
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
The macOS build has thrown a spanner in the works:
0x86_64-apple-darwin18-ar cq ../../../lib/libqtlibpng.a .obj/png.o .obj/pngerror.o .obj/pngget.o .obj/pngmem.o .obj/pngpread.o .obj/pngread.o .obj/pngrio.o .obj/pngrtran.o .obj/pngrutil.o .obj/pngset.o .obj/pngtrans.o .obj/pngwio.o .obj/pngwrite.o .obj/pngwtran.o .obj/pngwutil.o 1make[2]: x86_64-apple-darwin18-ar: Command not found
Mind testing along with #19882? @fanquake The combined commits build is here: https://cirrus-ci.com/task/5002113291911168