doc: Update dependencies.md #21435

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:210314-deps changing 1 files +3 −2

hebasto commented at 11:17 AM on March 14, 2021: member
Update docs according to the recent changes in the code:
- #21209 (zlib)
- #21376 (libnatpmp)
doc: Update zlib info in dependencies.md 1a01a5dc8d
fanquake added the label Docs on Mar 14, 2021
hebasto renamed this:
~~doc: Update zlib info in dependencies.md~~
doc: Update dependencies.md
on Mar 14, 2021
DrahtBot commented at 4:48 PM on March 15, 2021: member



🕵️ @harding @fanquake have been requested to review this pull request as specified in the REVIEWERS file.
doc: Update libnatpmp info in dependencies.md bb3f79fbdc

in doc/dependencies.md:17 in f168e0622d outdated

  13 | @@ -14,7 +14,7 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct
  14 |  | GCC |  | [7+](https://gcc.gnu.org/) (C++17 support) |  |  |  |
  15 |  | HarfBuzz-NG |  |  |  |  | [Yes](https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk) |
  16 |  | libevent | [2.1.11-stable](https://github.com/libevent/libevent/releases) | [2.0.21](https://github.com/bitcoin/bitcoin/pull/18676) | No |  |  |
  17 | -| libnatpmp | [20150609](https://miniupnp.tuxfamily.org/files) |  | No |  |  |
  18 | +| libnatpmp | [4536032...](https://github.com/miniupnp/libnatpmp/tree/4536032ae32268a45c073a4d5e91bbab4534773a) |  | No |  |  |

laanwj commented at 5:40 PM on March 16, 2021:

Maybe add 'git' in front, it's not obvious that it changes from a date/version to a commit hash here (moreso because it happens to be all numbers :smile: )

hebasto commented at 5:47 PM on March 16, 2021:

Thanks. Updated.

hebasto force-pushed on Mar 16, 2021
hebasto commented at 5:50 PM on March 16, 2021: member
Updated f168e0622d15694f565bcdd3ded3e441d8402aee -> bb3f79fbdcd792aff04b2bf111de13219cd9ad56 (pr21435.01 -> pr21435.02, diff):
- addressed @laanwj's comment
laanwj commented at 5:57 PM on March 16, 2021: member

Thanks, LGTM now

in doc/dependencies.md:46 in bb3f79fbdc

  42 | @@ -43,3 +43,4 @@ Some dependencies are not needed in all configurations. The following are some f
  43 |  
  44 |  #### Other
  45 |  * librsvg is only needed if you need to run `make deploy` on (cross-compilation to) macOS.
  46 | +* Not-Qt-bundled zlib is required to build the [DMG tool](../contrib/macdeploy/README.md#deterministic-macos-dmg-notes) from the libdmg-hfsplus project.

fanquake commented at 1:56 AM on March 17, 2021:

This can just be zlib

fanquake approved
fanquake commented at 3:39 AM on March 18, 2021: member

ACK bb3f79fbdcd792aff04b2bf111de13219cd9ad56 - thanks for keeping this updated.
fanquake merged this on Mar 18, 2021
fanquake closed this on Mar 18, 2021
hebasto deleted the branch on Mar 18, 2021
sidhujag referenced this in commit b3e4229108 on Mar 18, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#21209 build: use newer source for libnatpmp #21376 depends: Qt 5.12.10