A 32-bit application for Windows in 2021 looks outdated. I'm pretty sure no one is going to run Bitcoin Core v23.0 on 32-bit Windows.
Also see #15939.
build: Drop 32-bit build configurations for MSVC #22908
pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:210907-win32 changing 4 files +6 −119-
hebasto commented at 8:42 AM on September 7, 2021: member
-
hebasto commented at 8:43 AM on September 7, 2021: member
cc @sipsorcery
- hebasto added the label Build system on Sep 7, 2021
- hebasto added the label Windows on Sep 7, 2021
-
practicalswift commented at 8:50 AM on September 8, 2021: contributor
Concept ACK
Somewhat related:
- "As the number of developers testing on these platforms decrease the probability of errors due to incorrect assumptions about
sizeof(size_t),sizeof(time_t)andsizeof(long)is likely to increase." (from PR #16096)
- "As the number of developers testing on these platforms decrease the probability of errors due to incorrect assumptions about
-
build_msvc: Make bitcoin-util ProjectGuid unique b3decea7f6
-
build_msvc: Drop 32-bit build configurations 57b3c5bda6
- hebasto force-pushed on Sep 8, 2021
-
hebasto commented at 9:02 AM on September 8, 2021: member
Rebased 8c49dc2b7402d6b6b8cd00c4784abf6e86071c30 -> 57b3c5bda648016747553f49b6107fd6c7d90235 (pr22908.01 -> pr22908.02) on top of the recent changes in CI.
-
laanwj commented at 2:05 PM on September 8, 2021: member
Concept ACK. There is no point in supporting this configuration, I'm sure it's wildly under-tested. 32-bit x86 is a museum architecture by now, and accidentally using a 32-bit build on 64-bit hardware will result in lousy performance.
- fanquake requested review from sipsorcery on Sep 10, 2021
-
fanquake commented at 6:05 AM on September 10, 2021: member
Concept ACK - haven't / wont test though.
- sipsorcery approved
-
sipsorcery commented at 7:48 AM on September 10, 2021: member
Looks good to me. Nice pickup of the duplicate project GUID.
Update: Will test it out this evening.
-
sipsorcery commented at 7:34 PM on September 10, 2021: member
tACK 57b3c5bda648016747553f49b6107fd6c7d90235.
- fanquake merged this on Sep 11, 2021
- fanquake closed this on Sep 11, 2021
- sidhujag referenced this in commit 1e6369617c on Sep 11, 2021
- hebasto deleted the branch on Sep 11, 2021
- DrahtBot locked this on Oct 30, 2022
Contributors
Labels