To avoid having all files at the top level ./src directory, start moving them to their respective sub directory according to #15732.
bloom currently depends on libconsensus (CTransaction, CScript, …) and it is currently located in the libcommon. Thus, move it to src/common/. (libutil in src/util/ is for stuff that doesn’t depend on libconsensus).
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
No conflicts as of last run.
-BEGIN VERIFY SCRIPT-
# Move to directory
mkdir src/common
git mv src/bloom.cpp src/common/
git mv src/bloom.h src/common/
# Replace occurrences
sed -i 's|\<bloom\.cpp\>|common/bloom.cpp|g' $(git grep -l 'bloom.cpp')
sed -i 's|\<bloom\.h\>|common/bloom.h|g' $(git grep -l 'bloom.h')
sed -i 's|BITCOIN_BLOOM_H|BITCOIN_COMMON_BLOOM_H|g' $(git grep -l 'BLOOM_H')
-END VERIFY SCRIPT-
Code-review ACK fa2d611bedc2a755dcf84a82699c70b57b903cf6
TIL how to move files via scripted-diff (IIRC I tried once and failed, probably used “mv” rather than “git mv”…)
81@@ -82,7 +82,7 @@ bool CBloomFilter::contains(const COutPoint& outpoint) const
82 {
83 CDataStream stream(SER_NETWORK, PROTOCOL_VERSION);
84 stream << outpoint;
85- return contains(MakeUCharSpan(stream));
86+ return contains(stream);
