refactor: get wallet path relative to wallet_dir #23385

1. 
   mjdietzx commented at 2:49 PM on October 29, 2021: contributor

   Now that boost has been updated > 1.60 (see #22320), we can simplify how we get wallet path relative to wallet_dir by using: boost::filesystem::lexically_relative, removing a TODO.

   Test coverage comes from test/functional/wallet_multiwallet.py

   I first tried this in #20265 which was my first attempted PR, and funny enough exactly 1 year later I'm opening this one to hopefully finally close this.

2. refactor: get wallet path relative to wallet_dir

   Now that boost has been updated > 1.60, we can simplify how we get
   wallet path relative to wallet_dir by using:
   `boost::filesystem::lexically_relative`

   9ba7c44265
3. 
   promag commented at 3:08 PM on October 29, 2021: member

   Concept ACK, thanks!

   🎂 1 yeah 🤣

4. MarcoFalke requested review from ryanofsky on Oct 29, 2021
5. MarcoFalke requested review from fanquake on Oct 29, 2021
6. DrahtBot added the label Refactoring on Oct 29, 2021
7. DrahtBot added the label Wallet on Oct 29, 2021
8. 
   ryanofsky commented at 5:33 PM on October 29, 2021: member

   Comment #23385 (comment) appears to be a spam comment pasting PR description from #22320

9. ryanofsky approved
10. 
    ryanofsky commented at 5:35 PM on October 29, 2021: member

    Code review ACK 9ba7c44265a47880585e39d0167d057ba935ff16. Basically this same code change is made in #20744 commit b70c84348ac7a8e427a1183f894c73e52c734529, so this PR helps simplify that one

11. fanquake deleted a comment on Oct 30, 2021
12. 
    DrahtBot commented at 2:46 AM on October 30, 2021: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20744 (Use std::filesystem. Remove Boost Filesystem & System by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. lsilva01 approved
14. 
    lsilva01 commented at 4:21 AM on October 30, 2021: contributor

    Code Review ACK 9ba7c44

15. fanquake merged this on Oct 30, 2021
16. fanquake closed this on Oct 30, 2021

    ---

17. sidhujag referenced this in commit 7704bb722b on Oct 30, 2021
18. DrahtBot locked this on Oct 30, 2022

Review Requested
fanquake