Part of: #24303
This PR introduces a libbitcoinkernel static library linking in the minimal list of files necessary to use our consensus engine as-is. bitcoin-chainstate introduced in #24304 now will link against libbitcoinkernel.
Most of the changes are related to the build system.
Please read the commit messages for more details.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
libbitcoinconsensus from its own convenience library by hebasto)libunivalue a non-Libtool convenience library by hebasto)AC_DEFINE macro by hebasto)make check, not in make by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Rebased
It might make sense to add a some note about the libbitcoinkernel to https://github.com/bitcoin/bitcoin/blob/master/doc/shared-libraries.md. I don't think it would need to say much, but would be good to mention that it exists and API is under development and not stable. I also started writing a doc/design/libraries.md file in #24352 that mentions libbitcoinkernel
Pushed 07d1e5ced8 -> e322677b3b:
1 | @@ -2,6 +2,9 @@ 2 | # Distributed under the MIT software license, see the accompanying 3 | # file COPYING or http://www.opensource.org/licenses/mit-license.php. 4 | 5 | + 6 | +noinst_LTLIBRARIES += leveldb/libleveldb.la leveldb/libmemenv.la
In commit "build: Create .la library for leveldb" (e4efd8612300d7713e35d5c0fa33bfd89943a95c)
~Can you add a comment to say what these are used for and why they are noinst? If you are making a libbitcoin_kernel shared library that depends on leveldb shared libraries presuambly all the libraries need to be installed, or you need to make the leveldb libraries into "convenience libraries" that will be embedded in the libbitcoin_kernel shared library.~
UPDATE: Looking at later commits, it seems this is going the convenience-library route. But then I don't see a reason to declare these as separate libraries and declare every library twice instead of once. Following seems to work with and keeps one library definition:
--- a/src/Makefile.leveldb.include
+++ b/src/Makefile.leveldb.include
@@ -2,11 +2,11 @@
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
-LIBLEVELDB_INT = leveldb/libleveldb.a
-LIBMEMENV_INT = leveldb/libmemenv.a
+LIBLEVELDB_INT = leveldb/libleveldb.la
+LIBMEMENV_INT = leveldb/libmemenv.la
-EXTRA_LIBRARIES += $(LIBLEVELDB_INT)
-EXTRA_LIBRARIES += $(LIBMEMENV_INT)
+EXTRA_LTLIBRARIES = $(LIBLEVELDB_INT)
+EXTRA_LTLIBRARIES += $(LIBMEMENV_INT)
LIBLEVELDB = $(LIBLEVELDB_INT) $(LIBCRC32C)
LIBMEMENV = $(LIBMEMENV_INT)
sed -i s/libleveldb_a/libleveldb_la/g src/Makefile.leveldb.include
sed -i s/libmemenv_a/libmemenv_la/g src/Makefile.leveldb.include
I think this would also allow dropping extra library declarations and noinst_ lines in next two commits:
Yup! Great idea, see latest push as of e51ead8496f010315b21fb48465b120e5cb8e334
Let me know if this addresses everything
30 | @@ -23,6 +31,7 @@ LIBBITCOIN_CONSENSUS=libbitcoin_consensus.a 31 | LIBBITCOIN_CLI=libbitcoin_cli.a 32 | LIBBITCOIN_UTIL=libbitcoin_util.a 33 | LIBBITCOIN_CRYPTO_BASE=crypto/libbitcoin_crypto_base.a 34 | +LIBBITCOINCRYPTO_BASE=crypto/libbitcoin_crypto_base.la
In commit "build: Create .la library for bitcoincrypto" (cee91e43d72d8c6cdd703f159483671088ae0744)
Could we call these variables:
or:
instead of:
Using a missing underscore to distinguish static from dynamic seems like an obscure thing to do. I see that there is something similar where libbitcoinconsensus is shared and libbitcoin_consensus is static, but I think this is an isolated case which isn't great to turn into a pattern
Since e51ead8496f010315b21fb48465b120e5cb8e334 we're no longer going to be building both .a's and .la's, only .la's, which circumvents this problem.
I do agree that naming can be clearer here so am going to followup with a PR that renames all our .la variables to LTLIB*.
806 | @@ -805,8 +807,38 @@ bitcoin_util_LDADD = \ 807 | # 808 | 809 | # bitcoin-chainstate binary # 810 | -bitcoin_chainstate_SOURCES = \ 811 | - bitcoin-chainstate.cpp \ 812 | +bitcoin_chainstate_SOURCES = bitcoin-chainstate.cpp
In commit "build: Extract the libbitcoinkernel library" (08f2be497ee4769ff9d29d010433bf52c45ec103)
Commit message seems out of date "This _SOURCES list of files may seem daunting,"
Removed as of 0057c5096ec798324208485642039d69b4b6f518
1649 | AC_DEFINE([HAVE_CONSENSUS_LIB], [1], [Define this symbol if the consensus lib has been built]) 1650 | AC_CONFIG_FILES([libbitcoinconsensus.pc:libbitcoinconsensus.pc.in]) 1651 | fi 1652 | + 1653 | +AM_CONDITIONAL([BUILD_BITCOIN_KERNEL_LIB], [test "$build_experimental_kernel_lib" != "no" && ( test "$build_experimental_kernel_lib" = "yes" || test "$build_bitcoin_chainstate" = "yes" )]) 1654 | +AM_COND_IF([BUILD_BITCOIN_KERNEL_LIB], [AC_DEFINE([HAVE_KERNEL_LIB], [1], [Define this symbol if the experimental kernel lib has been built])])
In commit "build: Extract the libbitcoinkernel library" (08f2be497ee4769ff9d29d010433bf52c45ec103)
Pretty sure there should not be a HAVE_KERNEL_LIB preprocessor macro and it would be better to drop this line. Code should generally not compile differently depending on whether some other build output is enabled.
Removed as of 0057c5096ec798324208485642039d69b4b6f518
40 | @@ -40,6 +41,7 @@ LIBBITCOIN_ZMQ=libbitcoin_zmq.a 41 | endif 42 | if BUILD_BITCOIN_LIBS 43 | LIBBITCOINCONSENSUS=libbitcoinconsensus.la 44 | +LIBBITCOINKERNEL=libbitcoinkernel.la
In commit "build: Extract the libbitcoinkernel library" (08f2be497ee4769ff9d29d010433bf52c45ec103)
Maybe add if BUILD_BITCOIN_KERNEL_LIB for consistency with other code above and below which is defining library variables conditionally (BUILD_BITCOIN_LIBS, ENABLE_ZMQ, ENABLE_WALLET). I'd probably prefer to drop the conditionals for brevity, but I guess they provide a kind of documentation about conditions which libraries may get built.
Done as of 0057c5096ec798324208485642039d69b4b6f518
7 | @@ -8,7 +8,7 @@ print-%: FORCE 8 | 9 | DIST_SUBDIRS = secp256k1 10 | 11 | -AM_LDFLAGS = $(LIBTOOL_LDFLAGS) $(HARDENED_LDFLAGS) $(GPROF_LDFLAGS) $(SANITIZER_LDFLAGS) $(LTO_LDFLAGS) 12 | +AM_LDFLAGS = $(RELDFLAGS) $(LIBTOOL_LDFLAGS) $(HARDENED_LDFLAGS) $(GPROF_LDFLAGS) $(SANITIZER_LDFLAGS) $(LTO_LDFLAGS)
In commit "build: Absorb RELDFLAGS into AM_LDFLAGS" (08eb041e431f95098d7bad1cdac8ae0e806412d8)
I don't understand:
Lmk if these commits' messages make it clear:
In commit "build: Absorb RELDFLAGS into AM_LDFLAGS" (aa0017a5d931355faa221074ca615ae282c7d239)
re: #24322 (review)
Thanks, commit message now saying this is a "cleanup" does narrow down reason for the change a bit, but it still seems pretty opaque. I would maybe say "This change simplifies the build by avoiding need to repeatedly specify RELDFLAGS in individual targets, and makes the effect of the --enable-reduce-exports option more obvious in configure output" as explanations for why the change is good.
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07, thanks for helping with the wording!
1507 | @@ -1508,7 +1508,7 @@ dnl Check for reduced exports 1508 | if test "$use_reduce_exports" = "yes"; then 1509 | AX_CHECK_COMPILE_FLAG([-fvisibility=hidden], [CXXFLAGS="$CXXFLAGS -fvisibility=hidden"], 1510 | [AC_MSG_ERROR([Cannot set hidden symbol visibility. Use --disable-reduce-exports.])], [$CXXFLAG_WERROR]) 1511 | - AX_CHECK_LINK_FLAG([-Wl,--exclude-libs,ALL], [RELDFLAGS="-Wl,--exclude-libs,ALL"], [], [$LDFLAG_WERROR]) 1512 | + AX_CHECK_LINK_FLAG([-Wl,--exclude-libs,ALL], [RE_LDFLAGS="-Wl,--exclude-libs,ALL"], [], [$LDFLAG_WERROR])
In commit "build: Rename RELDFLAGS to RE_LDFLAGS" (047aff774770fb55f9cdd5bd22b51d2be0e2007b)
Would be nice to say reason for the change in commit message: RE_LDFLAGS name is supposed to be consistent with RE_CXXFLAGS name in the next commit. I do think HIDE_SYMBOLS_CXXFLAGS / HIDE_SYMBOLS_LDFLAGS names might be more clear FWIW
Done: a9eed6f181f0ddb4439243a979bb3cffe44ba33c
Going to leave the name alone for now if that's okay?
835 | @@ -836,7 +836,11 @@ lib_LTLIBRARIES += $(LIBBITCOINKERNEL) 836 | libbitcoinkernel_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(PTHREAD_FLAGS) 837 | libbitcoinkernel_la_LIBADD = $(LIBSECP256K1) leveldb/libleveldb.la leveldb/libmemenv.la $(LIBUNIVALUE) crc32c/libcrc32c.la crc32c/libcrc32c_sse42.la $(LIBBITCOINCRYPTO) 838 | libbitcoinkernel_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp256k1/include -DBUILD_BITCOIN_INTERNAL $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS) -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT) 839 | -libbitcoinkernel_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 840 | + 841 | +# libbitcoinkernel requires default symbol visibility, explicitly specify that 842 | +# here so that things still work even when user configures with 843 | +# --enable-reduce-exports 844 | +libbitcoinkernel_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -fvisibility=default
In commit "build: Put reduced exports flags in RE_CXXFLAGS" (a324a9582d69bbc96d656b65b1b55d343aadb506)
This functional change seems only tangentially related to the cleanups in the rest of this commit, and like it should be in it's own behavior-changing commit or a part of the earlier commit adding this line in the first place (commit 08f2be497ee4769ff9d29d010433bf52c45ec103 "build: Extract the libbitcoinkernel library")
Squashed it into 0057c5096ec798324208485642039d69b4b6f518 and added context in commit message
27 | @@ -28,7 +28,7 @@ 28 | #include <functional> 29 | #include <iosfwd> 30 | 31 | -const std::function<std::string(const char*)> G_TRANSLATION_FUN = nullptr; 32 | +__attribute__ ((visibility("default"))) const std::function<std::string(const char*)> G_TRANSLATION_FUN = nullptr;
In commit "b-cs: Explicitly mark G_TRANSLATION_FUN as visible" (61ab5fa1d0a8d0e77b49a24b1b7035deaea9b7c8)
Does the fact that this commit fixes a link error imply that previous commits will not build? If so, this seems like something that we might want to fix so the previous commits are functional.
In any case, it would be good to get rid of this line entirely at some point. The application shouldn't need to export its own symbols to use the library. The translation global just be a global in the library if it has to be a global.
Done a36c0ff4af800e5499bbe7aca3137581251e71b3
834 | +# bitcoinkernel library # 835 | +if BUILD_BITCOIN_KERNEL_LIB 836 | +lib_LTLIBRARIES += $(LIBBITCOINKERNEL) 837 | + 838 | +libbitcoinkernel_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(RELDFLAGS) $(PTHREAD_FLAGS) 839 | +libbitcoinkernel_la_LIBADD = $(LIBSECP256K1) leveldb/libleveldb.la leveldb/libmemenv.la $(LIBUNIVALUE) crc32c/libcrc32c.la crc32c/libcrc32c_sse42.la $(LIBBITCOINCRYPTO)
In commit "build: Absorb RELDFLAGS into AM_LDFLAGS" (08eb041e431f95098d7bad1cdac8ae0e806412d8)
It seems like this is referring to leveldb/libleveldb.la leveldb/libmemenv.la crc32c/libcrc32c.la library files directly is breaking the convention of referring to dependencies through variables like LIBSECP256K1 LIBUNIVALUE. It makes this code more tied to implementation details of leveldb and crc libraries that it would otherwise need to be.
Done 0057c5096ec798324208485642039d69b4b6f518
e322677b3b784fc48d928ae9daa7ab1ca90bfb8a mostly looks good but I think it would be good to avoid declaring leveldb, crc, and other libraries twice as .a and .la versions, and just build .la versions in the vanilla way shown https://www.gnu.org/software/libtool/manual/html_node/Using-Automake.html
Also the implementation has changed a little and I think you could update the PR description (drop the WTF paragraph)
Pushed e322677b3b784fc48d928ae9daa7ab1ca90bfb8a -> e51ead8496f010315b21fb48465b120e5cb8e334
.a's with .la's instead of creating additional .la'sLIBTOOL_APP_LDFLAGS to _LDFLAGS of .la's, see 567927c467e25a9f9b864f2dcef6bfab9ac15359's commit message for more detailsLIBLEVELDB_SSE42: bba336bdde5431f9cd615a056a7939f5cecd0a4aG_TRANSLATION_FUN in bitcoinkernel.cpp: a36c0ff4af800e5499bbe7aca3137581251e71b3
Push e51ead8496f010315b21fb48465b120e5cb8e334 -> 32183205c21411c630efd818b7b303c16da2a323
Push 32183205c21411c630efd818b7b303c16da2a323 -> d31c6015796f58dbede31fb313c382ba214b4b73
bench_bitcoin's LDADD list to compensate for ld.bfd's inability to resolve out of order references: 36494c5c02ea5e40cf18eca4094592508d47474a
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Debug-compiled with Debian clang 15.0.0, clang 13.0.1, and gcc 11.2.0. Seeing the following with clang 15.0.0 only (Debian testing, so feel free to ignore).
Debian clang version 15.0.0-++20220320111423+51e6059c1277-1~exp1~20220320111511.381
...
CXX qt/libbitcoinqt_a-bitcoingui.o
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
ACK d31c6015796f58dbede31fb313c382ba214b4b73 for each commit, code review and made debug builds (autogen/configure/make distclean/make) on debian testing with both gcc 11.2.0 and clang 15.0.0 (and also clang 13.0.1 on the final commit) and ran some unit tests
--enable-debug
--enable-bench
--enable-suppress-external-warnings
--enable-experimental-util-chainstate / --with-experimental-kernel-lib
The updates in response to the A+ review feedback by @ryanofsky look good from what I can tell.
Starting with commit 764c1f18c031166b406be439486956fb84d3b9fe "build: Extract the libbitcoinkernel library", both gcc and clang print the following while building
copying selected object files to avoid basename conflicts...
(and the probably ignorable clang 15 warnings described in #24322 (comment) appear starting with the same commit)
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
Correcting myself after re-verifying building with clang 13.0.1: it prints the warnings too.
Thanks for the review @jonatack!
Starting with commit 764c1f18c031166b406be439486956fb84d3b9fe "build: Extract the libbitcoinkernel library", both gcc and clang print the following while building
copying selected object files to avoid basename conflicts...
These are probably not too significant. While developing libbitcoinkernel we'll have some duplicate compiling of object files, but they only happen when you configure with the experimental flags and should go away in the end.
(and the probably ignorable clang 15 warnings described in #24322 (comment) appear starting with the same commit)
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
Yeah probably not too big of a problem. (Naively I think we should probably turn off -Wunused-command-line-argument at some point...)
32 | @@ -33,41 +33,44 @@ else 33 | CRC32C_CPPFLAGS_INT += -DBYTE_ORDER_BIG_ENDIAN=0 34 | endif 35 | 36 | -crc32c_libcrc32c_a_CPPFLAGS = $(AM_CPPFLAGS) $(CRC32C_CPPFLAGS_INT) $(CRC32C_CPPFLAGS) 37 | -crc32c_libcrc32c_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 38 | +crc32c_libcrc32c_la_CPPFLAGS = $(AM_CPPFLAGS) $(CRC32C_CPPFLAGS_INT) $(CRC32C_CPPFLAGS) 39 | +crc32c_libcrc32c_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 40 | +crc32c_libcrc32c_la_LDFLAGS = $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
In commit "build: Create .la library for crc32c" (636db73ae358eb07c0fe3c721d6677b7867b380f)
I think it's probably bad to apply LIBTOOL_APP_LDFLAGS flags to a library, when it seems like the whole reason that variable exists is to separate application flags from library flags. Plus, the line would be a lot more obvious if it just said -all-static literally.
It would also be nice to add simple explanatory comment above like "# Specify -all-static so libtool will only build a static version of this library. We don't need a dynamic version, and a dynamic version can't be used on windows anyway because the library doesn't currently export DLL symbols."
The longer comment in the commit message is also OK, but I think comments like these need to be in the source. Nobody could be expected to understand how these makefiles work if information about how they work is buried in commit history.
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07
36 | @@ -37,111 +37,113 @@ else 37 | LEVELDB_CPPFLAGS_INT += -DLEVELDB_PLATFORM_POSIX 38 | endif 39 | 40 | -leveldb_libleveldb_a_CPPFLAGS = $(AM_CPPFLAGS) $(LEVELDB_CPPFLAGS_INT) $(LEVELDB_CPPFLAGS) 41 | -leveldb_libleveldb_a_CXXFLAGS = $(filter-out -Wconditional-uninitialized -Werror=conditional-uninitialized -Wsuggest-override -Werror=suggest-override, $(AM_CXXFLAGS)) $(PIE_FLAGS) 42 | +leveldb_libleveldb_la_CPPFLAGS = $(AM_CPPFLAGS) $(LEVELDB_CPPFLAGS_INT) $(LEVELDB_CPPFLAGS) 43 | +leveldb_libleveldb_la_CXXFLAGS = $(filter-out -Wconditional-uninitialized -Werror=conditional-uninitialized -Wsuggest-override -Werror=suggest-override, $(AM_CXXFLAGS)) $(PIE_FLAGS) 44 | +leveldb_libleveldb_la_LDFLAGS = $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
In commit "build: Create .la library for crc32c" (636db73ae358eb07c0fe3c721d6677b7867b380f)
Same feedback here as the last commit. I think it would be clearer and more appropriate to replace $(LIBTOOL_APP_LDFLAGS) with -all-static and add a comment like "# Specify -all-static so libtool will only build a static version of this library. We don't need a dynamic version, and trying to use it breaks the windows build because we aren't currently enabling the LEVELDB_SHARED_LIBRARY and LEVELDB_COMPILE_LIBRARY flags to export DLL symbols."
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07
456 | @@ -457,9 +457,10 @@ libbitcoin_wallet_tool_a_SOURCES = \ 457 | $(BITCOIN_CORE_H) 458 | 459 | # crypto primitives library 460 | -crypto_libbitcoin_crypto_base_a_CPPFLAGS = $(AM_CPPFLAGS) 461 | -crypto_libbitcoin_crypto_base_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 462 | -crypto_libbitcoin_crypto_base_a_SOURCES = \ 463 | +crypto_libbitcoin_crypto_base_la_CPPFLAGS = $(AM_CPPFLAGS) 464 | +crypto_libbitcoin_crypto_base_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 465 | +crypto_libbitcoin_crypto_base_la_LDFLAGS = $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
In commit "build: Create .la library for bitcoincrypto" (2084db283053f48cdcbb967905f13d234175a3c8)
Same feedback as previous two commits: Would be clearer and more appropriate to replace $(LIBTOOL_APP_LDFLAGS) with -all-static and add a comment like "# Specify -all-static so libtool will only build a static version of this library. We don't need a dynamic version, and trying to use it breaks the windows build because the library isn't currently exporting DLL symbols."
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07
873 | @@ -874,6 +874,8 @@ bitcoin_chainstate-clientversion.$(OBJEXT): obj/build.h 874 | 875 | # bitcoinconsensus library # 876 | if BUILD_BITCOIN_LIBS 877 | +lib_LTLIBRARIES += $(LIBBITCOINCONSENSUS)
In commit "build: Separate lib_LTLIBRARIES initialization" (89a194f669f8e1bd0ba979b07d9a282dcc6f7533)
Note (just for understanding): There is no change of behavior here even though this line is moved inside the if BUILD_BITCOIN_LIBS block because LIBBITCOINCONSENSUS variable is empty when BUILD_BITCOIN_LIBS isn't true.
Leaving open for the note.
808 | + 809 | +# bitcoinkernel library # 810 | +if BUILD_BITCOIN_KERNEL_LIB 811 | +lib_LTLIBRARIES += $(LIBBITCOINKERNEL) 812 | + 813 | +libbitcoinkernel_la_LDFLAGS = $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS)
In commit "build: Extract the libbitcoinkernel library" (764c1f18c031166b406be439486956fb84d3b9fe)
I'm confused how this could be building a shared library if LIBTOOL_APP_LDFLAGS includes -all-static "If output-file is a library, then only create a static library."
Also it doesn't seem right to specify an APP_ flag for a library.
I've been going down another deep rabbit hole with this, and it is surprisingly hard to create a shared mingw-w64 dll with libstdc++, libpthread, etc statically embedded...
What I'm going to do is just leave it as a static library for now, so that we can make progress on the main thrust of the project (even with just the static library, we will surface re-couplings via linker errors), open an issue detailing my spelunking, and work on getting the build correct in the mean time. It is very likely that LIBTOOL_IS_A_FOOL...
If this is just creating another static library now, I don't really understand why it's still so complicated? Can't you just add the static library, and not do all the libtool stuff?
If this is just creating another static library now, I don't really understand why it's still so complicated? Can't you just add the static library, and not do all the libtool stuff?
A new comment https://github.com/dongcarl/bitcoin/blob/3961a789735c874ed9b3ff4bbd64c2b850282c07/src/Makefile.am#L811-L813 mentions plans to build libbitcoinkernel as a shared library instead of a static library in the future. IIUC, libtool is needed to do that to make sure static libraries linked into the dynamic library are built with correct PIC flags.
Right, but why not leave the libtool / .la commits until the future PR that does build libbitcoinkernel as a shared library?
Right, but why not leave the libtool / .la commits until the future PR that does build libbitcoinkernel as a shared library?
~Dude, I don't know~ [EDIT: Sorry for exasperated tone. Woke up grumpy this morning!]. I think libbitcoinkernel is just big project and we're trying to make incremental progress.
These commits are simple, basically just replacing _a with _la, and would be annoying to maintain separately because they'll conflict with pretty much every other change to these files. They also clean up some obsolete things, make the libraries compatible with dynamic linking generically (not specific to libbitcoinkernel), and document the libraries varying abilities to be dynamically linked themselves. So they are good changes.
It'd be fine to move these commits into separate PRs if that would actually help get this PR reviewed. But otherwise I think questions about how PRs are subdivided are not that useful, and that it would be a loss and obstacle to progress if these changes had delayed indefinitely until they were part of some more comprehensive "future PR".
With the latest push, we build shared libraries for all platforms except Windows! 🎉
I think libbitcoinkernel is just big project and we're trying to make incremental progress.
☺️
789 | +bitcoin_chainstate_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 790 | +bitcoin_chainstate_LDFLAGS = $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS) 791 | +bitcoin_chainstate_LDADD = $(LIBBITCOINKERNEL) 792 | +# 793 | + 794 | +# bitcoinconsensus library #
In commit "build: Extract the libbitcoinkernel library" (764c1f18c031166b406be439486956fb84d3b9fe)
Not very important, but if targets were declared in order: bitcoin_chainstate, bitcoinkernel, bitcoinconsensus, less code would be moving around and related chainstate/kernel declarations would be closer together
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07
Code review ACK d31c6015796f58dbede31fb313c382ba214b4b73, but I do think
LIBTOOL_APP_LDFLAGS variable is misused throughout this PR and would be happier if it could be cleaned up before this was merged.
Apart from that though, everything else looks great. Nice work enabling the libtool builds and dealing with the windows build errors!
0 | @@ -0,0 +1,4 @@ 1 | +#include <functional>
nit: You can add the Copyright.
Fixed as of 3961a789735c874ed9b3ff4bbd64c2b850282c07
1651 | if test "$build_bitcoin_libs" = "yes"; then 1652 | AC_DEFINE([HAVE_CONSENSUS_LIB], [1], [Define this symbol if the consensus lib has been built]) 1653 | AC_CONFIG_FILES([libbitcoinconsensus.pc:libbitcoinconsensus.pc.in]) 1654 | fi 1655 | + 1656 | +AM_CONDITIONAL([BUILD_BITCOIN_KERNEL_LIB], [test "$build_experimental_kernel_lib" != "no" && ( test "$build_experimental_kernel_lib" = "yes" || test "$build_bitcoin_chainstate" = "yes" )])
I don't remember if bitcoin-chainstate is intended to be a long-term binary though you could add a rule in the top makefile to build it from the root bitcoind directory. I was confused to fail on it at first.
I don't remember if
bitcoin-chainstateis intended to be a long-term binary though you could add a rule in the top makefile to build it from the root bitcoind directory. I was confused to fail on it at first.
It could be convenient to add the rule, but I think think this is not intended to stick around long term. Instead it will be moved to an examples folder and given a cmake file (:partying_face:) and I think just detached from the main build: https://github.com/dongcarl/bitcoin/tree/2022-01-v8-on-new-kirby/src/kernel/example/bitcoin-chainstate
Light Code Review ACK d31c601
Built bitcoin-chainstate, linked with libbitcoinnkernel.so on debian 10.
This was used to, in effect, manually emulate --start-group/--end-group.
However, we can just order the libraries correctly and avoid specifying
libraries multiple times on the link line.
Note: lld (not ld.bfd) knows how to resolve out-of-order references and
doesn't seem to need the reodering
- LIBLEVELDB_SSE42_INT was defined, but never referenced anywhere
- LIBLEVELDB_SSE42 is referenced, but never defined anywhere
Apparently leveldb used to have platform-specific crc32 code before it
got split off into a separate lib.
@ryanofsky I actually didn't look into the LEVELDB_SHARED_LIBRARY and LEVELDB_COMPILE_LIBRARY flags... It doesn't seem to hard to set them correctly, perhaps that'd be a more elegant solution to my problem. Will try it.
@ryanofsky I actually didn't look into the
LEVELDB_SHARED_LIBRARYandLEVELDB_COMPILE_LIBRARYflags... It doesn't seem to hard to set them correctly, perhaps that'd be a more elegant solution to my problem. Will try it.
To be sure, I wasn't suggesting in #24322 (review) that you should set those flags. Those flags would only be needed if you wanted to drop -all-static on windows, so the comment I suggested adding explaining -all-static mentioned them. I think it is probably a good thing to keep using -all-static for internal leveldb, crc, and crypto libraries, since would keep these libraries statically linked and internal to the libbitcoinkernel shared library. You could drop -all-static, and go the route of building these libraries as shared libraries, but think there probably isn't much benefit to doing that. My suggestions were just about making usage of -all-static more explicit and better documented.
Pushed d31c6015796f58dbede31fb313c382ba214b4b73 -> 3961a789735c874ed9b3ff4bbd64c2b850282c07
An important update for reviewers: #24322 (review)
0 | @@ -0,0 +1,8 @@ 1 | +// Copyright (c) 2022 The Bitcoin Core developers 2 | +// Distributed under the MIT software license, see the accompanying 3 | +// file COPYING or http://www.opensource.org/licenses/mit-license.php. 4 | + 5 | +#include <functional> 6 | +#include <string> 7 | + 8 | +extern const std::function<std::string(const char*)> G_TRANSLATION_FUN = nullptr;
In commit "b-cs: Define G_TRANSLATION_FUN in bitcoinkernel.cpp" (9b6296dcd4f0601b6c9ff5958edf385ca12e6d75)
It might be good to add a comment explaining this like "Define G_TRANSLATION_FUN symbol in libbitcoinkernel library so users of the library aren't required to export this symbol"
Done!
1523 | @@ -1524,7 +1524,7 @@ AM_CONDITIONAL([ENABLE_SYSCALL_SANDBOX], [test "$use_syscall_sandbox" != "no"]) 1524 | 1525 | dnl Check for reduced exports 1526 | if test "$use_reduce_exports" = "yes"; then 1527 | - AX_CHECK_COMPILE_FLAG([-fvisibility=hidden], [CORE_CXXFLAGS="$CORE_CXXFLAGS -fvisibility=hidden"], 1528 | + AX_CHECK_COMPILE_FLAG([-fvisibility=hidden], [RE_CXXFLAGS="$RE_CXXFLAGS -fvisibility=hidden"],
In commit "build: Put reduced exports flags in RE_CXXFLAGS" (bd1376c178df10cf64faa8d2e810149ff0ff0d49)
The commit message rationale about "we really shouldn't be setting CXXFLAGS" doesn't seem to apply anymore now that current code is setting CORE_CXXFLAGS. But maybe another reason for changing this is to make R_CXXFLAGS consististent with RE_LDFLAGS?
Commit message should probably be fixed in any case
I removed the REFLAGS changes from this PR, thanks for the suggestion!
Code review ACK 3961a789735c874ed9b3ff4bbd64c2b850282c07. Since last review, this was rebased, some review suggestions were implemented, and comments and commit messages were updated. Main change is using -all-static more explicitly instead of LIBTOOL_APP_LDFLAGS.
I do wonder if they RE_CXXFLAGS/RE_LDFLAGS changes could be split off from this PR and moved into a separate PR. They make this more complicated, and don't seem to be actually necessary here.
re: #24322 (review)
I've been going down another deep rabbit hole with this, and it is surprisingly hard to create a shared mingw-w64 dll with libstdc++, libpthread, etc statically embedded...
I don't really think it would be an improvement to make leveldb/crc/crypto libraries dynamic instead of static. Even if you want libbitcoinkernel to be dynamic, linking these smaller libraries into it statically should be fine, and could even have benefits like allowing an application that uses libbitcoinkernel and leveldb to use a different version of leveldb than libitcoinkernel uses.
re: #24322#issue-1132989320
Part of: #24303 Depends on: #24304
This PR introduces a
libbitcoinkernellibrary linking in the minimal list of files necessary to use our consensus engine as-is. This list is moved from thebitcoin-chainstateexecutable introduced in the dependent PR #24304, andbitcoin-chainstatenow will link againstlibbitcoinkernel.Most of the changes are related to the build system.
Please read the commit messages for more details.
Note: This was split out from #24304 per this suggestion
Relevant comments/review threads prior to split
* **Topic**: Adding a CI job to test the new build procedures * [[kernel 0/n] Introduce `bitcoin-chainstate` [#24304](/bitcoin-bitcoin/24304/) (comment)](/bitcoin-bitcoin/24304/#issuecomment-1035466827) * [[kernel 0/n] Introduce `bitcoin-chainstate` [#24304](/bitcoin-bitcoin/24304/) (comment)](/bitcoin-bitcoin/24304/#issuecomment-1035479455) * [[kernel 0/n] Introduce `bitcoin-chainstate` [#24304](/bitcoin-bitcoin/24304/) (comment)](/bitcoin-bitcoin/24304/#issuecomment-1035491348) * [[kernel 0/n] Introduce `bitcoin-chainstate` [#24304](/bitcoin-bitcoin/24304/) (comment)](https://github.com/bitcoin/bitcoin/pull/24304#discussion_r804422582) * **Resolution**: Added to the "no wallet" job, see: [ci: Build bitcoin-chainstate + libbitcoinkernel](https://github.com/bitcoin/bitcoin/pull/24322/commits/d1f4494abc3f606e2fe4109edec68ce0c75eb282)You may ask: WTF?! Why is
index/*.cpp, etc. being linked in to a consensus engine library?This PR is meant only to capture the state of dependencies in our consensus engine as of right now. There are many things to decouple from consensus, which will be done in subsequent PRs. Listing the files out right now in
libbitcoinkernel_la_SOURCESis purely to give us a clear picture of the task at hand, it is not to say that these dependencies belongs in a consensus engine library in any way.Followups:
* [[kernel 1/n] Introduce initial `libbitcoinkernel` [#24322](/bitcoin-bitcoin/24322/) (comment)](https://github.com/bitcoin/bitcoin/pull/24322#discussion_r827608636)
I think basically this whole PR description is obsolete, and would be good to rewrite. Possible description might be something like "introduce libbitcoinkernel library and link it into chainstate test program. Use libtool to build static libraries that libbitcoinkernel depends on, so it can be built as a dynamic library in the future."
Pushed 3961a789735c874ed9b3ff4bbd64c2b850282c07 -> 05ad18f563d1ab1c1c6a11fcd080038a78401546
REFLAGS changes from this PR (https://github.com/bitcoin/bitcoin/pull/24322#pullrequestreview-947768622)
Code review ACK 05ad18f563d1ab1c1c6a11fcd080038a78401546. Only changes since last review are dropping reduced export cleanup commits, and changing some comments.
It would be good to have more reviewers, now that PR is simpler and more focused, and all the changes are pretty comprehensively explained. Hopefully reviewers won't be intimidated by build arcana and will ask questions if the changes and explanations aren't clear enough.
re: #24322#issue-1132989320
You may ask: WTF?! Why is
index/*.cpp, etc. being linked in to a consensus engine library?
Just a thought, but I think this paragraph of PR description is more confusing than helpful, and it's hard to figure out what' it's referring to since there are no new index/*.cpp lines being added here. Would recommend dropping this section from the PR description. If you do want to call attention to the fact libbitcoinkernel_la_SOURCES includes some files that we plan to remove in the future, I think the best place to write that would be a comment directly on libbitcoinkernel_la_SOURCES.
Just a thought, but I think this paragraph of PR description is more confusing than helpful, and it's hard to figure out what' it's referring to since there are no new
index/*.cpplines being added here. Would recommend dropping this section from the PR description. If you do want to call attention to the factlibbitcoinkernel_la_SOURCESincludes some files that we plan to remove in the future, I think the best place to write that would be a comment directly onlibbitcoinkernel_la_SOURCES.
Done in latest push!
51 | @@ -52,13 +52,13 @@ nodist_bench_bench_bitcoin_SOURCES = $(GENERATED_BENCH_FILES) 52 | bench_bench_bitcoin_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(EVENT_CFLAGS) $(EVENT_PTHREADS_CFLAGS) -I$(builddir)/bench/ 53 | bench_bench_bitcoin_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 54 | bench_bench_bitcoin_LDADD = \ 55 | + $(LIBTEST_UTIL) \
Nice, does this mean preserve-dup-deps can go away now: https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am#L14 ?
Perhaps? Although I think GNU bfd ld still has requirements on library ordering so we should probably keep it...
Yes, but only to default-enforce the (very sane imo) rule of no circular dependencies.
IIRC preserve-dup-deps was added at one point because we had a real circular dependency. If either of:
then imo the flag should be removed to put us back in the "strict ordering" mode, which would be helpful for pointing out accidental new circular dependencies.
But if I'm wrong about those two conditions, just ignore me :)
Okay I see! Let's do this as a followup.
801 | - bitcoin-chainstate.cpp \ 802 | +bitcoin_chainstate_SOURCES = bitcoin-chainstate.cpp 803 | +bitcoin_chainstate_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) 804 | +bitcoin_chainstate_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) 805 | +bitcoin_chainstate_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS) 806 | +bitcoin_chainstate_LDADD = $(LIBBITCOINKERNEL)
Shouldn't all the bitcoin_chainstate binary stuff be under the BUILD_BITCOIN_KERNEL_LIB condition below? Otherwise it'll just fail to link I think?
Fixed at configure time as of: a415b5080d288707c60634dab730ef7a5b6bb971
819 | +libbitcoinkernel_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp256k1/include -DBUILD_BITCOIN_INTERNAL $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS) -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT) 820 | + 821 | +# libbitcoinkernel requires default symbol visibility, explicitly specify that 822 | +# here so that things still work even when user configures with 823 | +# --enable-reduce-exports 824 | +libbitcoinkernel_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -fvisibility=default
Mmm, this is ok as a quick hack, but I'd prefer to describe it here as such. Mind adding that it's temporary until we actually define what's to be exported?
Eventually we'll need our own set of macros and we'll need to decorate our exported functions ala: https://github.com/bitcoin/bitcoin/blob/master/src/script/bitcoinconsensus.h#L11
Otherwise the lib ends up with everything exported and stripping/lto can't help.
Fixed as of a415b5080d288707c60634dab730ef7a5b6bb971
Looking great!
Without building locally... does the switch to libtool libs mean that more objects end up being built (other than the second set for the lib)? Or does -all-static basically fix that?
Just being paranoid... it'd be helpful imo to compare the object hashes before/after these changes just to verify that all flags are propagating to libtool correctly and that bitcoind is either unchanged or understandably changed.
Concept ACK.
Commit code reviewing:
If the -all-static Libtool flag is required for Windows builds only, why do not apply it conditionally?
Besides the -all-static mode, Libtool also suggests similar -static and -static-libtool-libs ones. Why the former has been chosen?
re: #24322#pullrequestreview-950505318
Without building locally... does the switch to libtool libs mean that more objects end up being built (other than the second set for the lib)? Or does
-all-staticbasically fix that?
I haven't confirmed this but IIUC the same number of objects should be built right now because libbitcoinkernel is still static. If it is switched to be dynamic, more objects might be built because more things need to be built with PIC flags.
re: #24322 (comment)
- If the
-all-staticLibtool flag is required for Windows builds only, why do not apply it conditionally?
Maybe we will. We are not locked into a decision here but -all-static flag works well, and fixes immediate problems on windows. Trying other flags requires testing and experimentation, which is probably not worth the effort . I do think statically linking libbitcoinkernel dependencies even when libbitcoinkernel is dynamic could have other benefits like making the library easier to link against, and letting libbitcoinkernel applications be able to use a different leveldb version than libbitcoinkernel uses (as mentioned #24322#pullrequestreview-947768622). But this is just why it static linking seems like a good choice for these libraries at the moment. The only thing actually requiring these libraries to be statically linked is that they don't export symbols on windows, which IMO is not worth making effort to implement now.
- Besides the
-all-staticmode, Libtool also suggests similar-staticand-static-libtool-libsones. Why the former has been chosen?
This is interesting. I didn't realize it before, but all three options seem identical when applied to libraries, and only different when applied to executables. The documentation for all three options at https://www.gnu.org/software/libtool/manual/html_node/Link-mode.html says "If output-file is a library, then only create a static library."
I'd probably prefer -static over -all-static for simpliciity, but I think -all-static is fine, and any of these options would be fine. History of the PR is that original version was using $LIBTOOL_APP_LDFLAGS, and $LIBTOOL_APP_LDFLAGS uses -all-static, and I thought it was inappropriate to use $LIBTOOL_APP_LDFLAGS, so I suggested using -all-static directly.
does the switch to libtool libs mean that more objects end up being built (other than the second set for the lib)? Or does -all-static basically fix that?
Unfortunately, libtool seems to always want to build twice... Not sure if we can fix that.
$ find src/crypto -name '*sha256_sse41*'
src/crypto/.libs/libbitcoin_crypto_sse41_la-sha256_sse41.o
src/crypto/libbitcoin_crypto_sse41_la-sha256_sse41.lo
src/crypto/libbitcoin_crypto_sse41_la-sha256_sse41.o
src/crypto/sha256_sse41.cpp
src/crypto/.deps/libbitcoin_crypto_sse41_la-sha256_sse41.Plo
Funnily enough these files are identical, BUT are not symlinks or hard links
$ diff --report-identical src/crypto/{.libs/,}libbitcoin_crypto_sse41_la-sha256_sse41.o
Files src/crypto/.libs/libbitcoin_crypto_sse41_la-sha256_sse41.o and src/crypto/libbitcoin_crypto_sse41_la-sha256_sse41.o are identical
$ stat src/crypto/.libs/libbitcoin_crypto_sse41_la-sha256_sse41.o | head -n3
File: src/crypto/.libs/libbitcoin_crypto_sse41_la-sha256_sse41.o
Size: 173240 Blocks: 344 IO Block: 4096 regular file
Device: 9,10 Inode: 22444798 Links: 1
$ stat src/crypto/libbitcoin_crypto_sse41_la-sha256_sse41.o | head -n3
File: src/crypto/libbitcoin_crypto_sse41_la-sha256_sse41.o
Size: 173240 Blocks: 344 IO Block: 4096 regular file
Device: 9,10 Inode: 21931470 Links: 1
I also tried specifying -prefer-pic, which according to the manual makes sure "Libtool will try to build only PIC objects." Nothing changed.
Behaviour like this (largely from libtool) has exhausted my willpower quite a bit, and I think we should just leave for later.
Code review ACK 33837804cf25c1093159936128ab3daa7472601c. Only change sinse last review is new commit adding suggested comment
Tested ae94c62b1d0ac86bb7011434f8f51ce9cbb91164 on Ubuntu 22.04:
$ cd BUILD_WINDOWS
$ ../autogen.sh
$ ../configure CONFIG_SITE=$PWD/../depends/x86_64-w64-mingw32/share/config.site --with-experimental-kernel-lib --disable-tests --disable-bench --without-utils --disable-fuzz-binary
$ make clean
$ make
...
CXXLD bitcoind.exe
CXXLD libbitcoinkernel.la
libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only
copying selected object files to avoid basename conflicts...
...
10 | @@ -11,4 +11,4 @@ export DOCKER_NAME_TAG=ubuntu:18.04 # Use bionic to have one config run the tes 11 | export PACKAGES="python3-zmq clang-8 llvm-8 libc++abi-8-dev libc++-8-dev" # Use clang-8 to test C++17 compatibility, see doc/dependencies.md 12 | export DEP_OPTS="NO_WALLET=1 CC=clang-8 CXX='clang++-8 -stdlib=libc++'" 13 | export GOAL="install" 14 | -export BITCOIN_CONFIG="--enable-reduce-exports CC=clang-8 CXX='clang++-8 -stdlib=libc++' --enable-experimental-util-chainstate" 15 | +export BITCOIN_CONFIG="--enable-reduce-exports CC=clang-8 CXX='clang++-8 -stdlib=libc++' --enable-experimental-util-chainstate --with-experimental-kernel-lib --enable-shared"
I cannot see any difference in the built artifacts that depends on the --enable-shared option.
What is expected?
With the latest push (035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b), I elected to keep it to be explicit about the fact the bitcoin-chainstate is linking against a shared libbitcoinkernel
does the switch to libtool libs mean that more objects end up being built (other than the second set for the lib)? Or does -all-static basically fix that?
Unfortunately, libtool seems to always want to build twice... Not sure if we can fix that.
I think I've come up with a reasonably clean solution to this here: https://github.com/theuni/bitcoin/commit/9ffbd707afc8188fe0b8cc5316f6c583f7ae21d0
libtool tries to build twice by default: once for static, once for shared. With this change, there's only static by default, so default configs continue to only build one set of objects.
With this commit, if you want shared libs/dlls, you'd need to configure with --enable-shared, which will then build everything twice. For a project that's mostly about executables, that seems reasonable to me. (Also, amazingly --enable-shared --disable-static does the right thing and also builds a single copy of everything for shared libs)
This also means we don't have to special-case the Windows case in this pr. We'll just know that --enable-shared is busted on windows (and maybe warn as such for that config?)
The only downside I can think of is that devs aren't going to be linking the lib every day as part of their typical workflows so link problems may show up around release time. IMO that's a reasonable trade-off.
This commit fixes Windows dll linking for me: https://github.com/theuni/bitcoin/commit/9612f5f0f1e3295065dbd8a0e0f472f8f020bbd9 . Untested, but it now links. I'll be testing it out as a next step.
Thanks to @dongcarl for pointing out the problem.
Edit: I'm unable to find what's actually affected by this define in my local mingw tree and in depends. Maybe gcc does something internally with it or something?
Edit2: Found it!: https://github.com/mingw-w64/mingw-w64/blob/f79f89f976dc5345090db557fb20d5deba913d9f/mingw-w64-libraries/winpthreads/include/pthread.h#L86
That seems like heavy-handed behavior for mingw-w64, much more useful would be for them to define and use PTHREADS_DLL_EXPORT instead. I'll work to understand this better and upstream a patch if necessary.
Libtool will yell at you if you try to link a shared library against
static ones.
This change creates a libtool archive library for crc32c and allows a
shared library to be linked against it portably.
Also specify -static in both:
- ..._la_CXXFLAGS so that libtool will avoid building two versions of
each object (one PIC, one non-PIC). We just need the one that is
suitable for static linking.
- ..._la_LDFLAGS so that libtool will create a static library.
[META] This change is done in preparation for a future commit where we
link the libbitcoinkernel library against this one.
Libtool will yell at you if you try to link a shared library against
static ones.
This change creates a libtool archive library for leveldb and allows a
shared library to be linked against it portably.
Also specify -static in both:
- ..._la_CXXFLAGS so that libtool will avoid building two versions of
each object (one PIC, one non-PIC). We just need the one that is
suitable for static linking.
- ..._la_LDFLAGS so that libtool will create a static library.
If we don't specify this, then libtool will build two versions of each
object and prefer the non-static PIC version of the object, which is
built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause
symbol resolution problems when we link this library against an
executable that does specify -all-static, since that will be built
without the -DDLL_EXPORT flag.
This is especially important for leveldb and memenv since they link
against libwinpthreads, which has difference symbols depending on
whether DLL_EXPORT is defined or not.
[META] This change is done in preparation for a future commit where we
link the libbitcoinkernel library against this one.
Appendix:
The specific linker errors when linking memenv built without -all-static
against a bitcoind with -all-static look like:
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/leveldb/helpers/memenv/memenv.cc:230: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/leveldb/helpers/memenv/memenv.cc:230: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `__gthread_mutex_unlock':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/leveldb/helpers/memenv/memenv.cc:285: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_map.h:501: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:733: undefined reference to `__imp_pthread_mutex_init'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::_Vector_base<char*, std::allocator<char*> >::_Vector_impl_data::_Vector_impl_data()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_vector.h:97: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::mutex::lock()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/std_mutex.h:104: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `leveldb::Status::IOError(leveldb::Slice const&, leveldb::Slice const&)':
/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `leveldb::Status::IOError(leveldb::Slice const&, leveldb::Slice const&)':
/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `leveldb::Status::IOError(leveldb::Slice const&, leveldb::Slice const&)':
/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_map.h:1069: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_tree.h:350: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `leveldb::Status::IOError(leveldb::Slice const&, leveldb::Slice const&)':
/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: more undefined references to `__imp_pthread_mutex_unlock' follow
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::mutex::lock()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/std_mutex.h:104: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_map.h:1069: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `leveldb::Status::IOError(leveldb::Slice const&, leveldb::Slice const&)':
/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/./leveldb/include/leveldb/status.h:53: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:740: undefined reference to `__imp_pthread_mutex_destroy'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::mutex::lock()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/std_mutex.h:100: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/distsrc-base/distsrc-99874bd94511-x86_64-w64-mingw32/src/leveldb/helpers/memenv/memenv.cc:268: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:733: undefined reference to `__imp_pthread_mutex_init'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::_Vector_base<char*, std::allocator<char*> >::_Vector_impl_data::_Vector_impl_data()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/stl_vector.h:97: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o): in function `std::mutex::lock()':
/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/std_mutex.h:104: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: /gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/bits/std_mutex.h:104: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:733: undefined reference to `__imp_pthread_mutex_init'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:749: undefined reference to `__imp_pthread_mutex_lock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
x86_64-w64-mingw32-ld: leveldb/.libs/libmemenv.a(libmemenv_la-memenv.o):/gnu/store/yn52na8xbgzpiq7fdpm9pfyyf5w3z60m-gcc-cross-x86_64-w64-mingw32-10.3.0/include/c++/x86_64-w64-mingw32/bits/gthr-default.h:779: undefined reference to `__imp_pthread_mutex_unlock'
Libtool will yell at you if you try to link a shared library against
static ones.
This change creates a libtool archive library for bitcoincrypto and
allows a shared library to be linked against it portably.
Also specify -static in both:
- ..._la_CXXFLAGS so that libtool will avoid building two versions of
each object (one PIC, one non-PIC). We just need the one that is
suitable for static linking.
- ..._la_LDFLAGS so that libtool will create a static library.
[META] This change is done in preparation for a future commit where we
link the libbitcoinkernel library against this one.
Set lib_LTLIBRARIES with '=' to an empty value at the top of the
Makefile.am and append to it from the library-local block for
readability.
Here's the error you get if you don't set lib_LTLIBRARIES to be empty:
error: lib_LTLIBRARIES must be set with '=' before using '+='
[META] In a subsequent commit, we're going to introduce a library and
append it to lib_LTLIBRARIES in its local block, this makes
things more readable.
[META] This is done in preparation for extracting libbitcoinkernel in a
following commit. It seems logical that generally users of a
library shouldn't need to export its own symbols to use the
library.@dongcarl and I discussed a few of the remaining issues today, and I've pushed up a branch on top of this one which addresses all the build issues I'm aware of: https://github.com/theuni/bitcoin/commits/24322-win-fixes
Feel free to take any/all of those commits. The "provide a way to avoid exporting on Windows by default" commit is a hack, I'm sure there's a less invasive way to do that.
Edit: These are mostly fixes for Windows, which @dongcarl has said he's not targeting here, so those fixes can be PR'd as a follow-up as necessary.
I think https://github.com/theuni/bitcoin/commit/ee29b8862fe909009357b6da88053ee2ad9f7d99 belongs in this PR, though.
I strongly recommend reviewing with the following git-diff flags:
--patience --color-moved=dimmed-zebra
Extract out a libbitcoinkernel library linking in all files necessary
for using our consensus engine as-is. Link bitcoin-chainstate against
it.
See previous commit "build: Add example bitcoin-chainstate executable"
for more context.
We explicitly specify -fvisibility=default, which effectively overrides
the effects of --enable-reduced-exports since libbitcoinkernel requires
default symbol visibility
When compiling for mingw-w64, specify -static in both:
- ..._la_CXXFLAGS so that libtool will avoid building two versions of
each object (one PIC, one non-PIC). We just need the one that is
suitable for static linking.
- ..._la_LDFLAGS so that libtool will create a static library.
If we don't specify this, then libtool will prefer the non-static PIC
version of the object, which is built with -DDLL_EXPORT -DPIC for
mingw-w64 targets. This can cause symbol resolution problems when we
link this library against an executable that does specify -all-static,
since that will be built without the -DDLL_EXPORT flag.
Unfortunately, this means that for mingw-w64 we can only build a static
version of the library for now. This will be fixed.
However, on other targets, the shared library creation works fine.
-----
Note to users: You need to either specify:
--enable-experimental-util-chainstate
or,
--with-experimental-kernel-lib
To build the libbitcionkernel library. See the configure help for more
details.
build shared libbitcoinkernel where we can
See added comment.
Note that this won't actually have any effect until we add the mingw-w64
DLL fix since LIBTOOL_APP_LDFLAGS is undefined for other platforms.
From ae94c62b1d0ac86bb7011434f8f51ce9cbb91164 -> 035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b
-static instead of -all-static (there's no difference for libraries)-static in CXXFLAGS and LDFLAGS to ensure that objects aren't compiled twice for no good reasonlibbitcoinkernel on all platforms other than windows (marked as a TODO, tracked here: #25008)LIBTOOL_APP_LDFLAGS so that we can link bitcoin-chainstate against both shared and static versions of libbitcoinkernel
- If the
-all-staticLibtool flag is required for Windows builds only, why do not apply it conditionally?
Incorporated as of 035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b
- Besides the
-all-staticmode, Libtool also suggests similar-staticand-static-libtool-libsones. Why the former has been chosen?
-static chosen as of 035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b
I've been experimenting with this for a few platforms in various configs today. At this point everything seems to build/link as expected with the exception of Windows, and those patches are in the pipeline.
I don't love the idea of merging this without anything testing the resulting shared libs for viability, but there's so much work left to do here that I think this is a reasonable stopping point, so imo it's ok to follow up with some trivial tests.
I won't be surprised if the libtool switch causes some unforeseen build breakage for some of the more esoteric platforms over the next few weeks. If so, I'm hoping we can solve those quickly as they arise.
This may be my favorite PR ever. It's a privilege to ACK 035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b.
Well done :)
28 | @@ -29,6 +29,7 @@ LIBBITCOIN_NODE=libbitcoin_node.a 29 | LIBBITCOIN_COMMON=libbitcoin_common.a 30 | LIBBITCOIN_CONSENSUS=libbitcoin_consensus.a 31 | LIBBITCOIN_CLI=libbitcoin_cli.a 32 | +LIBBITCOIN_KERNEL=libbitcoin_kernel.a
Nit: I think this is extraneous?
I don't love the idea of merging this without anything testing the resulting shared libs for viability, but there's so much work left to do here that I think this is a reasonable stopping point, so imo it's ok to follow up with some trivial tests.
Ideally we'll have the Windows libtool issues sorted next. Further changes / nits can be addressed in the next PRs in the kernel series.
53 | + 54 | +# Specify -static in both CXXFLAGS and LDFLAGS so libtool will only build a 55 | +# static version of this library. We don't need a dynamic version, and a dynamic 56 | +# version can't be used on windows anyway because the library doesn't currently 57 | +# export DLL symbols. 58 | +crc32c_libcrc32c_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
In commit "build: Create .la library for leveldb" (8bdfe057c796dde1cd2e5a37a73e87a879e9fe56)
Note: I was confused how adding -static to CXXFLAGS could even do anything, but apparently -static is a compile mode flags as well as a link mode flag for libtool (https://www.gnu.org/software/libtool/manual/html_node/Compile-mode.html https://www.gnu.org/software/automake/manual/html_node/Libtool-Flags.html), and the compile mode overrides the override for something, idk.
Heh, yes, that's about it. libtool manages to defy intuition at about every turn, but at least the outcome here is reasonable (I hope!).
By default for every lib it wants to build a shared and static version, and because of the differing export semantics it wants to compile one set of objects to go into the shared library, and another set for the static library.
Adding -static in LDFLAGS tells it to disable any linking, but it'll still build the "shared" objects as well.
Adding -static in CXXFLAGS tells it that there will be nothing to link in the end, so there's no point in building the "shared" objects.
As for argument parsing, yes, it's really nasty. libtool gobbles up parameters passed to the compiler/linker and attempts to substitute the correct actions. It gets hairy when there's ambiguity with keywords (like "-static").
It's a dinosaur :(
Adding
-staticin CXXFLAGS tells it that there will be nothing to link in the end, so there's no point in building the "shared" objects.
Hmm, I'm not sure what's going on exactly, but removing -static from leveldb_libleveldb_la_CXXFLAGS
--- a/src/Makefile.leveldb.include
+++ b/src/Makefile.leveldb.include
@@ -43,7 +43,7 @@ leveldb_libleveldb_la_CPPFLAGS = $(AM_CPPFLAGS) $(LEVELDB_CPPFLAGS_INT) $(LEVELD
# static version of this library. We don't need a dynamic version, and a dynamic
# version can't be used on windows anyway because the library doesn't currently
# export DLL symbols.
-leveldb_libleveldb_la_CXXFLAGS = $(filter-out -Wconditional-uninitialized -Werror=conditional-uninitialized -Wsuggest-override -Werror=suggest-override, $(AM_CXXFLAGS)) $(PIE_FLAGS) -static
+leveldb_libleveldb_la_CXXFLAGS = $(filter-out -Wconditional-uninitialized -Werror=conditional-uninitialized -Wsuggest-override -Werror=suggest-override, $(AM_CXXFLAGS)) $(PIE_FLAGS)
leveldb_libleveldb_la_LDFLAGS = $(AM_LDFLAGS) -static
leveldb_libleveldb_la_SOURCES=
changes nothing in building libleveldb.la -- I've compared verbose build logs and build directories.
But many other -libtool: compile: calls are not invoked twice, and .libs/libbitcoinconsensus.so.0.0.0 is not created.
I used the following configuration:
$ ./configure --enable-suppress-external-warnings --disable-wallet --without-gui --without-utils --disable-tests --disable-bench --disable-fuzz-binary --without-zmq CC=clang CXX=clang++
Code review ACK 035fa1f07aacb7bce74c0884ae28c8cf00fe3b1b
<sub>Want cmake</sub>
Code review ACK 035fa1f
Want cmake
+1
Lots of time and effort here went into fighting with the buildsystem, and that's no good. It's working against us rather than for us more and more it seems.
I've switched to using CMake for my personal projects, and these days it's much more pleasant to work with than it used to be.
I know I've been one of the loudest and last objectors to it over the years, and yeah, I'm feeling bad lately for stalling the inevitable switch. Sorry :(
Want cmake
+1
+1
817 | + 818 | +# bitcoinkernel library # 819 | +if BUILD_BITCOIN_KERNEL_LIB 820 | +lib_LTLIBRARIES += $(LIBBITCOINKERNEL) 821 | + 822 | +libbitcoinkernel_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(RELDFLAGS) $(PTHREAD_FLAGS)
Is this needed? I get a warning that it is unused:
...
CXXLD libbitcoinkernel.la
clang-13: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang-13: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
copying selected object files to avoid basename conflicts...