util: move threadinterrupt into util/ #26292

1. 
   fanquake commented at 7:42 am on October 11, 2022: member

   Alongside thread and threadnames. It’s part of libbitcoin_util.
2. DrahtBot added the label Utils/log/libs on Oct 11, 2022
3. 
   DrahtBot commented at 5:28 pm on October 11, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   theuni commented at 6:17 pm on October 11, 2022: member

   Concept ACK. To make it more obvious to reviewers, it might be a good time to update the comments in Makefile.am to reflect what @ryanofsky said here and here.
5. in src/i2p.h:13 in 7b2d0b0811 outdated

    8@@ -9,8 +9,8 @@
    9 #include <fs.h>
   10 #include <netaddress.h>
   11 #include <sync.h>
   12-#include <threadinterrupt.h>
   13 #include <util/sock.h>
   14+#include <util/threadinterrupt.h>
   

   ---

   ---

   

   Empact commented at 8:52 pm on October 11, 2022:

   nit: Could replace with class CThreadInterrupt;
6. in src/util/sock.h:9 in 7b2d0b0811 outdated

    5@@ -6,7 +6,7 @@
    6 #define BITCOIN_UTIL_SOCK_H
    7 
    8 #include <compat/compat.h>
    9-#include <threadinterrupt.h>
   10+#include <util/threadinterrupt.h>
   

   ---

   ---

   

   Empact commented at 3:56 pm on October 12, 2022:

   nit: Could replace with class CThreadInterrupt;
7. ryanofsky approved
8. 
   ryanofsky commented at 5:09 pm on October 12, 2022: contributor

   Code review ACK 7b2d0b0811b0faf7f09a119354a22ecfd869720b
9. in src/Makefile.am:944 in 7b2d0b0811 outdated

   940@@ -942,6 +941,7 @@ libbitcoinkernel_la_SOURCES = \
   941   util/syserror.cpp \
   942   util/system.cpp \
   943   util/thread.cpp \
   944+  util/threadinterrupt.cpp \
   

   ---

   ---

   

   hebasto commented at 6:00 pm on October 12, 2022:

   Is it really required in libbitcoinkernel?

   I’ve managed to ./configure --with-experimental-kernel-lib --enable-experimental-util-chainstate && make flawlessly without this source file.

   ---

   

   fanquake commented at 8:42 am on October 21, 2022:

   Opened #26360.
10. 
    fanquake commented at 9:10 am on October 14, 2022: member

    To make it more obvious to reviewers, it might be a good time to update the comments in Makefile.am to reflect what ryanofsky said #26196#pullrequestreview-1130117250 and #26196 (comment).

    Rather than adding more duplicate commentary there, I’ve opened #26313 to drop those comments, in favour of doc/libraries.md, which is much more comprehensive.

11. maflcko referenced this in commit ba441d493c on Oct 18, 2022
12. fanquake force-pushed on Oct 21, 2022
13. ryanofsky approved
14. 
    ryanofsky commented at 5:43 pm on October 31, 2022: contributor

    Code review ACK bd799386882a75bfe6032a5cf53cf1a15b29b7fb
15. fanquake referenced this in commit c041d8f2c9 on Nov 1, 2022
16. util: move threadinterrupt into util b89530483d
17. fanquake force-pushed on Nov 1, 2022
18. 
    fanquake commented at 10:16 am on November 1, 2022: member

    Rebased past #26360 and #26294.
19. ryanofsky approved
20. 
    ryanofsky commented at 3:12 pm on November 1, 2022: contributor

    Code review ACK b89530483d39f6a6a777df590b87ba2fad8c8b60. No changes since last review other than rebase
21. sidhujag referenced this in commit b6455439bc on Nov 1, 2022
22. theuni approved
23. 
    theuni commented at 8:17 pm on November 2, 2022: member

    ACK b89530483d39f6a6a777df590b87ba2fad8c8b60.

    No objection, but why the added includes (i2p.cpp for ex) where the matching header already pulls it in?

24. fanquake merged this on Nov 22, 2022
25. fanquake closed this on Nov 22, 2022

    ---

26. fanquake deleted the branch on Nov 22, 2022
27. sidhujag referenced this in commit 616f8589d2 on Nov 22, 2022
28. bitcoin locked this on Nov 22, 2023

Contributors
fanquake DrahtBot theuni Empact ryanofsky hebasto

Labels
Utils/log/libs