Bitcoin failed to build with error MSB3073 on MSVC #26324

<!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

<!-- Describe the issue -->

Expected behavior Build successfully.

<!--- What behavior did you expect? -->

Actual behavior Hi all, Bitcoin fails to build on MSVC due to error MSB3073, the same problem also appeared in vs2019, I mentioned a same issue but it was closed. Could you help look?

<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

error message 23>F:\gitP\bitcoin\bitcoin\build_msvc\libbitcoin_qt\libbitcoin_qt.vcxproj(161,5): error MSB3073: The command "C:\Qt_static\bin\moc.exe "....\src\qt\bitcoinamountfield.cpp" -o .\QtGeneratedFiles\qt\bitcoinamountfield.moc" exited with code 3. 23>Done Building Project "F:\gitP\bitcoin\bitcoin\build_msvc\libbitcoin_qt\libbitcoin_qt.vcxproj" (Rebuild target(s)) -- FAILED. detail log build (27).log

To reproduce

1. set VSCMD_SKIP_SENDTELEMETRY=1 & "C:\Program Files (x86)\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
2. git clone https://github.com/bitcoin/bitcoin F:\bitcoin\bitcoin
3. cd F:\bitcoin\bitcoin\build_msvc
4. py -3 msvc-autogen.py
5. cd F:\bitcoin
6. mkdir tools\vcpkg
7. git clone https://github.com/microsoft/vcpkg F:\bitcoin\tools\vcpkg
8. cd F:\bitcoin\tools\vcpkg
9. bootstrap-vcpkg.bat 2>&1
10. set path=%cd%;%path%
11. vcpkg integrate install 2>&1
12. cd F:\bitcoin\bitcoin\build_msvc
13. msbuild /m /p:Platform=x64 /p:Configuration=Release bitcoin.sln /t:Rebuild 2>&1

<!--- How reliably can you reproduce the issue, what are the steps to do so? -->

System information VS version: VS2022(17.3.6) Operating system: windows server 2019 the commit of Bitcoin we use is 5174a13

<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->

<!-- Any extra information that might be useful in the debugging process. -->

<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

System information VS version: VS2022(17.3.6)

Your log mentions a different VS:

Studio\2019\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.18
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************

Do you have some VS version installed simultaneously?

You must ensure that Qt static library and the bitcoin.sln are been built with the same toolchain.

the commit of Bitcoin we use is 5174a13

What if you try the recent master branch?

Also it would be useful to see a log after building with the -verbosity:diag command-line switch.

After taking the above method, this error still exists.

@fangzhouxia

Mind posting some logs, not only errors?

Mind providing more details, in particular mentioned in #26324 (comment)?

Our CI follows https://github.com/bitcoin/bitcoin/blob/master/build_msvc/README.md, and builds Windows binaries just fine. So my guess is the problem is with your building environment. I doubt if we can help with no or little details which could at least help us to reproduce the issue.

Below are my steps to reproduce:

1. Open VS2022 x64 Native Tools command.
2. git clone https://github.com/bitcoin/bitcoin F:\bitcoin\bitcoin
3. cd F:\bitcoin\bitcoin\build_msvc
4. py -3 msvc-autogen.py
5. cd F:\bitcoin
6. mkdir tools\vcpkg
7. git clone https://github.com/microsoft/vcpkg F:\bitcoin\tools\vcpkg
8. cd F:\bitcoin\tools\vcpkg
9. bootstrap-vcpkg.bat
10. set path=%cd%;%path%
11. vcpkg integrate install
12. cd F:\bitcoin\bitcoin\build_msvc
13. msbuild /m /p:Platform=x64 /p:Configuration=Release bitcoin.sln /t:Rebuild

@fangzhouxia

You must ensure that Qt static library and the bitcoin.sln are been built with the same toolchain.

Could you try to re-build your Qt static library from scratch using VS2022?

@fangzhouxia did the above work for you? Is this still an issue?