[23.x] ci: replace Intel macOS CI job #26879

1. 
   fanquake commented at 10:53 AM on January 12, 2023: member

   Intel macOS jobs are no-longer available on Cirrus.

2. fanquake added the label Backport on Jan 12, 2023
3. 
   DrahtBot commented at 10:53 AM on January 12, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Stale ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. fanquake renamed this:
   [23.x] ci: reaplce intel macos ci job
   [23.x] ci: replace Intel macOS CI job
   on Jan 12, 2023
5. 
   fanquake commented at 11:09 AM on January 12, 2023: member

   https://github.com/bitcoin/bitcoin/pull/26879/checks?check_run_id=10602206141

   Setting up g++-multilib (4:9.3.0-1ubuntu2) ...
   Processing triggers for libc-bin (2.31-0ubuntu9.9) ...
   bash: pip3: command not found
   
   Exit status: 127
   

6. 
   maflcko commented at 12:10 PM on January 12, 2023: member

   ci: Remove unused package doesn't make sense on 23.x (it is wrong)

7. fanquake force-pushed on Jan 12, 2023
8. 
   maflcko commented at 12:46 PM on January 12, 2023: member

   Maybe the other #26234 commit needs to be dropped as well? (It shouldn't affect macos)

9. fanquake force-pushed on Jan 12, 2023
10. 
    maflcko commented at 4:20 PM on January 12, 2023: member

    Alternatively the task can be removed or ignored. (We only backport changes that pass on the master CI, so something that breaks here but not on master for one task seems unlikely)

11. 
    hebasto commented at 8:21 PM on January 12, 2023: member

    Backporting of 8e017f32889e9536a436f40c91f34f24bfd10525 should fix the native macOS task.

12. fanquake force-pushed on Jan 13, 2023
13. 
    fanquake commented at 10:00 AM on January 13, 2023: member

    Backporting of https://github.com/bitcoin/bitcoin/commit/8e017f32889e9536a436f40c91f34f24bfd10525

    Added.

    Alternatively the task can be removed or ignored.

    Yea. If this change doesn't work, happy to just remove it. The chance of some macOS only regression in this branch is basically nil, and I'd rather remove a consistently failing just than just leave it hanging around.

14. hebasto approved
15. 
    hebasto commented at 10:33 AM on January 13, 2023: member

    ~ACK c2ee70a89b332f217bfe330dd6bead916afe0814~

16. ci, refactor: Add `MACOS_NATIVE_TASK_TEMPLATE`

    A native macOS task does not aware of Linux container settings, and it
    does not use the `depends_built_cache`.
    
    Github-Pull: #25444
    Rebased-From: 8e017f32889e9536a436f40c91f34f24bfd10525

    192759eb7b
17. in src/secp256k1/build-aux/ar-lib:2 in c2ee70a89b outdated

       0 | @@ -0,0 +1,271 @@
       1 | +#! /bin/sh
       2 | +# Wrapper for Microsoft lib.exe
    

    ---

    ---

    

    maflcko commented at 11:09 AM on January 13, 2023:

    ????

    ---

    

    fanquake commented at 11:12 AM on January 13, 2023:

    Fixed overzealous use of git add ..

18. fanquake force-pushed on Jan 13, 2023
19. hebasto approved
20. 
    hebasto commented at 2:25 PM on January 13, 2023: member

    ACK 821b454abb97d74a085af70f56c39da49ed06a5f

21. fanquake requested review from maflcko on Jan 16, 2023
22. 
    maflcko commented at 10:49 AM on January 16, 2023: member

    The metadata is wrong in the last commit. Also, could backport 0bb7a1f71db1d986ab824d114534fb7671024990 for easier cherrry-picking.

23. ci: Improve naming related to "macOS 12 native x86_64" task

    Github-Pull: #25444
    Rebased-From: 0bb7a1f71db1d986ab824d114534fb7671024990

    6a5bb10da9
24. ci: Make `getopt` path architecture agnostic

    Github-Pull: #26388
    Rebased-From: 702836530ffa351e863b1b1300fd2e559a14ef23

    53fd827883
25. ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task

    Github-Pull: #26388
    Rebased-From: da168934741b776bce07d5503ca2344d300723b3

    a3db8bd7ca
26. fanquake force-pushed on Jan 16, 2023
27. maflcko merged this on Jan 16, 2023
28. maflcko closed this on Jan 16, 2023

    ---

29. fanquake deleted the branch on Jan 16, 2023
30. 
    maflcko commented at 11:13 AM on January 16, 2023: member

    lgtm. (Did the cherry-pick locally and checked that there was no overall diff in the last push)

31. jamesdorfman referenced this in commit c4f4b23890 on Sep 25, 2023
32. bitcoin locked this on Jan 16, 2024

Contributors

fanquakeDrahtBotmaflckohebasto

Review Requested
maflcko