Refactor: Remove unused FlatFilePos::SetNull #27289

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2303-no-flatfile-setnull-🚗 changing 4 files +8 −16

maflcko commented at 1:04 PM on March 21, 2023: member

This is unused outside of tests and the default constructor. With C++11, it can be replaced by C++11 member initializers in the default constructor.

Beside removing unused code, this also makes it less fragile in light of uninitialized memory. (See also #26296 (comment))

If new code needs to set this to null, it can use std::optional, or in the worst case re-introduce this method.
Refactor: Remove unused FlatFilePos::SetNull fa67b8181c
DrahtBot commented at 1:04 PM on March 21, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK dergoegge, john-moffett, TheCharlatan

Concept ACK fanquake, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Refactoring on Mar 21, 2023
fanquake commented at 1:57 PM on March 21, 2023: member

Concept ACK
dergoegge commented at 2:25 PM on March 21, 2023: member

Code review ACK fa67b8181c3ecf94395ecc50fd8acd436f1f8c3a
hebasto commented at 3:05 PM on March 21, 2023: member

Concept ACK.
john-moffett approved
john-moffett commented at 3:19 PM on March 21, 2023: contributor

ACK fa67b8181c3ecf94395ecc50fd8acd436f1f8c3a
TheCharlatan commented at 8:59 PM on March 21, 2023: contributor

ACK fa67b8181c3ecf94395ecc50fd8acd436f1f8c3a
maflcko assigned fanquake on Mar 22, 2023
fanquake merged this on Mar 22, 2023
fanquake closed this on Mar 22, 2023
maflcko deleted the branch on Mar 22, 2023
fanquake commented at 9:46 AM on March 22, 2023: member

Door open for anyone to followup with more ::SetNull() removal.
sidhujag referenced this in commit fe8442429e on Mar 23, 2023
bitcoin locked this on Mar 21, 2024