Currently the CI env has many intermittent issues:
Fix all issues by using the Cirrus CI dockerfile env.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | josibake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
No idea why CI fails. Seems to be related to https://superuser.com/questions/1642858/git-on-debian-10-backports-throws-fatal-unable-to-access-https-github-com-us
https://cirrus-ci.com/task/5391244998737920:
git is already the newest version (1:2.30.2-1~bpo10+1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
if [ "$CIRRUS_PR" = "" ]; then exit 0; fi
git fetch --depth=1 $CIRRUS_REPO_CLONE_URL "pull/${CIRRUS_PR}/merge"
fatal: unable to access 'https://github.com/bitcoin/bitcoin.git/': Failed sending HTTP2 data
This should give faster feedback about the CI result, while still
keeping expenses reasonable.
This is needed to work around
https://github.com/bitcoin/bitcoin/pull/27340#issuecomment-1484988445
The only change should be that python3.7 is bumped to 3.8, but this is
fine because ci/test/00_setup_env_native_qt5.sh still checks for
python3.7 compatibility.
46 | @@ -47,6 +47,7 @@ container_depends_template: &CONTAINER_DEPENDS_TEMPLATE 47 | cpu: 2 48 | greedy: true 49 | memory: 8G # Set to 8GB to avoid OOM. https://cirrus-ci.org/guide/linux/#linux-containers 50 | + dockerfile: ci/test_imagefile # https://cirrus-ci.org/guide/docker-builder-vm/#dockerfile-as-a-ci-environment
note to self/reviewers: this file was introduced in https://github.com/bitcoin/bitcoin/pull/26976
196 | @@ -195,6 +197,7 @@ task: 197 | image: debian:bullseye 198 | cpu: 2 199 | memory: 8G 200 | + # docker_arguments: # Can use dockerfile after https://github.com/cirruslabs/cirrus-ci-docs/issues/1154
I grep for "TODO"s a lot when looking for stuff to work on, might be nice to add a todo comment here to make it easier for others to find later on
It is not really something to work on, other than maybe subscribing to the linked issue and follow-up when it is closed?
209 | @@ -210,6 +210,7 @@ task: 210 | docker_arguments: 211 | CI_IMAGE_NAME_TAG: ubuntu:jammy 212 | FILE_ENV: "./ci/test/00_setup_env_win64.sh" 213 | + << : *CREDITS_TEMPLATE
this is unrelated to switching to the docker file, right? would prefer this change in it's own PR because I have a few questions about cost (before / after, etc), but not a super big deal
Happy to answer any questions. The cost will be displayed on every task in a badge.
code review ACK https://github.com/bitcoin/bitcoin/pull/27340/commits/fa4a46de0b3c1a5895e95dba7e95278932fbfc2c
read through the linked documentation from cirrus and this definitely makes sense. I tried to run the ci locally using cirrus run but ran into some issues (unrelated to this PR). If you have any tips on how to test this, happy to give it a go, but the code looks good otherwise.
I tried to run the ci locally using cirrus run but ran into some issues (unrelated to this PR). If you have any tips on how to test this
I can help with running the CI locally, but not how to run Cirrus locally. I don't think testing this is possible, other than looking at the CI tasks for this pull?
I can help with running the CI locally, but not how to run Cirrus locally. I don't think testing this is possible, other than looking at the CI tasks for this pull?
I installed the cirrus cli tool and ran cirrus run in the directory, which then picks up the .cirrus.yml file and executes with cirrus workers, but was running into a bunch of permissions issues. Not related to this PR, so I'm not going to try and troubleshoot it further
Going to merge this now, so that 25.x and master will have the same CI infra.