kernel: chainparams updates for 25.x #27482

1. 
   fanquake commented at 11:02 AM on April 18, 2023: member

   Update chainparams pre 25.x branch off. Co-Author in the commits as a PR (#27223) had previously been opened too-early to do the same.

   Note: Remember that some variance is expected in the m_assumed_* sizes.

2. doc: update references to kernel/chainparams.cpp 07fcc0a82c
3. kernel: update nMinimumChainWork & defaultAssumeValid for 25.x

   Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>

   00b2b114b4
4. kernel: update chainTxData for 25.x

   Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>

   4128e01dba
5. kernel: update m_assumed_* chain params for 25.x

   Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>

   a2bef805c1
6. fanquake added this to the milestone 25.0 on Apr 18, 2023
7. 
   DrahtBot commented at 11:02 AM on April 18, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, josibake, gruve-p, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

8. DrahtBot added the label Validation on Apr 18, 2023
9. in src/kernel/chainparams.cpp:227 in 00b2b114b4 outdated

    222 | @@ -223,8 +223,8 @@ class CTestNetParams : public CChainParams {
    223 |          consensus.vDeployments[Consensus::DEPLOYMENT_TAPROOT].nTimeout = 1628640000; // August 11th, 2021
    224 |          consensus.vDeployments[Consensus::DEPLOYMENT_TAPROOT].min_activation_height = 0; // No activation delay
    225 |  
    226 | -        consensus.nMinimumChainWork = uint256S("0x00000000000000000000000000000000000000000000076f6e7cbd0beade5d20");
    227 | -        consensus.defaultAssumeValid = uint256S("0x0000000000000004877fa2d36316398528de4f347df2f8a96f76613a298ce060"); // 2344474
    228 | +        consensus.nMinimumChainWork = uint256S("0x000000000000000000000000000000000000000000000977edb0244170858d07");
    229 | +        consensus.defaultAssumeValid = uint256S("0x0000000000000021bc50a89cde4870d4a81ffe0153b3c8de77b435a2fd3f6761"); // 2429000
   

   ---

   ---

   

   0xB10C commented at 1:45 PM on April 18, 2023:

   2429000 on testnet might be too recent according to the docs: "Testnet should be set with a height some tens of thousands back from the tip, due to reorgs there.". It's currently 428 blocks old. There are still frequent reorgs on testnet, with the youngest being at 2428585. However, most reorgs on testnet I've seen are one-block reorgs and wouldn't affect this.

   ---

   

   fanquake commented at 1:49 PM on April 18, 2023:

   It will also be much deeper once 25.x is actually released.

10. in src/kernel/chainparams.cpp:121 in a2bef805c1

     116 | @@ -117,8 +117,8 @@ class CMainParams : public CChainParams {
     117 |          pchMessageStart[3] = 0xd9;
     118 |          nDefaultPort = 8333;
     119 |          nPruneAfterHeight = 100000;
     120 | -        m_assumed_blockchain_size = 496;
     121 | -        m_assumed_chain_state_size = 6;
     122 | +        m_assumed_blockchain_size = 540;
     123 | +        m_assumed_chain_state_size = 7;
    

    ---

    ---

    

    0xB10C commented at 2:03 PM on April 18, 2023:

    Getting 502 GB in blocks/ and 5.1GB in chainstate/. The new values seem fine as they should include enough overhead.

11. 
    achow101 commented at 2:34 PM on April 18, 2023: member

    ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81

12. 
    josibake commented at 5:09 PM on April 18, 2023: member

    ACK https://github.com/bitcoin/bitcoin/pull/27482/commits/a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81

    verified that I got all the same values on my node for mainnet

13. 
    gruve-p commented at 7:10 AM on April 19, 2023: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/27482/commits/a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81

14. 
    dergoegge commented at 10:18 AM on April 20, 2023: member

    ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81 on the new mainnet params

15. fanquake merged this on Apr 20, 2023
16. fanquake closed this on Apr 20, 2023

    ---

17. fanquake deleted the branch on Apr 20, 2023
18. 
    darosior commented at 1:40 PM on April 21, 2023: member

    ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81 -- it's what i got on my node too.
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmRCkgIACgkQ4T/BRc0/
    QwQICwv/Y9xMr4N/IfzZo/i49/3TFw6vMi5W4/zu0qluakMU1FCcvrokJ6LbKORA
    gZsfLfdXTDdH9q9nXSkHNgQEKUXp15F81qIrv050Q7o02zMTxq9dLixJA30Fzhnz
    8g7zCR0ASCzWC0hYHDSTQgYwH0q8cEvwxhfyIEiRTgEjsAFUHn4Ap5q5oQxDWvVR
    4flCksNAJzXj7YHcpJbZWvo4Oe3mX4InvhmOF9NlYAmoRVKqmhJzM2CX8s94QvKy
    26mE0+ATLFmVTTHubkszytoQnaWHi1ocA4CayO/LJyh8a22K8PHHHd8F0YGJkkd+
    Hibmc2+4Lo9yjHf8PMCQGlyBU/ZfJmbd4pzity2mrN09m/AcWm+r0Bzt4AAai3ej
    9oIRkPqbNp6G+4nfKlJ1dEaJbR37O95UGdovvuiCC9cMbFWfCxS24xf40EvL4yvP
    GqmWB5ILYyGKZNmE+tcJo/OpKQlAaOpTpwTgtyem8B9qIQM02YKcScJA8ryb/dGn
    U/8DtahN
    =Qp6j
    -----END PGP SIGNATURE-----
    

19. bitcoin locked this on Apr 20, 2024

Contributors

fanquakeDrahtBot0xB10Cachow101josibakegruve-pdergoeggedarosior

Milestone
25.0