Updated the installation instructions for macOS #27525

asunapg commented at 12:30 PM on April 24, 2023: none

Added: Instructions on changing directories after the repo clone (cd bitcoin) (Rationale: The initial documentation assumes that the user knows to change the current directory to the cloned repository before running further commands. However, for new users or those unfamiliar with the command line, this step might not be obvious.)

Added: Instructions on verifying the build was successful and the GUI was compiled. (Rationale: After compiling the Bitcoin Core software, it's important to verify that the build was successful and that the GUI, if compiled, is functional. This step helps users confirm that the installation process is complete and that the software is ready to use.)

Updated the installation instructions for macOS

Added: Instructions on changing directories after the repo clone (cd bitcoin)
Added: Instructions on verifying the build was successful and the GUI was compiled.

0eceddd5b4

DrahtBot commented at 12:30 PM on April 24, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	RandyMcMillan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label CI failed on Apr 24, 2023

in doc/build-osx.md:63 in 0eceddd5b4

  59 | @@ -60,6 +60,11 @@ All build scripts and commands will run from this directory.
  60 |  ``` bash
  61 |  git clone https://github.com/bitcoin/bitcoin.git
  62 |  ```
  63 | +From here, change your working directory to "bitcoin" by running

Riahiamirreza commented at 1:24 PM on April 28, 2023:

nit, using colon at the end of the line may looks better

From here, change your working directory to "bitcoin" by running:

RandyMcMillan commented at 9:47 PM on April 28, 2023: contributor

ACK 0eceddd5b4b56f7ad25a42bda4a37620450c7a1a

C8B1233D-4AA6-4E7B-BCA2-6DB0C9F8F9B1 A75F866E-A552-41CD-8BF2-54B99D43E0AD

RandyMcMillan commented at 9:54 PM on April 28, 2023: contributor

Note: it is good idea to check that markdown looks good in desktop editors (macdown for example) - github flavored markdown has diverged from other flavors and sometimes there are minor issues.

fanquake commented at 3:23 PM on June 2, 2023: member

Thanks, however we are going to leave this as-is for now. Generic changes to build docs are better suited if PR'd against all platforms, not sure we need to make the other additions.

fanquake closed this on Jun 2, 2023

bitcoin locked this on Jun 1, 2024