[23.2] Backports for rc1 #27624

1. 
   fanquake commented at 10:06 AM on May 11, 2023: member

   Final backports for rc1. Currently:

   • #27608 (not a clean cherry-pick)
   • #27610 (second commit is not clean)
2. p2p: Avoid prematurely clearing download state for other peers

   Github-Pull: #27608
   Rebased-From: 52e52071e01f4e98d87a47e1d5f3c5c3cc6dbaf4

   ce8f812b0a
3. 
   DrahtBot commented at 10:06 AM on May 11, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, dergoegge, ajtowns
   Stale ACK	Sjors

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on May 11, 2023
5. 
   dergoegge commented at 2:44 PM on May 11, 2023: member

   ACK ce8f812b0ac0905c26edd826c57886a08079b4a7

   Are you going to add #27610 to this?

6. 
   Sjors commented at 3:29 PM on May 11, 2023: member

   utACK ce8f812b0ac0905c26edd826c57886a08079b4a7

7. txmempool: have CompareDepthAndScore sort missing txs first

   We use CompareDepthAndScore to choose an order of txs to inv. Rather
   than sorting txs that have been evicted from the mempool at the end
   of the list, sort them at the beginning so they are removed from
   the queue immediately.
   
   Github-Pull: #27610
   Rebased-From: 228e9201efb5574b1b96bb924de1d2e8dd1317f3

   d0a2c87214
8. net_processing: Boost inv trickle rate

   If transactions are being added to the mempool at a rate faster than 7tx/s
   (INVENTORY_BROADCAST_PER_SECOND) then peers' inventory_to_send queue can
   become relatively large. If this happens, increase the number of txids
   we include in an INV message (normally capped at 35) by 5 for each 1000
   txids in the queue.
   
   This will tend to clear a temporary excess out reasonably quickly; an
   excess of 4000 invs to send will be cleared down to 1000 in about 30
   minutes, while an excess of 20000 invs would be cleared down to 1000 in
   about 60 minutes.
   
   Github-Pull: #27610
   Rebased-From: 5b3406094f2679dfb3763de4414257268565b943

   06731d19bc
9. build: bump version to v23.2rc1 67bbe6d371
10. doc: update version in bips.md to v23.2 b93814b234
11. doc: update manual pages for v23.2rc1 60edfd57f1
12. doc: add initial release notes for v23.2

    Move historical 23.1 to doc/release-notes.

    a26ff204f0
13. 
    fanquake commented at 4:46 PM on May 11, 2023: member

    Added #27610, as well as all other changes required to cut an rc1.

    Are you going to add #27610 to this?

    Yes. Note that the second commit from that PR is not a clean cherry-pick.

14. 
    achow101 commented at 5:27 PM on May 11, 2023: member

    ACK a26ff204f0f0355749a1b61136437623b325f8fb

    Diffs match as expected

15. DrahtBot requested review from dergoegge on May 11, 2023
16. DrahtBot requested review from Sjors on May 11, 2023
17. 
    dergoegge commented at 6:18 PM on May 11, 2023: member

    ACK a26ff204f0f0355749a1b61136437623b325f8fb

18. DrahtBot removed review request from dergoegge on May 11, 2023
19. 
    ajtowns commented at 7:09 AM on May 12, 2023: contributor

    utACK a26ff204f0f0355749a1b61136437623b325f8fb

20. 
    Sjors commented at 8:15 AM on May 12, 2023: member

    I didn't check the #27608 backport (nor the original). I did check #27608, the other commits in this PR and the release notes, which look good to me.

21. fanquake merged this on May 12, 2023
22. fanquake closed this on May 12, 2023

    ---

23. fanquake deleted the branch on May 12, 2023
24. jamesdorfman referenced this in commit 730d9fdca0 on Sep 25, 2023
25. bitcoin locked this on May 11, 2024

Contributors

fanquakeDrahtBotdergoeggeSjorsachow101ajtowns

Review Requested
Sjors