ci: Bump macOS cross task to ubuntu:jammy #27883

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2306-ci-mac- changing 2 files +3 −3

maflcko commented at 8:51 AM on June 14, 2023: member

It shouldn't matter what underlying image is used for the task, because the compiler is fully provided by ./depends/.

So just use the latest Ubuntu LTS, which is also most likely the OS that is used by people cross-compiling, if there are any at all.
ci: Bump macOS cross task to ubuntu:jammy fa70e85e00
DrahtBot commented at 8:51 AM on June 14, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK fanquake, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jun 14, 2023
hebasto commented at 8:56 AM on June 14, 2023: member

Concept ACK. I can't see any compelling reasons for "Check that Focal can cross-compile to macos".
maflcko commented at 8:59 AM on June 14, 2023: member

Concept ACK. I see no compelling reasons for "Check that Focal can cross-compile to macos".

It may have been a leftover from Gitian, before it was removed? See 5baff2b31840bdbc465f55b875aa6e9480288215
DrahtBot added the label CI failed on Jun 14, 2023
fanquake approved
fanquake commented at 1:29 PM on June 14, 2023: member

ACK fa70e85e00f5ff7df7d74f461cdb0d47e89ed096
in ci/test/00_setup_env_mac.sh:10 in fa70e85e00
```
   6 | @@ -7,7 +7,7 @@
   7 |  export LC_ALL=C.UTF-8
   8 |  
   9 |  export CONTAINER_NAME=ci_macos_cross
  10 | -export CI_IMAGE_NAME_TAG=ubuntu:20.04  # Check that Focal can cross-compile to macos
  11 | +export CI_IMAGE_NAME_TAG=ubuntu:22.04
```
hebasto commented at 1:31 PM on June 14, 2023:

Why not using the same CI_IMAGE_NAME_TAG value in both instances?

maflcko commented at 1:36 PM on June 14, 2023:

May do if I need to retouch to avoid invalidating review over a style nit
hebasto approved
hebasto commented at 1:47 PM on June 14, 2023: member

ACK fa70e85e00f5ff7df7d74f461cdb0d47e89ed096
fanquake merged this on Jun 14, 2023
fanquake closed this on Jun 14, 2023
maflcko deleted the branch on Jun 14, 2023
sidhujag referenced this in commit 6ffe5160ee on Jun 15, 2023
bitcoin locked this on Jun 13, 2024

Type	Reviewers
ACK	fanquake, hebasto

Contributors

Labels

ci: Bump macOS cross task to ubuntu:jammy #27883

Reviews