Starting with a clean env should help to avoid non-determinism, such as the one fixed in #27739 (comment)
ci: Start with clean env #27976
pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2306-ci-env- changing 5 files +11 −12-
maflcko commented at 1:59 PM on June 26, 2023: member
-
DrahtBot commented at 1:59 PM on June 26, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28116 (test: update tool_wallet coverage for unexpected writes to wallet by jonatack)
- #27793 (ci: label docker images and prune dangling images selectively by stickies-v)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot renamed this:
ci: Start with clean env
ci: Start with clean env
on Jun 26, 2023 - DrahtBot added the label Tests on Jun 26, 2023
- maflcko force-pushed on Jun 26, 2023
-
fanquake commented at 2:00 PM on June 28, 2023: member
Concept ACK
- maflcko force-pushed on Jul 11, 2023
- maflcko force-pushed on Jul 11, 2023
- maflcko force-pushed on Jul 12, 2023
-
jonatack commented at 1:16 PM on July 21, 2023: member
Approach ACK
- maflcko marked this as a draft on Jul 24, 2023
-
- DrahtBot added the label Needs rebase on Jul 28, 2023
- maflcko force-pushed on Jul 28, 2023
- DrahtBot removed the label Needs rebase on Jul 28, 2023
- DrahtBot added the label Needs rebase on Aug 3, 2023
- maflcko force-pushed on Aug 4, 2023
- DrahtBot removed the label Needs rebase on Aug 4, 2023
- maflcko force-pushed on Aug 7, 2023
- maflcko force-pushed on Aug 9, 2023
- maflcko force-pushed on Aug 15, 2023
- DrahtBot added the label CI failed on Aug 15, 2023
-
fa8c250c2f
ci: Limit scope of some env vars
No need to have a larger scope than needed. Can be reviewed with --color-moved=dimmed-zebra
-
fa378bed56
ci: Start with clean env
This should help to avoid non-determinism.
-
fa15f7e082
ci: Remove no longer applicable section
This fails with: "Error: determining starting point for build: no FROM statement found"
- maflcko force-pushed on Aug 23, 2023
-
dergoegge commented at 2:05 PM on August 23, 2023: member
Is this pull just a doc change? This doesn't look like it actually changes anything to start with a clean env.
- maflcko marked this as ready for review on Aug 23, 2023
-
maflcko commented at 2:14 PM on August 23, 2023: member
Is this pull just a doc change? This doesn't look like it actually changes anything to start with a clean env.
Yes, it changes the doc to recommend
env -i. On my system:$ env --help | grep 'empty env' -i, --ignore-environment start with an empty environment -
maflcko commented at 2:17 PM on August 23, 2023: member
Oh, was your question "Why didn't you modify ./ci/test_run_all.sh to clear the env?" If yes, the answer would be, to still allow the user to set any or all env vars that can be modified. For example,
MAKEJOBS. - dergoegge approved
-
dergoegge commented at 2:17 PM on August 23, 2023: member
utACK fa15f7e082396089f0945b53b60cf3ce952e9794
- DrahtBot removed the label CI failed on Aug 23, 2023
- fanquake merged this on Aug 24, 2023
- fanquake closed this on Aug 24, 2023
- maflcko deleted the branch on Aug 24, 2023
- Frank-GER referenced this in commit 0ad7e12592 on Sep 8, 2023
- bitcoin locked this on Aug 23, 2024
Labels