docs: fixup honggfuzz fuzz patch #28021

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:honggfuzz_patch changing 1 files +22 −21

fanquake commented at 9:00 AM on July 3, 2023: member

Closes #28019.
DrahtBot commented at 9:00 AM on July 3, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Jul 3, 2023
docs: fixup honggfuzz patch
Closes #28019.
c1247c3746

Type	Reviewers
ACK	brunoerg

in doc/fuzzing.md:257 in 1a0958eeba outdated

 274 |  -    if (memcmp(hash.begin(), hdr.pchChecksum, CMessageHeader::CHECKSUM_SIZE) != 0) {
 275 | -+    if (false && memcmp(hash.begin(), hdr.pchChecksum, CMessageHeader::CHECKSUM_SIZE) != 0) { // skip checksum checking
 276 | -         LogPrint(BCLog::NET, "CHECKSUM ERROR (%s, %u bytes), expected %s was %s, peer=%d\n",
 277 | -                  SanitizeString(msg->m_command), msg->m_message_size,
 278 | -                  HexStr(Span<uint8_t>(hash.begin(), hash.begin() + CMessageHeader::CHECKSUM_SIZE)),
 279 | ++    if (false && memcmp(hash.begin(), hdr.pchChecksum, CMessageHeader::CHECKSUM_SIZE) != 0) { // skip network magic checking

maflcko commented at 9:57 AM on July 3, 2023:

Any reason to make the comment wrong?

fanquake commented at 10:01 AM on July 3, 2023:

Just a miss-copy and paste

fanquake force-pushed on Jul 3, 2023
DrahtBot added the label CI failed on Jul 3, 2023
maflcko approved
maflcko commented at 10:07 AM on July 3, 2023: member

lgtm
maflcko requested review from brunoerg on Jul 3, 2023
brunoerg approved
brunoerg commented at 10:36 AM on July 3, 2023: contributor

ACK c1247c3746d4b9ea88a0f9cfb7e71904267b3cd3
fanquake merged this on Jul 3, 2023
fanquake closed this on Jul 3, 2023
fanquake deleted the branch on Jul 3, 2023
sidhujag referenced this in commit 2fc077f8c4 on Jul 4, 2023
bitcoin locked this on Jul 2, 2024

Contributors

Labels

Linked (view graph)

#28019 docs: "Fuzzing the Bitcoin Core P2P layer using Honggfuzz NetDriver" is outdated

docs: fixup honggfuzz fuzz patch #28021

Reviews