validation: use noexcept instead of deprecated throw() #28090

1. 
   fanquake commented at 1:58 pm on July 17, 2023: member

   We fixed this once before in #10965. Turn on https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-noexcept.html#modernize-use-noexcept.
2. validation: use noexcept instead of deprecated throw()

   ```bash
     CXX      libbitcoin_node_a-validation.o
   validation.cpp:5164:30: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
       const char* what() const throw() override
                                ^~~~~~~
   validation.cpp:5164:30: note: use 'noexcept' instead
       const char* what() const throw() override
                                ^~~~~~~
                                noexcept
   ```

   85e9e1f802
3. clang-tidy: turn on modernize-use-noexcept 047daad4f5
4. 
   DrahtBot commented at 1:58 pm on July 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, stickies-v, sipa, Empact

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label Validation on Jul 17, 2023
6. 
   maflcko commented at 2:22 pm on July 17, 2023: member

   lgtm ACK 047daad4f59942488163c6be8516a69291646294
7. stickies-v approved
8. 
   stickies-v commented at 5:55 pm on July 17, 2023: contributor

   ACK 047daad4f59942488163c6be8516a69291646294
9. 
   sipa commented at 6:07 pm on July 17, 2023: member

   utACK 047daad4f59942488163c6be8516a69291646294
10. 
    Empact commented at 9:02 pm on July 17, 2023: member

    utACK https://github.com/bitcoin/bitcoin/commit/047daad4f59942488163c6be8516a69291646294
11. fanquake merged this on Jul 18, 2023
12. fanquake closed this on Jul 18, 2023

    ---

13. fanquake deleted the branch on Jul 18, 2023
14. 
    hebasto commented at 10:26 am on July 19, 2023: member

    Post-merge ACK 047daad4f59942488163c6be8516a69291646294.
15. 
    jonatack commented at 12:08 pm on July 19, 2023: contributor

    Post-merge ack
16. sidhujag referenced this in commit 14e01f291d on Jul 19, 2023
17. bitcoin locked this on Jul 18, 2024

Contributors
fanquake DrahtBot maflcko stickies-v sipa Empact hebasto jonatack

Labels
Validation