validation: use noexcept instead of deprecated throw() #28090

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:throw_to_noexcept changing 2 files +2 −1

fanquake commented at 1:58 PM on July 17, 2023: member

We fixed this once before in #10965. Turn on https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-noexcept.html#modernize-use-noexcept.

validation: use noexcept instead of deprecated throw()

```bash
  CXX      libbitcoin_node_a-validation.o
validation.cpp:5164:30: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
    const char* what() const throw() override
                             ^~~~~~~
validation.cpp:5164:30: note: use 'noexcept' instead
    const char* what() const throw() override
                             ^~~~~~~
                             noexcept
```

85e9e1f802

clang-tidy: turn on modernize-use-noexcept 047daad4f5
DrahtBot commented at 1:58 PM on July 17, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke, stickies-v, sipa, Empact

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Validation on Jul 17, 2023
maflcko commented at 2:22 PM on July 17, 2023: member

lgtm ACK 047daad4f59942488163c6be8516a69291646294
stickies-v approved
stickies-v commented at 5:55 PM on July 17, 2023: contributor

ACK 047daad4f59942488163c6be8516a69291646294
sipa commented at 6:07 PM on July 17, 2023: member

utACK 047daad4f59942488163c6be8516a69291646294
Empact commented at 9:02 PM on July 17, 2023: member

utACK https://github.com/bitcoin/bitcoin/commit/047daad4f59942488163c6be8516a69291646294
fanquake merged this on Jul 18, 2023
fanquake closed this on Jul 18, 2023
fanquake deleted the branch on Jul 18, 2023
hebasto commented at 10:26 AM on July 19, 2023: member

Post-merge ACK 047daad4f59942488163c6be8516a69291646294.
jonatack commented at 12:08 PM on July 19, 2023: contributor

Post-merge ack
sidhujag referenced this in commit 14e01f291d on Jul 19, 2023
bitcoin locked this on Jul 18, 2024