refactor: Remove unused MessageStartChars parameters from BlockManager methods #28191

1. 
   maflcko commented at 12:34 PM on July 31, 2023: member

   Seems odd to expose these for mocking, when it is not needed.

   Fix this by removing the the unused parameters and use the already existing member field instead.

2. Remove unused MessageStartChars parameters from BlockManager methods fa69e3a95c
3. 
   DrahtBot commented at 12:34 PM on July 31, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, Empact

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #26326 (net: don't lock cs_main while reading blocks in net processing by andrewtoth)
   • #26288 (Enable -Wstring-concatenation and -Wstring-conversion on clang builds by Empact)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Refactoring on Jul 31, 2023
5. maflcko requested review from TheCharlatan on Aug 1, 2023
6. dergoegge approved
7. 
   dergoegge commented at 12:30 PM on August 1, 2023: member

   utACK fa69e3a95c452c2ba3221b17c19fba5993b5d073

8. 
   Empact commented at 6:34 AM on August 7, 2023: member

   utACK fa69e3a95c452c2ba3221b17c19fba5993b5d073

9. fanquake merged this on Aug 7, 2023
10. fanquake closed this on Aug 7, 2023

    ---

11. maflcko deleted the branch on Aug 7, 2023
12. sidhujag referenced this in commit d350dc9be2 on Aug 9, 2023
13. bitcoin locked this on Aug 6, 2024

Review Requested
TheCharlatan