ci: Use concurrency for pull requests only #28322

1. 
   hebasto commented at 10:19 AM on August 22, 2023: member

   This PR is an amendment for #28282.

   It avoids skipping builds when some pushes were done consequentially:

   

   From GitHub Actions docs:

   When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. Any previously pending ... workflow in the concurrency group will be canceled.

   No behavior change for pull requests:

   

2. 
   DrahtBot commented at 10:19 AM on August 22, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Aug 22, 2023
4. hebasto force-pushed on Aug 22, 2023
5. hebasto marked this as a draft on Aug 22, 2023
6. hebasto marked this as ready for review on Aug 22, 2023
7. ci: Use concurrency for pull requests only

   Otherwise, any previously pending workflow will be canceled on the
   following push.

   e7d67efd13
8. hebasto force-pushed on Aug 22, 2023
9. hebasto requested review from maflcko on Aug 22, 2023
10. in .github/workflows/ci.yml:17 in e7d67efd13

      13 | @@ -14,8 +14,8 @@ on:
      14 |        - '**'
      15 |  
      16 |  concurrency:
      17 | -  group: ${{ github.ref }}
      18 | -  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
      19 | +  group: ${{ github.event_name != 'pull_request' && github.run_id || github.ref }}
    

    ---

    ---

    

    maflcko commented at 11:56 AM on August 22, 2023:

      group: ${{ github.event_name != 'pull_request' && github.sha || github.ref }}
    

    Could cancel on re-runs as well?

    ---

    

    hebasto commented at 12:59 PM on August 22, 2023:

    Could cancel on re-runs as well?

    "Re-run" buttons are only accessible once the entire workflow has completed. Therefore, there is nothing to cancel, right?

    ---

    

    maflcko commented at 1:14 PM on August 22, 2023:

    Ok, fair enough.

11. 
    maflcko commented at 11:56 AM on August 22, 2023: member

    review only ACK e7d67efd13f83ba9a6f6e62cb6d12ce37716a404

12. hebasto requested review from fanquake on Aug 22, 2023
13. real-or-random referenced this in commit 26a989924b on Aug 23, 2023
14. dergoegge approved
15. 
    dergoegge commented at 2:14 PM on August 23, 2023: member

    lgtm ACK e7d67efd13f83ba9a6f6e62cb6d12ce37716a404

16. 
    hebasto commented at 9:07 AM on August 24, 2023: member

    @fanquake

    Anything else I need to do here?

17. fanquake merged this on Aug 24, 2023
18. fanquake closed this on Aug 24, 2023

    ---

19. hebasto deleted the branch on Aug 24, 2023
20. 
    hebasto commented at 9:48 AM on August 24, 2023: member

    It works as expected. No job skipped:

    

21. Frank-GER referenced this in commit b97bc9da56 on Sep 8, 2023
22. bitcoin locked this on Aug 23, 2024

Contributors

hebastoDrahtBotmaflckodergoegge

Review Requested
fanquake