message.{h,cpp} from libbitcoin_util to libbitcoin_common
#28549
This PR breaks the libbitcoin_util library’s dependency on the libbitcoin_consensus library due to the CPubKey::RecoverCompact symbol, which is not in alignment with our library design goals.
The libbitcoin_util library, unlike libbitcoin_common, is a dependency of the kernel library, so we are trying to move unnecessary things out of it, to make the kernel library smaller.
For more details please refer to #28548.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | BrandonOdiwuor |
| Stale ACK | ryanofsky |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
This change breaks the `libbitcoin_util` library's dependency on the
`libbitcoin_consensus` library due to the `CPubKey::RecoverCompact`
symbol, which is not in alignment with our library design goals.
Updated 31eaa9db17b253683a0a457a85ae5240d3587cc2 -> e39d82720641317d7f24d6564c1286641e81b1e2 (pr28549.01 -> pr28549.02, diff):
f you wanted to update PR description to describe rationale a little more, you could say libbitcoin_util library, unlike libbitcoin_common, is a dependency of the kernel library, so we are trying to move unnecessary things out of it, to make the kernel library smaller
Thank you! Done.
message.{h, cpp} from libbitcoin_util to libbitcoin_common breaking its dependency on the libbitcoin_consensus library
