[25.1] Final changes for 25.1rc1 #28559

1. 
   fanquake commented at 4:00 pm on October 2, 2023: member

   Final changes to tag a 25.1rc1. Bumps version numbers, man pages, adds release notes etc.
2. fanquake added this to the milestone 25.1 on Oct 2, 2023
3. 
   DrahtBot commented at 4:00 pm on October 2, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, hebasto, willcl-ark, stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on Oct 2, 2023
5. DrahtBot added the label CI failed on Oct 2, 2023
6. fanquake force-pushed on Oct 3, 2023
7. fanquake force-pushed on Oct 4, 2023
8. doc: add 25.0 release notes dc1fcec026
9. build: Bump version to 25.1rc1 02f059c819
10. doc: update manual pages for 25.1rc1 71aed7aa31
11. doc: add release notes for 25.1rc1 10f3f813b2
12. fanquake force-pushed on Oct 4, 2023
13. fanquake marked this as ready for review on Oct 4, 2023
14. 
    fanquake commented at 10:25 am on October 4, 2023: member

    Rebased for the final backports. This is now ready for review.
15. dergoegge approved
16. 
    dergoegge commented at 10:27 am on October 4, 2023: member

    ACK 10f3f813b251d16c86d0b41bbdd7b7ab4a22e00d
17. in doc/release-notes.md:104 in 10f3f813b2

    354-- sinetek
    355-- Sjors Provoost
    356-- Skuli Dulfari
    357-- SomberNight
    358-- Stacie Waleyko
    359 - stickies-v
    

    ---

    ---

    

    hebasto commented at 10:35 am on October 4, 2023:

    nit: Mention by name, as all others contributors?

    ---

    

    fanquake commented at 10:40 am on October 4, 2023:

    Copied from the previous release notes.

    ---

    

    fanquake commented at 10:40 am on October 4, 2023:

    There are also other usernames in here.

    ---

    

    hebasto commented at 10:42 am on October 4, 2023:

    There are also other usernames in here.

    

    ---

    

    fanquake commented at 10:43 am on October 4, 2023:

    MacroFake

18. hebasto approved
19. 
    hebasto commented at 10:35 am on October 4, 2023: member

    ACK 10f3f813b251d16c86d0b41bbdd7b7ab4a22e00d, I have reviewed the code and it looks OK.
20. willcl-ark approved
21. 
    willcl-ark commented at 10:51 am on October 4, 2023: member

    ACK 10f3f813b251d16c86d0b41bbdd7b7ab4a22e00d

    Mechanical changes all look correct. Release note reads well.

22. stickies-v approved
23. 
    stickies-v commented at 11:07 am on October 4, 2023: contributor

    ACK 10f3f813b251d16c86d0b41bbdd7b7ab4a22e00d

    I verified the release notes correspond with the the commits since 8105bce5b384c72cf08b25b7c5343622754e7337 , and the manpages and bitcoin.conf correspond with my output.

    0% diff doc/release-notes.md doc/release-notes/release-notes-25.0.md
    146c46
    2< - Transactions of non-witness size 65 and above are now allowed by mempool
    3---
    4> - Transactions of non-witness size 65 bytes and above are now allowed by mempool
    563c63
    6<   parameter](JSON-RPC-interface.md#parameter-passing) called `args` that can
    7---
    8>   parameter](https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#parameter-passing) called `args` that can
    

24. 
    fanquake commented at 12:09 pm on October 4, 2023: member

    Two minor fixups in

    Going to leave as-is for now, as the change is move-only. Can fixup pre-release if we want.

25. fanquake merged this on Oct 4, 2023
26. fanquake closed this on Oct 4, 2023

    ---

27. fanquake deleted the branch on Oct 4, 2023
28. 
    fanquake commented at 12:17 pm on October 4, 2023: member

    Going to leave as-is for now, as the change is move-only. Can fixup pre-release if we want.

    I misinterpreted this as we need to fix somethingup, but it was actually just pointing out the diff. Nothing to followup on.

29. bitcoin locked this on Oct 3, 2024

Contributors
fanquake DrahtBot dergoegge hebasto willcl-ark stickies-v

Labels
Backport CI failed

Milestone
25.1