First new point release of zeromq in two and a half years. Mostly bug fixes; the project also completed a relicense to the "Mozilla Public License".
depends: zeromq 4.3.5 #28627
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:zeromq_4_3_5 changing 2 files +4 −62-
fanquake commented at 9:19 AM on October 10, 2023: member
- fanquake added this to the milestone 27.0 on Oct 10, 2023
-
DrahtBot commented at 9:19 AM on October 10, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Build system on Oct 10, 2023
-
hebasto commented at 9:24 AM on October 10, 2023: member
Concept ACK.
- maflcko added the label DrahtBot Guix build requested on Oct 19, 2023
-
DrahtBot commented at 5:40 PM on October 19, 2023: contributor
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds (on x86_64)
- DrahtBot removed the label DrahtBot Guix build requested on Oct 19, 2023
-
986d7fed05
depends: zeromq 4.3.5
https://github.com/zeromq/libzmq/releases/tag/v4.3.5
- fanquake force-pushed on Oct 24, 2023
- fanquake marked this as ready for review on Oct 24, 2023
- hebasto approved
-
hebasto commented at 1:18 PM on October 24, 2023: member
ACK 986d7fed057b995a720787cbbd21e1c41763fb83, I have reviewed the code and it looks OK.
- DrahtBot added the label CI failed on Oct 24, 2023
-
hebasto commented at 2:51 PM on October 24, 2023: member
My Guix builds:
x86_64 59b037743bf99c3e8bf4932ed61c595847daf3c88167b12e02b62ec0d28459b9 guix-build-986d7fed057b/output/aarch64-linux-gnu/SHA256SUMS.part b7baef8a064db9da3743e671c8075826c3949c275a83f69d22e659d1e4d47326 guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu-debug.tar.gz 40c565876bdc15639b69c6bbb61ae7f7be00b3643f232ceea7023d1126ab15fe guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu.tar.gz fd63ef307a72332f279ea6b2c6f43826e6d2af7bef3b8db0eb55e20d2cbfcad7 guix-build-986d7fed057b/output/arm-linux-gnueabihf/SHA256SUMS.part b58ff1c7adeb5a566b5aeeef005f225c8882d85f27a8195e5d5a8365b37d3cac guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf-debug.tar.gz 2a431f280bd18e3fc873e70b3b8cd07e27089d2efac8a8083ef3604b64b453a7 guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf.tar.gz ff7eebe52cf818a9bd97cc07d7f931e37daa5a3091c0b990b10ac1f767f5926e guix-build-986d7fed057b/output/arm64-apple-darwin/SHA256SUMS.part 3119e3a0b031d6a45311c1532220bacd212716186c7bad263eb8b0076c215899 guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.tar.gz f313f2db12eaa6d5284446f0c2f3af6c529c76574d743d4c033a326baa2095d9 guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.zip 79badcb4070b2b950eed2fac47e9745d52e9181d5dc4ae82e83ba567e787505d guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin.tar.gz 6410960d0ddc494a95881672e1721140213d3290b2764dec35ceb419f629c2a6 guix-build-986d7fed057b/output/dist-archive/bitcoin-986d7fed057b.tar.gz 3aabb100d5a49af2fc00fbead3e4ff1166c008c2023eaa32257544c355f8bb99 guix-build-986d7fed057b/output/powerpc64-linux-gnu/SHA256SUMS.part b45d94a09d5231a68f1300f6043b6ea3effc33fe0a177beb8f72eba73dd50191 guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu-debug.tar.gz 8369f5eaaf639c874a500099f7b29a8ad5c7ca1b6ea2fa3a3d946e4464d943ec guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu.tar.gz bd98c22bcb077c64802ac6a4fea8c125de3ad51fa059c6cc615961743764c4de guix-build-986d7fed057b/output/powerpc64le-linux-gnu/SHA256SUMS.part c4aa32f17d16b5ff11116887dc047fc198942be84431743b667d5e977b975e4c guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu-debug.tar.gz 6b30377ef2d1996131595134e7b0a2894ca60e17e4e254bec2df8fb3738ac833 guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu.tar.gz 478fda56708f839699493a04b70833a59470d388d8227c2627a0c7ef52aee12a guix-build-986d7fed057b/output/riscv64-linux-gnu/SHA256SUMS.part b6fe8284ca15f9a14ce5326b30d1542a007c41ea0e4b0a7b1a81bb63f7002e89 guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu-debug.tar.gz a11db5ba19c21ac662279595478f7ffe85eb9867d2c56b046c4717e434816d8e guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu.tar.gz 698abf77725448f82310d0efd661422f39550d377edc565d6042d00a37bf798b guix-build-986d7fed057b/output/x86_64-apple-darwin/SHA256SUMS.part 27cef1ea92865247cd0692c42228237903f58f14afc29abf0009ceb27e82e158 guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.tar.gz 0ddad23cc0562d8346463f8cb6a37faf8bde2b7a8570c2a41e07748e59deb13f guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.zip 7bcd078a7eb15e439e931512421622d37cbec4395ba742f04f2594fd23624291 guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin.tar.gz 5ac508736ecaba1e7ccbc70b2728f798d9f31e30f860af7b39dd6ac18c4de2d6 guix-build-986d7fed057b/output/x86_64-linux-gnu/SHA256SUMS.part 25e7dd48f5b3a00d3318084d572737ec380168889dc455a9f6cdd6b5b39ccfbe guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu-debug.tar.gz ffb68a445586283bc874d77828cabedf0251565e8c9434ade7b62d7f5f52a4c6 guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu.tar.gz b7028a690cd2f3534b6506e7c12742a80ab2ea371d2ec329ad82f2eedb457747 guix-build-986d7fed057b/output/x86_64-w64-mingw32/SHA256SUMS.part aaf07cddfe55e8988b4854463f8dfb3d16e00502ab501f6e8f2a67091b630284 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-debug.zip 82ac6875462f819ff54e77a209062ca51ac4b07d85b518665b6f405864840519 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-setup-unsigned.exe cde6c04506dda70a1f0cdef3a50186ecf82a7d0551f8c266f795f8883ae82307 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-unsigned.tar.gz 8a904f11110f66d741b3dae1cb6412b7fadc4f29b2d477453540dbd1729001a9 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64.zip - fanquake requested review from TheCharlatan on Oct 24, 2023
-
TheCharlatan commented at 8:51 PM on October 24, 2023: contributor
Guix builds:
aarch64 and x86_64 59b037743bf99c3e8bf4932ed61c595847daf3c88167b12e02b62ec0d28459b9 guix-build-986d7fed057b/output/aarch64-linux-gnu/SHA256SUMS.part b7baef8a064db9da3743e671c8075826c3949c275a83f69d22e659d1e4d47326 guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu-debug.tar.gz 40c565876bdc15639b69c6bbb61ae7f7be00b3643f232ceea7023d1126ab15fe guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu.tar.gz fd63ef307a72332f279ea6b2c6f43826e6d2af7bef3b8db0eb55e20d2cbfcad7 guix-build-986d7fed057b/output/arm-linux-gnueabihf/SHA256SUMS.part b58ff1c7adeb5a566b5aeeef005f225c8882d85f27a8195e5d5a8365b37d3cac guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf-debug.tar.gz 2a431f280bd18e3fc873e70b3b8cd07e27089d2efac8a8083ef3604b64b453a7 guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf.tar.gz ff7eebe52cf818a9bd97cc07d7f931e37daa5a3091c0b990b10ac1f767f5926e guix-build-986d7fed057b/output/arm64-apple-darwin/SHA256SUMS.part 3119e3a0b031d6a45311c1532220bacd212716186c7bad263eb8b0076c215899 guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.tar.gz f313f2db12eaa6d5284446f0c2f3af6c529c76574d743d4c033a326baa2095d9 guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.zip 79badcb4070b2b950eed2fac47e9745d52e9181d5dc4ae82e83ba567e787505d guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin.tar.gz 6410960d0ddc494a95881672e1721140213d3290b2764dec35ceb419f629c2a6 guix-build-986d7fed057b/output/dist-archive/bitcoin-986d7fed057b.tar.gz 3aabb100d5a49af2fc00fbead3e4ff1166c008c2023eaa32257544c355f8bb99 guix-build-986d7fed057b/output/powerpc64-linux-gnu/SHA256SUMS.part b45d94a09d5231a68f1300f6043b6ea3effc33fe0a177beb8f72eba73dd50191 guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu-debug.tar.gz 8369f5eaaf639c874a500099f7b29a8ad5c7ca1b6ea2fa3a3d946e4464d943ec guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu.tar.gz bd98c22bcb077c64802ac6a4fea8c125de3ad51fa059c6cc615961743764c4de guix-build-986d7fed057b/output/powerpc64le-linux-gnu/SHA256SUMS.part c4aa32f17d16b5ff11116887dc047fc198942be84431743b667d5e977b975e4c guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu-debug.tar.gz 6b30377ef2d1996131595134e7b0a2894ca60e17e4e254bec2df8fb3738ac833 guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu.tar.gz 478fda56708f839699493a04b70833a59470d388d8227c2627a0c7ef52aee12a guix-build-986d7fed057b/output/riscv64-linux-gnu/SHA256SUMS.part b6fe8284ca15f9a14ce5326b30d1542a007c41ea0e4b0a7b1a81bb63f7002e89 guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu-debug.tar.gz a11db5ba19c21ac662279595478f7ffe85eb9867d2c56b046c4717e434816d8e guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu.tar.gz 698abf77725448f82310d0efd661422f39550d377edc565d6042d00a37bf798b guix-build-986d7fed057b/output/x86_64-apple-darwin/SHA256SUMS.part 27cef1ea92865247cd0692c42228237903f58f14afc29abf0009ceb27e82e158 guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.tar.gz 0ddad23cc0562d8346463f8cb6a37faf8bde2b7a8570c2a41e07748e59deb13f guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.zip 7bcd078a7eb15e439e931512421622d37cbec4395ba742f04f2594fd23624291 guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin.tar.gz 5ac508736ecaba1e7ccbc70b2728f798d9f31e30f860af7b39dd6ac18c4de2d6 guix-build-986d7fed057b/output/x86_64-linux-gnu/SHA256SUMS.part 25e7dd48f5b3a00d3318084d572737ec380168889dc455a9f6cdd6b5b39ccfbe guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu-debug.tar.gz ffb68a445586283bc874d77828cabedf0251565e8c9434ade7b62d7f5f52a4c6 guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu.tar.gz b7028a690cd2f3534b6506e7c12742a80ab2ea371d2ec329ad82f2eedb457747 guix-build-986d7fed057b/output/x86_64-w64-mingw32/SHA256SUMS.part aaf07cddfe55e8988b4854463f8dfb3d16e00502ab501f6e8f2a67091b630284 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-debug.zip 82ac6875462f819ff54e77a209062ca51ac4b07d85b518665b6f405864840519 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-setup-unsigned.exe cde6c04506dda70a1f0cdef3a50186ecf82a7d0551f8c266f795f8883ae82307 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-unsigned.tar.gz 8a904f11110f66d741b3dae1cb6412b7fadc4f29b2d477453540dbd1729001a9 guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64.zip - TheCharlatan approved
-
TheCharlatan commented at 8:55 PM on October 24, 2023: contributor
ACK 986d7fed057b995a720787cbbd21e1c41763fb83
Independently verified the sha256sum. Also checked that the now removed patch is indeed in the upstream.
- fanquake merged this on Oct 24, 2023
- fanquake closed this on Oct 24, 2023
- fanquake deleted the branch on Oct 24, 2023
- PastaPastaPasta referenced this in commit 4b704a60ad on Sep 27, 2024
- PastaPastaPasta referenced this in commit 3b9f9352a1 on Sep 27, 2024
- PastaPastaPasta referenced this in commit 470b7ac2fa on Sep 27, 2024
- bitcoin locked this on Oct 23, 2024
