build: Include `config/bitcoin-config.h` explicitly in `util/trace.h` #28693

1. 
   hebasto commented at 1:17 PM on October 20, 2023: member

   The ENABLE_TRACING macro is expected to be defined in the config/bitcoin-config.h header.

   Therefore, the current code is error-prone as it depends on whether the config/bitcoin-config.h header was included before or not.

   This bug was noticed while working on CMake stuff.

2. 
   DrahtBot commented at 1:17 PM on October 20, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. maflcko added this to the milestone 26.0 on Oct 20, 2023
4. 
   maflcko commented at 1:39 PM on October 20, 2023: member

   Missing build: prefix in title?

5. build: Include `config/bitcoin-config.h` explicitly in `util/trace.h`

   The `ENABLE_TRACING` macro is expected to be defined in the
   `config/bitcoin-config.h` header.
   
   Therefore, the current code is error-prone as it depends on whether the
   `config/bitcoin-config.h` header was included before or not.

   6bdff429ec
6. hebasto force-pushed on Oct 20, 2023
7. hebasto renamed this:
   Include `config/bitcoin-config.h` explicitly in `util/trace.h`
   build: Include `config/bitcoin-config.h` explicitly in `util/trace.h`
   on Oct 20, 2023
8. DrahtBot added the label Build system on Oct 20, 2023
9. 
   hebasto commented at 1:41 PM on October 20, 2023: member

   Missing build: prefix in title?

   Thanks! Added.

10. DrahtBot added the label CI failed on Oct 20, 2023
11. fanquake approved
12. 
    fanquake commented at 10:26 AM on October 23, 2023: member

    ACK 6bdff429ec17eae4138c3af1e21de3ec46f4ab13

13. fanquake merged this on Oct 23, 2023
14. fanquake closed this on Oct 23, 2023

    ---

15. hebasto deleted the branch on Oct 23, 2023
16. luke-jr referenced this in commit b6e8101816 on Oct 28, 2023
17. Frank-GER referenced this in commit e9da6a6c0c on Nov 28, 2023
18. bitcoin locked this on Oct 22, 2024

Contributors

hebastoDrahtBotmaflckofanquake

Milestone
26.0