init: completely remove `-zapwallettxes` (remaining hidden option) #28787

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202311-init-remove_zapwallettxes_remains changing 2 files +1 −7

theStack commented at 7:10 PM on November 3, 2023: contributor

The -zapwallettxes functionality has been removed in v0.21.0 (see commit 3340dbadd38f5624642cf0e14dddbe6f83a3863b / PR #19671), with the parameter being kept as hidden option, to inform users via an exit error that abandontransaction should be used instead.

As any guides that still suggest to use -zapwallettxes would refer to a Bitcoin Core version that is EOL since many years (i.e. <= v0.20.x), it is highly unlikely that the error caused by the option is still relevant for any user, hence it seems fine to remove it now.

init: completely remove `-zapwallettxes` (remaining hidden option)

The `-zapwallettxes` functionality has been removed in v0.21.0
(see commit 3340dbadd38f5624642cf0e14dddbe6f83a3863b / PR #19671),
with the parameter being kept as hidden option, to inform users via
an exit error that `abandontransaction` should be used instead.

As any guides that still suggest to use `-zapwallettxes` would refer to
a Bitcoin Core version that is EOL since many years (i.e. <= v0.20.x),
it is highly unlikely that the error caused by the option is still
relevant for any user, hence it seems fine to remove it now.

5039c346ca

DrahtBot commented at 7:10 PM on November 3, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK BrandonOdiwuor, fanquake, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
BrandonOdiwuor approved
BrandonOdiwuor commented at 7:29 PM on November 7, 2023: contributor

ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513

It’s been >3 years since the removal of -zapwallettxes and replaced by InitError to use abandontransaction
fanquake approved
fanquake commented at 9:48 AM on November 8, 2023: member

ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513
fanquake requested review from achow101 on Nov 8, 2023
achow101 commented at 3:50 PM on November 8, 2023: member

ACK 5039c346ca87d6112ea1eb124bdc622ba9e9a513
DrahtBot removed review request from achow101 on Nov 8, 2023
achow101 merged this on Nov 8, 2023
achow101 closed this on Nov 8, 2023
theStack deleted the branch on Nov 8, 2023
bitcoin locked this on Nov 7, 2024

Type	Reviewers
ACK	BrandonOdiwuor, fanquake, achow101

Contributors

Linked (view graph)

#19671 wallet: Remove -zapwallettxes

init: completely remove `-zapwallettxes` (remaining hidden option) #28787

Code Coverage

Reviews