Now that we require GCC 10.1+, the posix variant is available on supported systems.
i.e: https://packages.debian.org/bullseye/g++-mingw-w64-x86-64-posix https://packages.ubuntu.com/jammy/g++-mingw-w64-x86-64-posix
doc: remove mingw-w64 install for "older" systems #28900
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:modern_posix_mingw-w64 changing 1 files +0 −7-
fanquake commented at 10:58 AM on November 17, 2023: member
-
656a7e9de6
doc: remove mingw-w64 install for "older" systems
Now that we require GCC 10.1+, the posix variant is available on supported systems. i.e: https://packages.debian.org/bullseye/g++-mingw-w64-x86-64-posix https://packages.ubuntu.com/jammy/g++-mingw-w64-x86-64-posix
-
DrahtBot commented at 10:58 AM on November 17, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, BrandonOdiwuor, hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Docs on Nov 17, 2023
-
maflcko commented at 11:07 AM on November 17, 2023: member
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9
- BrandonOdiwuor approved
-
BrandonOdiwuor commented at 11:46 AM on November 17, 2023: contributor
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9
- hebasto approved
-
hebasto commented at 12:34 PM on November 17, 2023: member
ACK 656a7e9de626ea76f377c7e1e3370a869d7bcca9.
In the following code:https://github.com/bitcoin/bitcoin/blob/98b0acda0f00df3f62a61646d323c8367ddebd68/depends/hosts/mingw32.mk#L1-L3 a condition might be removed as well.
-
fanquake commented at 2:40 PM on November 17, 2023: member
a condition might be removed as well.
That wont work on systems that don't ship a
x86_64-w64-mingw32-g++with the -posix suffix? i.e Alpine. - fanquake merged this on Nov 17, 2023
- fanquake closed this on Nov 17, 2023
- fanquake deleted the branch on Nov 17, 2023
- bitcoin locked this on Dec 3, 2024
