refactor: VectorWriter and SpanReader without nVersion #28912

1. 
   maflcko commented at 2:16 PM on November 19, 2023: member

   The serialize version is unused, so remove it. This also allows to remove GCS_SER_VERSION and allows a scripted-diff to remove most of CDataStream.

2. 
   DrahtBot commented at 2:16 PM on November 19, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ryanofsky, ajtowns

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28333 (wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively by achow101)
   • #26728 (wallet: Have the wallet store the key for automatically generated descriptors by achow101)
   • #25907 (wallet: rpc to add automatically generated descriptors by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot renamed this:
   refactor: VectorWriter and SpanReader without nVersion
   refactor: VectorWriter and SpanReader without nVersion
   on Nov 19, 2023
4. DrahtBot added the label Refactoring on Nov 19, 2023
5. 
   ajtowns commented at 11:37 AM on November 20, 2023: contributor

   Shares its first commit with #28892

6. maflcko marked this as a draft on Nov 22, 2023
7. maflcko force-pushed on Nov 23, 2023
8. DrahtBot added the label Needs rebase on Nov 24, 2023
9. maflcko force-pushed on Nov 27, 2023
10. DrahtBot removed the label Needs rebase on Nov 27, 2023
11. refactor: SpanReader without nVersion

    The field is unused, so remove it.
    
    This is also required for future commits.

    fac39b56b7
12. scripted-diff: Use DataStream in most places

    The remaining places are handled easier outside a scripted-diff.
    
    -BEGIN VERIFY SCRIPT-
     sed --regexp-extended -i 's/CDataStream ([0-9a-zA-Z_]+)\(SER_[A-Z]+, [A-Z_]+_VERSION\);/DataStream \1{};/g' $( git grep -l CDataStream)
     sed -i 's/, CDataStream/, DataStream/g' src/wallet/walletdb.cpp
    -END VERIFY SCRIPT-

    fae76a1f2a
13. maflcko force-pushed on Nov 28, 2023
14. maflcko marked this as ready for review on Nov 28, 2023
15. fanquake requested review from theuni on Nov 28, 2023
16. ryanofsky approved
17. 
    ryanofsky commented at 4:29 PM on November 28, 2023: contributor

    Code review ACK fae76a1f2ac0b352cdd708e6d57f8605bf40112e

18. 
    ryanofsky commented at 4:32 PM on November 28, 2023: contributor

    What are the places where CDataStream is still needed after this and what will happen to these?

19. 
    fanquake commented at 4:34 PM on November 28, 2023: member

    Should end up removed completely in #28451.

20. 
    ajtowns commented at 5:20 PM on November 28, 2023: contributor

    ACK fae76a1f2ac0b352cdd708e6d57f8605bf40112e

21. fanquake merged this on Nov 28, 2023
22. fanquake closed this on Nov 28, 2023

    ---

23. maflcko deleted the branch on Nov 28, 2023
24. bitcoin locked this on Nov 27, 2024

Contributors

maflckoDrahtBotajtownsryanofskyfanquake

Review Requested
theuni