[26.1] final changes for 26.1rc1 #29440

1. 
   glozow commented at 2:18 pm on February 16, 2024: member

   Final changes to tag a 26.1rc1. Bumps version numbers, man pages, adds release notes etc.
2. 
   DrahtBot commented at 2:18 pm on February 16, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Backport on Feb 16, 2024
4. fanquake added this to the milestone 26.1 on Feb 16, 2024
5. 
   hebasto commented at 2:46 pm on February 16, 2024: member

   @glozow

   Feel free to pick up the https://github.com/hebasto/bitcoin/commit/d885f4f54e8e021be0ffe417af7ae1e0c76ed457 commit from the https://github.com/hebasto/bitcoin/commits/240216-26.1rc1-tr/ branch to pull the recent translations from the Transifex website.

   (same as #28763 etc)

6. 
   hebasto commented at 3:17 pm on February 16, 2024: member

   To fix the “macOS 13 native” job failure we should backport #29195.
7. glozow force-pushed on Feb 16, 2024
8. DrahtBot added the label CI failed on Feb 16, 2024
9. 
   glozow commented at 4:20 pm on February 16, 2024: member

   Thanks @hebasto, I’ve added your commit
10. in doc/man/bitcoin-cli.1:1 in 3d789657a8 outdated

    0@@ -1,7 +1,7 @@
    1-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
    2-.TH BITCOIN-CLI "1" "November 2023" "bitcoin-cli v26.0.0" "User Commands"
    3+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.1.
    

    ---

    ---

    

    hebasto commented at 4:37 pm on February 16, 2024:

    nit: Why not the same help2man version?

    ---

    

    glozow commented at 4:53 pm on February 16, 2024:

    I suppose that’s because fanquake and I use different machines
11. hebasto approved
12. 
    hebasto commented at 4:37 pm on February 16, 2024: member

    ACK 3d789657a8bf97089051348d472d7143a37ee988.
13. build: Fix `-Xclang -internal-isystem` option

    LLVM Clang >=16.0 and Apple Clang >=15.0 do not recognize
    `-Xclang -internal-isystem/usr/local/include` anymore.
    
    For example, see: https://github.com/llvm/llvm-project/commit/cbbe1d44546db52c71c9a2b18f85b87ae82df9e7
    
    Github-Pull: #29195
    Rebased-From: 8decc5c726caca2381cffbd1b3585862421f5b8e

    72eab1ca64
14. ci: Switch native macOS CI job to Xcode 15.0

    Github-Pull: #29195
    Rebased-From: d742be3d3f5d5063d7160f72422bce2fec953f38

    40e7693fa1
15. qt: 26.1rc1 translations update

    This change is a result if pulling the recent translations
    from the Transifex website using the
    bitcoin-maintainer-tools/update-translations.py tool.
    
    A few manual adjustments were made:
    - skipped removing of `bitcoin_af.ts`
    - skipped removing of `bitcoin_ar.ts`
    - skipped adding of `bitcoin_ru_RU.ts` (`bitcoin_ru.ts` is already
    present)

    c27793891a
16. [build] bump version to 26.1rc1 d4aeb4a5a0
17. [doc] update manual pages for 26.1rc1 0ffeaf237a
18. [doc] add release notes for 26.1rc1 1e7fb270d3
19. glozow force-pushed on Feb 16, 2024
20. 
    glozow commented at 5:31 pm on February 16, 2024: member

    Added backport of #29195
21. hebasto approved
22. 
    hebasto commented at 7:34 pm on February 16, 2024: member

    re-ACK 1e7fb270d36310efff6fc968f1c52291043d461b
23. 
    dergoegge commented at 10:48 am on February 19, 2024: member

    Fuzz job times out because #28933 has not been back-ported
24. 
    maflcko commented at 10:57 am on February 19, 2024: member

    Fuzz will fail either way, because the banman fuzz target isn’t updated either to include the fix #27935 .

    (Up to you if you want to fix the fuzzing, I don’t need it, I just wanted to mention that the fix is missing)

    0fuzz: test/fuzz/banman.cpp:112: void banman_fuzz_target(FuzzBufferType): Assertion `banmap == banmap_read' failed.
    

25. 
    glozow commented at 1:58 pm on February 19, 2024: member

    (Up to you if you want to fix the fuzzing, I don’t need it, I just wanted to mention that the fix is missing)

    Seems better to leave it as is

26. fanquake approved
27. 
    fanquake commented at 2:50 pm on February 19, 2024: member

    ACK 1e7fb270d36310efff6fc968f1c52291043d461b
28. fanquake merged this on Feb 19, 2024
29. fanquake closed this on Feb 19, 2024

    ---

30. glozow deleted the branch on Feb 19, 2024

Contributors
glozow DrahtBot hebasto dergoegge maflcko fanquake

Labels
Backport CI failed

Milestone
26.1