Bugfix: Correct first-run free space checks #29678

1. 
   luke-jr commented at 4:36 pm on March 19, 2024: member

   It’s not clear what m_assumed_*_size are actually set based on, but historically it was in GB, not GiB, and that’s still used in the GUI which is more user-facing.

   Could just as easily change the GUI if GiB is preferred.

2. 
   DrahtBot commented at 4:36 pm on March 19, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30132 (indexes: Don’t wipe indexes again when continuing a prior reindex by TheCharlatan)
   • #29775 (Testnet4 including PoW difficulty adjustment fix by fjahr)
   • #29432 (Stratum v2 Template Provider (take 3) by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. 
   Sjors commented at 5:37 pm on March 19, 2024: member

   I’m not sure what the latest convention is, cc @hebasto. A few years ago #15163 made it so RPC, code and GUI all use KiB / MiB / GiB.

   (though for pruning it seems the config file uses MiB, but the GUI converts it to GB - yet there are translated error strings using MiB, confusing…)

4. DrahtBot added the label Needs rebase on May 20, 2024
5. Bugfix: init: Correct conversion of AssumedBlockchainSize to use GB 315999b876
6. Bugfix: init: For first-run disk space check, advise user of correct pruned size rather than full blockchain size 3892471b1d
7. doc/release-process: Correct m_assumed_*_size to GB 847ad93f4d
8. luke-jr force-pushed on May 28, 2024
9. DrahtBot removed the label Needs rebase on May 28, 2024
10. DrahtBot added the label Needs rebase on Jun 10, 2024
11. 
    DrahtBot commented at 3:36 pm on June 10, 2024: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

12. 
    fanquake commented at 3:44 pm on June 25, 2024: member

    @hebasto can you follow up given the gui / translation Qs here. This also needs a rebase.

Contributors
luke-jr DrahtBot Sjors fanquake

Labels
Needs rebase