build, bench, msvc: Add missing benchmarks #29773

1. 
   hebasto commented at 9:43 am on March 31, 2024: member

   On the master branch, the bench_bitcoin.vcxproj MSVC project misses wallet-specific source files.

   This PR fixes this issue.

   Benchmark run on Windows:

    0> src\bench_bitcoin.exe -filter="CoinSelection|BnBExhaustion|Wallet.*"
    1
    2|               ns/op |                op/s |    err% |     total | benchmark
    3|--------------------:|--------------------:|--------:|----------:|:----------
    4|          398,800.00 |            2,507.52 |    1.5% |      0.01 | `BnBExhaustion`
    5|          584,450.00 |            1,711.01 |    1.5% |      0.01 | `CoinSelection`
    6|       86,603,650.00 |               11.55 |    0.4% |      1.91 | `WalletAvailableCoins`
    7|            7,604.00 |          131,509.73 |    0.9% |      0.01 | `WalletBalanceClean`
    8|          124,028.57 |            8,062.66 |    2.6% |      0.01 | `WalletBalanceDirty`
    9|            7,587.12 |          131,802.30 |    1.9% |      0.01 | `WalletBalanceMine`
   10|               48.58 |       20,583,872.99 |    0.9% |      0.01 | `WalletBalanceWatch`
   11|        2,371,060.00 |              421.75 |    1.3% |      0.13 | `WalletCreateTxUseOnlyPresetInputs`
   12|       96,861,760.00 |               10.32 |    0.9% |      5.31 | `WalletCreateTxUsePresetInputsAndCoinSelection`
   13|              280.71 |        3,562,424.13 |    1.5% |      0.01 | `WalletIsMineDescriptors`
   14|            1,033.47 |          967,618.32 |    0.3% |      0.01 | `WalletIsMineLegacy`
   15|              282.36 |        3,541,599.91 |    0.5% |      0.01 | `WalletIsMineMigratedDescriptors`
   16|      484,547,300.00 |                2.06 |    1.0% |      2.43 | `WalletLoadingDescriptors`
   17|       29,924,300.00 |               33.42 |    0.4% |      0.15 | `WalletLoadingLegacy`
   

2. msvc, bench: Add missing source files to bench_bitcoin project 23dc0c19ac
3. bench: Disable WalletCreate* benchmarks when building with MSVC 31a15f0aff
4. 
   DrahtBot commented at 9:43 am on March 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

5. 
   hebasto commented at 9:44 am on March 31, 2024: member

   @achow101 @sipsorcery

   Any ideas how to release a wallet database properly (see the last commit)?

6. hebasto added the label Windows on Mar 31, 2024
7. hebasto added the label Build system on Mar 31, 2024
8. hebasto added the label Tests on Mar 31, 2024
9. 
   sipsorcery commented at 9:43 pm on April 5, 2024: member

   @hebasto only guessing but I’ve always found Windows fairly average at releasing file and socket handles. Maybe that’s the cause of the test failure rather than anything code related.

   In my other life I work with SIP (telecoms protocol) with lots of socket handles flying around. If it’s only for testing then I generally just add a 5 second wait and try again for handle in use errors.

10. 
    fanquake commented at 9:03 am on May 6, 2024: member

    Is the intention to try and merge this as-is, or are the Windows issues going to be investigated and fixed (can draft if so)?
11. 
    hebasto commented at 9:12 am on May 6, 2024: member

    Is the intention to try and merge this as-is, or are the Windows issues going to be investigated and fixed (can draft if so)?

    The former. The issue is tracked in #29816.

12. 
    maflcko commented at 10:00 am on May 6, 2024: member

    An alternative would be to update the generation script?
13. 
    hebasto commented at 10:20 am on May 6, 2024: member

    An alternative would be to update the generation script?

    Yes. However, in the light of coming migration to CMake, it makes no substantial difference, right?

14. 
    maflcko commented at 10:55 am on May 6, 2024: member

    lgtm ACK 31a15f0aff79d2b34a9640909b9e6fb39a647b60
15. 
    hebasto commented at 11:53 am on May 6, 2024: member

    cc @sipsorcery
16. fanquake merged this on May 6, 2024
17. fanquake closed this on May 6, 2024

    ---

18. hebasto added the label Needs CMake port on May 6, 2024
19. hebasto removed the label Needs CMake port on May 6, 2024
20. hebasto deleted the branch on May 6, 2024

Contributors
hebasto DrahtBot sipsorcery fanquake maflcko

Labels
Windows Build system Tests