build, bench, msvc: Add missing benchmarks #29773

On the master branch, the bench_bitcoin.vcxproj MSVC project misses wallet-specific source files.

This PR fixes this issue.

Benchmark run on Windows:

> src\bench_bitcoin.exe -filter="CoinSelection|BnBExhaustion|Wallet.*"

|               ns/op |                op/s |    err% |     total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
|          398,800.00 |            2,507.52 |    1.5% |      0.01 | `BnBExhaustion`
|          584,450.00 |            1,711.01 |    1.5% |      0.01 | `CoinSelection`
|       86,603,650.00 |               11.55 |    0.4% |      1.91 | `WalletAvailableCoins`
|            7,604.00 |          131,509.73 |    0.9% |      0.01 | `WalletBalanceClean`
|          124,028.57 |            8,062.66 |    2.6% |      0.01 | `WalletBalanceDirty`
|            7,587.12 |          131,802.30 |    1.9% |      0.01 | `WalletBalanceMine`
|               48.58 |       20,583,872.99 |    0.9% |      0.01 | `WalletBalanceWatch`
|        2,371,060.00 |              421.75 |    1.3% |      0.13 | `WalletCreateTxUseOnlyPresetInputs`
|       96,861,760.00 |               10.32 |    0.9% |      5.31 | `WalletCreateTxUsePresetInputsAndCoinSelection`
|              280.71 |        3,562,424.13 |    1.5% |      0.01 | `WalletIsMineDescriptors`
|            1,033.47 |          967,618.32 |    0.3% |      0.01 | `WalletIsMineLegacy`
|              282.36 |        3,541,599.91 |    0.5% |      0.01 | `WalletIsMineMigratedDescriptors`
|      484,547,300.00 |                2.06 |    1.0% |      2.43 | `WalletLoadingDescriptors`
|       29,924,300.00 |               33.42 |    0.4% |      0.15 | `WalletLoadingLegacy`

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage

For detailed information about the code coverage, see the test coverage report.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

No conflicts as of last run.

@achow101 @sipsorcery

Any ideas how to release a wallet database properly (see the last commit)?

@hebasto only guessing but I've always found Windows fairly average at releasing file and socket handles. Maybe that's the cause of the test failure rather than anything code related.

In my other life I work with SIP (telecoms protocol) with lots of socket handles flying around. If it's only for testing then I generally just add a 5 second wait and try again for handle in use errors.

Is the intention to try and merge this as-is, or are the Windows issues going to be investigated and fixed (can draft if so)?

Is the intention to try and merge this as-is, or are the Windows issues going to be investigated and fixed (can draft if so)?

The former. The issue is tracked in #29816.

An alternative would be to update the generation script?

An alternative would be to update the generation script?

Yes. However, in the light of coming migration to CMake, it makes no substantial difference, right?

lgtm ACK 31a15f0aff79d2b34a9640909b9e6fb39a647b60

cc @sipsorcery