[27.x] Backports

fanquake commented at 8:35 am on April 16, 2024: member

Backports:

#29691
#29747
#29776
#29853
#29856
#29859
#29869
#29870
#29886
#29892
#29934
https://github.com/bitcoin/bitcoin/pull/29985

depends: fix mingw-w64 Qt DEBUG=1 build

The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`,
but then linking is done with `x86_64-w64-mingw32-g++`.

I'm guessing this has been broken since #24131
(01d1845a80ae48d741deea695ddce95d940ab0d8), but have not checked.

Fixes #29734.
Unblocks #29527 (now DEBUG=1 builds can be tested).

Github-Pull: #29747
Rebased-From: b7e7e727abd86104ee58beb648a94e2f453d1f6d

a6862c50c5

Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us

To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.

Github-Pull: #29691
Rebased-From: 4f273ab4360c9aa72c2feb78787e1811ab58dc16

20e6e8dc80

ci: Bump s390x to ubuntu:24.04

Re-enable feature_init

Github-Pull: #29856
Rebased-From: fadf7e90dc10e212e59bb294209bab2e73c47800

602cfd580a

[rpc, bugfix] Enforce maximum value for setmocktime

Github-Pull: #29869
Rebased-From: c2e0489b7125cceaeef355fc274dd8988822fff4

897e5af58a

fanquake added this to the milestone 27.1 on Apr 16, 2024

DrahtBot commented at 8:35 am on April 16, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	willcl-ark, stickies-v, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Backport on Apr 16, 2024

DrahtBot added the label CI failed on Apr 16, 2024

DrahtBot removed the label CI failed on Apr 16, 2024

doc: archive 27.0 release notes

Github-Pull: #29886
Rebased-From: c08754971d207bd2b60ba9c4faf34396a97bbc26

5c097910e0

test: Fix failing univalue float test

Github-Pull: #29892
Rebased-From: fa4c69669e079c38844ecea1ad3394aae3702ae1

9277793b4e

build: Fix false positive `CHECK_ATOMIC` test for clang-15

Github-Pull: #29859
Rebased-From: dd3e0fa12534c9e782dc9c24d2e30b70a0d73176

364bf01ff2

fanquake force-pushed on Apr 17, 2024

DrahtBot added the label CI failed on Apr 17, 2024

DrahtBot removed the label CI failed on Apr 17, 2024

rpc: Reword SighashFromStr error message

Github-Pull: #29870
Rebased-From: fa6ab0d020d0b1492203f7eb2ccb8051812de086

a6a59cfebc

fanquake force-pushed on Apr 24, 2024

sign: don't assume we are parsing a sane Miniscript

The script provided for signature might be externally provided, for
instance by way of 'finalizepsbt'. Therefore the script might be
ill-crafted, so don't assume pubkeys are always 32 bytes.

Thanks to Niklas for finding this.

Github-Pull: #29853
Rebased-From: 4d8d21320eba54571ff63931509cd515c3e20339

ae9a2ed40a

fanquake force-pushed on Apr 24, 2024

DrahtBot added the label CI failed on Apr 24, 2024

Fix #29767, set m_synced = true after Commit()

Github-Pull: #29776
Rebased-From: bbe82c116e72ca0638751e063bf564cd1fe5c4d5

0fcceefe22

fanquake force-pushed on Apr 26, 2024

depends: Fix build of Qt for 32-bit platforms

The 32 to 64-bit time_t transition causes a build failure in the built-in
zlib about conflicting _TIME_BITS and _FILE_OFFSET_BITS.

Note that zlib doesn't use time_t at all, so it is a false alarm.

Take the following patch from upstream zlib:
https://github.com/madler/zlib/commit/a566e156b3fa07b566ddbf6801b517a9dba04fa3.patch

Closes #29980.

Github-Pull: #29985
Rebased-From: 2e266f33b5d2be5c233c2c692481f75785714fa1

a995902d60

fanquake force-pushed on Apr 30, 2024

doc: add LLVM instruction for macOS < 13

Github-Pull: #29934
Rebased-From: 22574046c90c0662f3aa9b1baea074aff54f92a9

475aac41fb

fanquake force-pushed on May 2, 2024

fanquake marked this as ready for review on May 6, 2024

fanquake requested review from stickies-v on May 6, 2024

in depends/packages/qt.mk:256 in 46890065e5 outdated

255@@ -254,6 +256,7 @@ define $(package)_preprocess_cmds
256   patch -p1 -i $($(package)_patch_dir)/fast_fixed_dtoa_no_optimize.patch && \

willcl-ark commented at 2:27 pm on May 9, 2024:

In: a995902d604c701be4f46087057b907de9a0ecca

This also appears to pull in fast_fixed_dta_no_optimise.patch and I think that may not be intentional based on the commit it’s rebasing?:

willcl-ark commented at 2:55 pm on May 9, 2024:

Sorry for the noise, this is just my script misbehaving. Script confused as fast_fixed_dtoa_no_dtoa_no_optimse was removed from master in the interim which confused the diffs.

willcl-ark commented at 2:38 pm on May 9, 2024: member

Left one question, looks good otherwise

willcl-ark approved

willcl-ark commented at 7:04 pm on May 9, 2024: member

ACK 46890065e59875dd3d736d04f427e410bbd8faed

Without my earlier misunderstanding, this all looks good to me.

in doc/release-notes.md:38 in 46890065e5 outdated

33@@ -34,184 +34,55 @@ Core should also work on most other Unix-like systems but is not as
34 frequently tested on them. It is not recommended to use Bitcoin Core on
35 unsupported systems.
36 
37-Notable changes
38-===============

stickies-v commented at 8:30 pm on May 9, 2024:

I think we usually keep this header?

in doc/release-notes.md:48 in 46890065e5 outdated

58-  blocks. (#29189)
59+### Index
60 
61-mempool.dat compatibility
62--------------------------
63+- #29767 Fix #29767, set m_synced = true after Commit()

stickies-v commented at 8:33 pm on May 9, 2024:

0- [#29776](/bitcoin-bitcoin/29776/) Fix [#29767](/bitcoin-bitcoin/29767/), set m_synced = true after Commit()

stickies-v commented at 8:41 pm on May 9, 2024:

Also, this is the commit message and not the PR title but this is a bit more descriptive so makes sense.

fanquake commented at 3:27 am on May 10, 2024:

Thanks, addressed both.

stickies-v approved

stickies-v commented at 8:43 pm on May 9, 2024: contributor

ACK 46890065e59875dd3d736d04f427e410bbd8faed

All backports clean except for 0fcceefe22532dc6389a95d2e058599e9496003b because of #28955, but the backport looks good to me. CI failure looks unrelated.

[WIP] doc: release notes for 27.x bd5860bc7a

fanquake force-pushed on May 10, 2024

willcl-ark commented at 8:20 am on May 10, 2024: member

reACK bd5860bc7a892c6bcffe313246dd6b81b973b9c6

DrahtBot requested review from stickies-v on May 10, 2024

stickies-v approved

stickies-v commented at 8:31 am on May 10, 2024: contributor

re-ACK bd5860bc7a892c6bcffe313246dd6b81b973b9c6

hebasto commented at 3:51 am on May 12, 2024: member

I suggest to add https://github.com/bitcoin-core/gui/pull/812 and https://github.com/bitcoin-core/gui/pull/813.

TheCharlatan approved

TheCharlatan commented at 3:00 pm on May 12, 2024: contributor

ACK bd5860bc7a892c6bcffe313246dd6b81b973b9c6

fanquake commented at 3:52 am on May 13, 2024: member

I suggest to add https://github.com/bitcoin-core/gui/pull/812 and https://github.com/bitcoin-core/gui/pull/813.

I’ll put these into the next PR, that will likely also do release prep.

fanquake merged this on May 13, 2024

fanquake closed this on May 13, 2024

fanquake deleted the branch on May 13, 2024

[27.x] Backports #29888

Code Coverage

Reviews