depends: Do not consider `CC` environment variable for detecting system #29963

hebasto commented at 7:01 PM on April 25, 2024: member

On the master branch @ 3c88eac28e8984893746caebb313dc3b2fca90db, consider the following commands in the depends subdirectory:

$ make print-build HOST=i686-pc-linux-gnu CC="clang -m32"
build=x86_64-pc-linux-gnu
$ make print-host HOST=i686-pc-linux-gnu CC="clang -m32"
host=i686-pc-linux-gnu

The printed variable values are expected.

However, switching the CC variable context from Makefile to the shell environment breaks expectations:

$ CC="clang -m32" make print-build HOST=i686-pc-linux-gnu
build=i686-pc-linux-gnu
$ CC="clang -m32" make print-host HOST=i686-pc-linux-gnu
host=i686-pc-linux-gnu

This PR fixes this issue.

UPDATE 2026-01-20

On the master branch @ 7f5ebef56a0f2bad7df30252b11da3e33cb3c144:

$ gmake print-build HOST=i686-pc-linux-gnu CC="clang -m32"
build=i686-pc-linux-gnu
$ gmake print-host HOST=i686-pc-linux-gnu CC="clang -m32"
host=i686-pc-linux-gnu

hebasto added the label Build system on Apr 25, 2024

DrahtBot commented at 7:01 PM on April 25, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29963.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	sedited, ryanofsky

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

No conflicts as of last run.

hebasto referenced this in commit 370c4e9161 on Apr 25, 2024

theuni commented at 7:20 PM on April 25, 2024: member

Where/why is this an issue?

hebasto referenced this in commit 727cc73bcc on Apr 25, 2024

hebasto commented at 7:27 PM on April 25, 2024: member

Where/why is this an issue?

I faced this issue during my work on the CMake staging branch when the CC environment variable was defined by the CI -- https://github.com/hebasto/bitcoin/actions/runs/8822538616/job/24220973382.

The log shows no cross-compiling, but it is cross-compiling to i686-pc-linux-gnu.

theuni commented at 9:01 PM on April 25, 2024: member

Surely this isn't the only place env vars like this would cause issues? Feels like a cat-and-mouse game.

maflcko commented at 8:11 AM on April 26, 2024: member

The log shows no cross-compiling, but it is cross-compiling to i686-pc-linux-gnu.

Can you link to the exact lines in the log that show "no cross-compiling".

hebasto commented at 9:29 AM on April 26, 2024: member

The log shows no cross-compiling, but it is cross-compiling to i686-pc-linux-gnu.

Can you link to the exact lines in the log that show "no cross-compiling".

https://github.com/hebasto/bitcoin/actions/runs/8822538616/job/24220973382#step:14:245:

Cross compiling ....................... FALSE

Please note that that was a PR branch from the CMake migration project. That branch detects cross-compiling basing on host and build values when building with depends.

fanquake commented at 9:51 AM on April 26, 2024: member

Surely this isn't the only place env vars like this would cause issues? Feels like a cat-and-mouse game.

Yea, as-is this doesn't seem like a great fix, and may just break other things?

A better diff might be something like:

diff --git a/depends/Makefile b/depends/Makefile
index 005d9696fb..091511758d 100644
--- a/depends/Makefile
+++ b/depends/Makefile
@@ -51,7 +51,7 @@ FALLBACK_DOWNLOAD_PATH ?= https://bitcoincore.org/depends-sources
 C_STANDARD ?= c11
 CXX_STANDARD ?= c++20
 
-BUILD = $(shell ./config.guess)
+BUILD = $(shell CC_FOR_BUILD=$CC ./config.guess)
 HOST ?= $(BUILD)
 PATCHES_PATH = $(BASEDIR)/patches
 BASEDIR = $(CURDIR)

which would at least be using the option that is meant to be used for this.

hebasto force-pushed on Apr 26, 2024

hebasto commented at 10:05 AM on April 26, 2024: member

A better diff might be something like: ... which would at least be using the option that is meant to be used for this.

I agree. Implemented.

Thanks!

hebasto renamed this:
~~depends: Do not consider `CC` environment variable for detecting system~~
depends: Use `CC_FOR_BUILD` for `config.guess `
on Apr 26, 2024

theuni commented at 12:47 PM on April 26, 2024: member

However, switching the CC variable context from Makefile to the shell environment breaks expectations

Arguably that's because this wasn't intended to be supported :)

I suppose this fix is reasonable, though supporting env vars like this seems quite brittle.

hebasto referenced this in commit 21bee57cb6 on Apr 30, 2024

hebasto referenced this in commit 516ecf1c8e on May 2, 2024

hebasto referenced this in commit 729632c54f on May 2, 2024

fanquake commented at 3:37 PM on May 31, 2024: member

Is this still an issue given recent CMake changes?

hebasto commented at 10:10 AM on June 3, 2024: member

Is this still an issue given recent CMake changes?

Yes. Tested with the master branch @ 80bdd4b6beb878c95478b5623c9f9ff0b948ad57.

And this PR still fixes it.

DrahtBot added the label CI failed on Jun 18, 2024

DrahtBot removed the label CI failed on Jun 18, 2024

DrahtBot added the label CI failed on Sep 10, 2024

DrahtBot removed the label CI failed on Sep 14, 2024

achow101 requested review from fanquake on Oct 15, 2024

achow101 requested review from theuni on Oct 15, 2024

fanquake commented at 4:03 PM on October 24, 2024: member

@hebasto can you rebase this?

hebasto force-pushed on Oct 24, 2024

hebasto commented at 4:08 PM on October 24, 2024: member

@hebasto can you rebase this?

Rebased.

fanquake added the label DrahtBot Guix build requested on Oct 24, 2024

DrahtBot commented at 9:54 AM on October 25, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 74fb19317aec6d5156e12da6be63e59e0cc99770<br>(master)	commit 8cf6a3aeaf20437a714b6c2b6f817cd57d8cff09<br>(master and this pull)
SHA256SUMS.part	`ad80f9275f7592f5...`	`60cfbff26d3ac855...`
*-aarch64-linux-gnu-debug.tar.gz	`e3f077c9e2efe42c...`	`1611c2fc3615b36a...`
*-aarch64-linux-gnu.tar.gz	`84c5837e967a705e...`	`e0db625be9859af1...`
*-arm-linux-gnueabihf-debug.tar.gz	`198436220bbb764e...`	`8115f020abf2acf7...`
*-arm-linux-gnueabihf.tar.gz	`8ab9ee456035f028...`	`fb518d26a6936a6c...`
*-arm64-apple-darwin-unsigned.tar.gz	`5f3493c8841e7000...`	`41229727f60b73c3...`
*-arm64-apple-darwin-unsigned.zip	`53586205b08dae04...`	`377fcbf11713b0cb...`
*-arm64-apple-darwin.tar.gz	`9bc61a1a9c494690...`	`19cf2e7611080487...`
*-powerpc64-linux-gnu-debug.tar.gz	`d736c35074e1ab00...`	`cba9b8d9e094dee0...`
*-powerpc64-linux-gnu.tar.gz	`dc3411d9d8e023d0...`	`60d275915f058dbe...`
*-riscv64-linux-gnu-debug.tar.gz	`14f550c7e6be73cb...`	`f881035b90972ed6...`
*-riscv64-linux-gnu.tar.gz	`a5ce20b057de5651...`	`b063b32fa7b6c2d8...`
*-x86_64-apple-darwin-unsigned.tar.gz	`0a5aeae59a745fdd...`	`ee329307733e0a36...`
*-x86_64-apple-darwin-unsigned.zip	`c17d6c147152032f...`	`3098eb653ffa25a8...`
*-x86_64-apple-darwin.tar.gz	`eb310f282a01918f...`	`21a73422bd7b32f1...`
*-x86_64-linux-gnu-debug.tar.gz	`788598dd19a44259...`	`c470987123553747...`
*-x86_64-linux-gnu.tar.gz	`6b13f937a5601c35...`	`57a8a8062bb61dc7...`
*.tar.gz	`d344eb18d56160d8...`	`e059bb50c284f19f...`
guix_build.log	`baf52e47221c27f4...`	`57984899bf58d2f5...`
guix_build.log.diff		`df4e8b61eda9235c...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 25, 2024

hebasto commented at 5:00 PM on October 29, 2024: member

My Guix build:

aarch64
a2d14a22db6670a4f33aa4a7f9bd04d45cb861993b51670c4c950bf98f68864f  guix-build-707d65ba0d74/output/aarch64-linux-gnu/SHA256SUMS.part
71d45a6c783b287a3369503b34ef08a42b5c4a2c8c2f636cf4665574e4f2f0ac  guix-build-707d65ba0d74/output/aarch64-linux-gnu/bitcoin-707d65ba0d74-aarch64-linux-gnu-debug.tar.gz
3f5fb049c4347d25c091ec4412dfb3a9a6488a28aad2cca7bd52d822ff6b5f0f  guix-build-707d65ba0d74/output/aarch64-linux-gnu/bitcoin-707d65ba0d74-aarch64-linux-gnu.tar.gz
bb8a6a2aa57ea0d7e26523bd0d9bfd32416c31e3e0f7f1facc237f70c1528b16  guix-build-707d65ba0d74/output/arm-linux-gnueabihf/SHA256SUMS.part
abd7c08544aaf6c1c3538a8cdd551eec9e545eac0f2fdaf036d1cf99e6e62933  guix-build-707d65ba0d74/output/arm-linux-gnueabihf/bitcoin-707d65ba0d74-arm-linux-gnueabihf-debug.tar.gz
c1a542509b91945b679e520ff398bee9c3d66e94a3a1c356209b88290ae1202e  guix-build-707d65ba0d74/output/arm-linux-gnueabihf/bitcoin-707d65ba0d74-arm-linux-gnueabihf.tar.gz
c383ab8414f738ac152cfbc8c273bb224593854d605ecd3317f9d4485c672aa1  guix-build-707d65ba0d74/output/arm64-apple-darwin/SHA256SUMS.part
9321290cd61e8c11aa46fa68130011362cc2d0a4d6d89520294f255c2de90dde  guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin-unsigned.tar.gz
53e9e64ae7f34c19b56528245554a90005ef25af28ef5971eaecb002c821d87c  guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin-unsigned.zip
1012af184f40d376e3807ee07f4c12b67a1ccaf43ee469d36b0cb4d2d989a53c  guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin.tar.gz
e725088b69b7f8e1332e488bf0950f1f39ccbb70c632b73dd6548a55861a8efa  guix-build-707d65ba0d74/output/dist-archive/bitcoin-707d65ba0d74.tar.gz
881cc54f072595aee80e3e6557ff69d273e212ff5b9dec01eab2b26b15f5ae7a  guix-build-707d65ba0d74/output/powerpc64-linux-gnu/SHA256SUMS.part
00937e24253737195ddea04e2305c2e1eebff95152409b23ad39aa645cbd5787  guix-build-707d65ba0d74/output/powerpc64-linux-gnu/bitcoin-707d65ba0d74-powerpc64-linux-gnu-debug.tar.gz
4fae317645f9b1ea003b6c6002e00bd4700bbe4be5b24d40f831c68d5cacc595  guix-build-707d65ba0d74/output/powerpc64-linux-gnu/bitcoin-707d65ba0d74-powerpc64-linux-gnu.tar.gz
1db9cd63de6253f01f8ea816847040bf8784c9f8033acc88d52a0b6e5a77dfd4  guix-build-707d65ba0d74/output/riscv64-linux-gnu/SHA256SUMS.part
529314421f8301cf3fe88369c647858f73dff06a0f3710bcaa4d9cd4ba54d90b  guix-build-707d65ba0d74/output/riscv64-linux-gnu/bitcoin-707d65ba0d74-riscv64-linux-gnu-debug.tar.gz
dbe7d077b7707d04f8b90860064a449b84c0869b8e8ba628e5756e80127153a3  guix-build-707d65ba0d74/output/riscv64-linux-gnu/bitcoin-707d65ba0d74-riscv64-linux-gnu.tar.gz
51f2978456c02a6449028a6734e4affcc55002dac2222d546447279eda6aa4ba  guix-build-707d65ba0d74/output/x86_64-apple-darwin/SHA256SUMS.part
90f77b77a538820591efc724416936a601ead4a3eba02fd10e119fa8c6ad01da  guix-build-707d65ba0d74/output/x86_64-apple-darwin/bitcoin-707d65ba0d74-x86_64-apple-darwin-unsigned.tar.gz
ed0971cf057ccb95712822e39d111bb921e735115a494ae6e0160ec5b84fdb2e  guix-build-707d65ba0d74/output/x86_64-apple-darwin/bitcoin-707d65ba0d74-x86_64-apple-darwin-unsigned.zip
a513a1b3cf4a013539a0948e5da007a1574880ccf2df528741ede6107729b465  guix-build-707d65ba0d74/output/x86_64-apple-darwin/bitcoin-707d65ba0d74-x86_64-apple-darwin.tar.gz
0c2030f3ccfbcbf4c1cb410f854802ad6126e9283a57709e980396b5f7c6241c  guix-build-707d65ba0d74/output/x86_64-linux-gnu/SHA256SUMS.part
7a0343c42277c10f6bd833c63d6ea1bbfb19ee99e2c77dc06b07b702a7336396  guix-build-707d65ba0d74/output/x86_64-linux-gnu/bitcoin-707d65ba0d74-x86_64-linux-gnu-debug.tar.gz
7dfc7bc9c6b301e8d51001d8a23077e318ee15d6582d45a0d173bc0269b83eb2  guix-build-707d65ba0d74/output/x86_64-linux-gnu/bitcoin-707d65ba0d74-x86_64-linux-gnu.tar.gz
81d60661f8d1bede83b1c2e1784455bdf0356fca6c3b072c1b3bd75a9a8c3b30  guix-build-707d65ba0d74/output/x86_64-w64-mingw32/SHA256SUMS.part
4a714fafca490232218f2ceb85ff624995f850b71517908e687c6fca0ec6474a  guix-build-707d65ba0d74/output/x86_64-w64-mingw32/bitcoin-707d65ba0d74-win64-debug.zip
3a47127b553e573d23422917d1c0f13901737089c3c4284c8d8814a196821fa2  guix-build-707d65ba0d74/output/x86_64-w64-mingw32/bitcoin-707d65ba0d74-win64-setup-unsigned.exe
b6b3a834a5356034f31564688b1b2d21da2929fe29b6d5c4ae4489b820e2798e  guix-build-707d65ba0d74/output/x86_64-w64-mingw32/bitcoin-707d65ba0d74-win64-unsigned.tar.gz
ee775c94af00706762fa29c827baf93afbd68a075298b062213bce391cc2f043  guix-build-707d65ba0d74/output/x86_64-w64-mingw32/bitcoin-707d65ba0d74-win64.zip

hebasto commented at 9:42 AM on February 10, 2025: member

@theuni

However, switching the CC variable context from Makefile to the shell environment breaks expectations

Arguably that's because this wasn't intended to be supported :)

I suppose this fix is reasonable, though supporting env vars like this seems quite brittle.

There are testing environments, such as OSS-Fuzz, that rely on a project's build system to support environment variables.

DrahtBot added the label Needs rebase on Feb 12, 2025

hebasto force-pushed on Feb 12, 2025

hebasto commented at 12:32 PM on February 12, 2025: member

Rebased to resolve the conflict with the merged bitcoin/bitcoin#30584.

DrahtBot removed the label Needs rebase on Feb 12, 2025

hebasto commented at 3:17 PM on February 12, 2025: member

My Guix build:

aarch64
ab623f96d21b9651618ccd3dd1dd547494ecbe199cf1146dfebde4d02cd141a4  guix-build-38d13e68e276/output/aarch64-linux-gnu/SHA256SUMS.part
1f70c006d53d319ebbfb915a909419d5084489e527c8cf24369f113c96705251  guix-build-38d13e68e276/output/aarch64-linux-gnu/bitcoin-38d13e68e276-aarch64-linux-gnu-debug.tar.gz
ae9eb92cdd2eee116bd48199ee9d8093082f58ce158badd47aaaa3cd044d2d9a  guix-build-38d13e68e276/output/aarch64-linux-gnu/bitcoin-38d13e68e276-aarch64-linux-gnu.tar.gz
31c6976e87e9d1e87759ab3057f2c75eb5ed824e0a986a8317dd7b9bcd0d8fa7  guix-build-38d13e68e276/output/arm-linux-gnueabihf/SHA256SUMS.part
2a3ac0e4368c9d83419539db88a886e4f49ad93e67bf6bcc78d88c4118ab40c7  guix-build-38d13e68e276/output/arm-linux-gnueabihf/bitcoin-38d13e68e276-arm-linux-gnueabihf-debug.tar.gz
2a5e990b3c3c236bcfe720d526dbf2a319d15eba81591d280aad15c746511bb9  guix-build-38d13e68e276/output/arm-linux-gnueabihf/bitcoin-38d13e68e276-arm-linux-gnueabihf.tar.gz
c5d8de4a45ed34f3cce046a540421fc05ab0f98937479afe279f645522e5d961  guix-build-38d13e68e276/output/arm64-apple-darwin/SHA256SUMS.part
f12c6ca851f7f1bc88ed8f31aa87cf10aad84974eceab20e463de91ef3508142  guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin-unsigned.tar.gz
0e03be196c8d5a40e0fd8cfa397e19f0d61f14fb8ff2ab50bf90a06289b2362d  guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin-unsigned.zip
c3705df317214be53b9360f91ca9a4c1721c6bb4dad75cc348afb19d3f5c3858  guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin.tar.gz
db57e79fd0d357b99d8d4e762806933ac93d464f19f66b050c9cbe5f52250ab6  guix-build-38d13e68e276/output/dist-archive/bitcoin-38d13e68e276.tar.gz
c221715291996b44d6f4b23afb9add05987d50936d0f52fda64d5ee8410b3806  guix-build-38d13e68e276/output/powerpc64-linux-gnu/SHA256SUMS.part
3c5f3605d0905db76d79fdb84732e0966847c49e0ce0bf676e21c8ba57a1043f  guix-build-38d13e68e276/output/powerpc64-linux-gnu/bitcoin-38d13e68e276-powerpc64-linux-gnu-debug.tar.gz
b7766749323a62b282f01de85877921e957db7c1b59a051d2a1b10c17e8c54c0  guix-build-38d13e68e276/output/powerpc64-linux-gnu/bitcoin-38d13e68e276-powerpc64-linux-gnu.tar.gz
1d2fd609475244b702a3a945f4cf65bbf1ebd1bcabdcd1f8189581255a4ed699  guix-build-38d13e68e276/output/riscv64-linux-gnu/SHA256SUMS.part
c4f08e1f730f89084a05c56ff1eca2962ac1ca83add1cc65ef46fc4a93fd0ea2  guix-build-38d13e68e276/output/riscv64-linux-gnu/bitcoin-38d13e68e276-riscv64-linux-gnu-debug.tar.gz
12a1f93c3bb5aaff41cd9ecb4bf4fe6e09cb251befa06c2d3832706bc6a87d97  guix-build-38d13e68e276/output/riscv64-linux-gnu/bitcoin-38d13e68e276-riscv64-linux-gnu.tar.gz
bc6ab43d9046cccb70fcef4782395bcc71ca0039ab0c63fdd60fbe9de0d0a573  guix-build-38d13e68e276/output/x86_64-apple-darwin/SHA256SUMS.part
aa844cf3c1cec314bd7035845cedadc1240aa7dc77b6510f85735d464f5f84d5  guix-build-38d13e68e276/output/x86_64-apple-darwin/bitcoin-38d13e68e276-x86_64-apple-darwin-unsigned.tar.gz
43d30e0027c18a7aeb439b13b6761373cb53984500b3e99ebb82cac2d7fb11ca  guix-build-38d13e68e276/output/x86_64-apple-darwin/bitcoin-38d13e68e276-x86_64-apple-darwin-unsigned.zip
a4ee31178b1746245f27ed77a61c928f1df39ff916fb83193828666b364a3849  guix-build-38d13e68e276/output/x86_64-apple-darwin/bitcoin-38d13e68e276-x86_64-apple-darwin.tar.gz
f01cff25baea72e8a2ddfeab7e1d04023cfc99176072e6446aebd59cb501dc18  guix-build-38d13e68e276/output/x86_64-linux-gnu/SHA256SUMS.part
9dfcf2c386ea4821425449ff1244aa26b83c70b6fa36767de26be48ff98d069e  guix-build-38d13e68e276/output/x86_64-linux-gnu/bitcoin-38d13e68e276-x86_64-linux-gnu-debug.tar.gz
755689356c0838578db1b7fe61f2b0727e8cdddccd015a7f69188174149a981a  guix-build-38d13e68e276/output/x86_64-linux-gnu/bitcoin-38d13e68e276-x86_64-linux-gnu.tar.gz
b0f47c75baea43007e7cf8469634121086068cb6658107a46faef2e0b2f7d64c  guix-build-38d13e68e276/output/x86_64-w64-mingw32/SHA256SUMS.part
b6a07fc34dc3c50ae4804aebfbfcfdd05f553e80df73dfa9de78790e5f395250  guix-build-38d13e68e276/output/x86_64-w64-mingw32/bitcoin-38d13e68e276-win64-debug.zip
154d6cb011f475b21c0941a568662ada35654cff20d05fd0cd4dd28214e8c169  guix-build-38d13e68e276/output/x86_64-w64-mingw32/bitcoin-38d13e68e276-win64-setup-unsigned.exe
ca2708afbadea82d840a69885d5b5f6f233b32ff5b512e20b5f34c7e51c18875  guix-build-38d13e68e276/output/x86_64-w64-mingw32/bitcoin-38d13e68e276-win64-unsigned.tar.gz
e7c0ece29c932db0747bfa5e7924b9553c1dd18e21f5c066f58d33ecb1e8b5c3  guix-build-38d13e68e276/output/x86_64-w64-mingw32/bitcoin-38d13e68e276-win64.zip

theuni commented at 6:55 PM on February 12, 2025: member

I don't understand this change. It seems setting CC_FOR_BUILD to CC is exactly the opposite of what we want to do? @hebasto's original change makes more sense to me:

BUILD = $(shell env --unset CC ./config.guess)

That ignores what's set in CC when detecting the native platform, which seems like the correct behavior to me.

What was your intention with this patch, @fanquake ?

DrahtBot added the label CI failed on Jul 3, 2025

DrahtBot removed the label CI failed on Jul 3, 2025

hebasto commented at 2:47 PM on October 16, 2025: member

What was your intention with this patch, @fanquake ? @fanquake

Can you please follow up here?

fanquake commented at 3:01 PM on October 16, 2025: member

What was your intention with this patch, @fanquake ?

At this point I can't remember.

hebasto force-pushed on Oct 16, 2025

hebasto commented at 3:30 PM on October 16, 2025: member

I don't understand this change. It seems setting CC_FOR_BUILD to CC is exactly the opposite of what we want to do?

@hebasto's original change makes more sense to me:
BUILD = $(shell env --unset CC ./config.guess)
That ignores what's set in CC when detecting the native platform, which seems like the correct behavior to me.

Reverted to the initial variant.

maflcko added the label DrahtBot Guix build requested on Oct 17, 2025

DrahtBot commented at 5:19 AM on October 18, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit e744fd1249bf9577274614eaf3997bf4bbb612ff<br>(master)	commit 54dbc5e77ad00e3f7380c38bfae16ad9b658ff82<br>(pull/29963/merge)
*-aarch64-linux-gnu-debug.tar.gz	`32d2b2bff7365b1c...`	`ce61c970b8dc1d60...`
*-aarch64-linux-gnu.tar.gz	`3594fcd0903223b0...`	`c7c95543170ed8e4...`
*-arm-linux-gnueabihf-debug.tar.gz	`4de5c3cd73bd7eb9...`	`1a19b67c6b36dabd...`
*-arm-linux-gnueabihf.tar.gz	`13f399dfc5a94137...`	`d2948f4a50b0a508...`
*-arm64-apple-darwin-codesigning.tar.gz	`0c9523d4eb3ba947...`	`c151d061693ef9de...`
*-arm64-apple-darwin-unsigned.tar.gz	`f882bd8563b54515...`	`c5017f8707b03ecc...`
*-arm64-apple-darwin-unsigned.zip	`3a60151847070008...`	`025cfb4b4edbae2a...`
*-powerpc64-linux-gnu-debug.tar.gz	`8f1f0238de30643b...`	`255bfcdc5775c810...`
*-powerpc64-linux-gnu.tar.gz	`7e7ac48e6be97c65...`	`10ecdfeec2d83982...`
*-riscv64-linux-gnu-debug.tar.gz	`e3fd237224b534e3...`	`f3cc48ef19a06439...`
*-riscv64-linux-gnu.tar.gz	`fbb4391c11fd6b13...`	`4d975b60e434c347...`
*-x86_64-apple-darwin-codesigning.tar.gz	`1f328e37aeebed54...`	`e751d8b18aa1a9aa...`
*-x86_64-apple-darwin-unsigned.tar.gz	`45bc90bde841a319...`	`b58bed75699aacbd...`
*-x86_64-apple-darwin-unsigned.zip	`0e98d3057136e774...`	`bed415617451a200...`
*-x86_64-linux-gnu-debug.tar.gz	`df820b76cfc1f8fd...`	`707cc102e4367aac...`
*-x86_64-linux-gnu.tar.gz	`1498128d1e400b9b...`	`074e090586df1d19...`
*.tar.gz	`5a44c21c41738a47...`	`23a07719c8928b63...`
SHA256SUMS.part	`ac10442f7b6714bf...`	`f056342587a24108...`
guix_build.log	`c91f72065087d81c...`	`32f7c30269b7d917...`
guix_build.log.diff		`cf719a9200d66db7...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 18, 2025

hebasto renamed this:
~~depends: Use `CC_FOR_BUILD` for `config.guess `~~
depends: Do not consider `CC` environment variable for detecting system
on Dec 4, 2025

ryanofsky approved

ryanofsky commented at 1:43 PM on December 15, 2025: contributor

Code review ACK a8cdc5872eaaffd56a8c79c6d371feb0df12431a. Seems good to unset an environment variable intended for cross compilation that is a causing a bad result when calling a native tool.

hebasto commented at 5:53 PM on December 15, 2025: member

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
aarch64
7499d3ff76f9fec34c5d18fe5a9b518a96b6a8bed0c4e4981a7d718ca70cd695  guix-build-a8cdc5872eaa/output/aarch64-linux-gnu/SHA256SUMS.part
6edf8ed2a7548293a3ff2ddd4e6d8ea9b8d26af330a8e5e6b36a699a4f4b4ef3  guix-build-a8cdc5872eaa/output/aarch64-linux-gnu/bitcoin-a8cdc5872eaa-aarch64-linux-gnu-debug.tar.gz
bd3b3a35d0a8f458fb750332ffe87fa827623aa2165b771bc5fce68df0a77faf  guix-build-a8cdc5872eaa/output/aarch64-linux-gnu/bitcoin-a8cdc5872eaa-aarch64-linux-gnu.tar.gz
836f1dba1a32b7e875dadb2de06645b19a10e57cd6cb7fa83183076783048c58  guix-build-a8cdc5872eaa/output/arm-linux-gnueabihf/SHA256SUMS.part
17f49dff7a519d4ef6db3346b6c3a85cbd69b5d7eb771278a66901af669fd65c  guix-build-a8cdc5872eaa/output/arm-linux-gnueabihf/bitcoin-a8cdc5872eaa-arm-linux-gnueabihf-debug.tar.gz
dbb62bdef08f4a66abbc4df29c6b6f13160eac829a2c57e159501b7b3f2c19f0  guix-build-a8cdc5872eaa/output/arm-linux-gnueabihf/bitcoin-a8cdc5872eaa-arm-linux-gnueabihf.tar.gz
9b9307b0a4d55095e9e3c51739d68776c3a1ca0af94422157c549b91a2e73452  guix-build-a8cdc5872eaa/output/arm64-apple-darwin/SHA256SUMS.part
250af8ba53d39d4ce8a5c16956b064a7b2d82bb72f7097426f1b2477aa6d1c7a  guix-build-a8cdc5872eaa/output/arm64-apple-darwin/bitcoin-a8cdc5872eaa-arm64-apple-darwin-codesigning.tar.gz
ee2958eb2ae9c27fb45804cf197c3d5ee13c7706382c7358c8175a17aa935820  guix-build-a8cdc5872eaa/output/arm64-apple-darwin/bitcoin-a8cdc5872eaa-arm64-apple-darwin-unsigned.tar.gz
a3dfa546006a9cb118402ada458d9bbf5bafb9c9cf91abdf83492d34aea2f068  guix-build-a8cdc5872eaa/output/arm64-apple-darwin/bitcoin-a8cdc5872eaa-arm64-apple-darwin-unsigned.zip
092eeec72bf498d7bd783a532c8874756bd13d6d9bd69a414222ef74a749fc62  guix-build-a8cdc5872eaa/output/dist-archive/bitcoin-a8cdc5872eaa.tar.gz
687c8c72f1503e6b0ee54b233bd03d9dd4fb7d5902d91888bb482321b898c0fc  guix-build-a8cdc5872eaa/output/powerpc64-linux-gnu/SHA256SUMS.part
cf3a04fcc59b81db4a0da1c970400a2b6f6230a0a89667c2d2ad934c3d48df24  guix-build-a8cdc5872eaa/output/powerpc64-linux-gnu/bitcoin-a8cdc5872eaa-powerpc64-linux-gnu-debug.tar.gz
f6b68b8b2270092f4f65bdc66303f2230964838afccec322215bd81f8db90d19  guix-build-a8cdc5872eaa/output/powerpc64-linux-gnu/bitcoin-a8cdc5872eaa-powerpc64-linux-gnu.tar.gz
d7b7e4a85940de9b8b77d3dabca47693d235c38bcbe8ce35208fd3a473f688c1  guix-build-a8cdc5872eaa/output/riscv64-linux-gnu/SHA256SUMS.part
2a53aeb926f648f802e570cfa4e942123baeb75d242ba655478b71ac860ae139  guix-build-a8cdc5872eaa/output/riscv64-linux-gnu/bitcoin-a8cdc5872eaa-riscv64-linux-gnu-debug.tar.gz
59b42734415f705f7b55dbf8640ceba81f350a48e15e0d3c5bcac8422ea74302  guix-build-a8cdc5872eaa/output/riscv64-linux-gnu/bitcoin-a8cdc5872eaa-riscv64-linux-gnu.tar.gz
e2915d9d12bdcf4d16e69922ac0274bcb5f73ef9c80f12755c6eb710afe937d7  guix-build-a8cdc5872eaa/output/x86_64-apple-darwin/SHA256SUMS.part
dc89bdb96c2f40a59f962f04c1fa73aaddcc00945885d05932a9865665476a33  guix-build-a8cdc5872eaa/output/x86_64-apple-darwin/bitcoin-a8cdc5872eaa-x86_64-apple-darwin-codesigning.tar.gz
124be6f6f93bd1720caa4e22c5c0b9ee31104fcda1ed5dc5ecf3e454fbbbc445  guix-build-a8cdc5872eaa/output/x86_64-apple-darwin/bitcoin-a8cdc5872eaa-x86_64-apple-darwin-unsigned.tar.gz
75ef0b32548755b4dd3e6874449f163e421ad94f4ab282ecbc3b7f14450f83ae  guix-build-a8cdc5872eaa/output/x86_64-apple-darwin/bitcoin-a8cdc5872eaa-x86_64-apple-darwin-unsigned.zip
9c33d57ae3cdb5d1f8f7f7eb1318d9c6a858be04807492892fdaffbd4bbc810e  guix-build-a8cdc5872eaa/output/x86_64-linux-gnu/SHA256SUMS.part
adbb6dda5bedeb6bb074ee7cfe1c25c0143f036314d5cdf76251ea165b66a08e  guix-build-a8cdc5872eaa/output/x86_64-linux-gnu/bitcoin-a8cdc5872eaa-x86_64-linux-gnu-debug.tar.gz
87196f4a93e58022dfb35d7dc0324929527ac57410044ccaa33235d0b6068fad  guix-build-a8cdc5872eaa/output/x86_64-linux-gnu/bitcoin-a8cdc5872eaa-x86_64-linux-gnu.tar.gz
51d0a2924d37c31605913776b4011f300f4af3e587148faa1777aae1c676fc12  guix-build-a8cdc5872eaa/output/x86_64-w64-mingw32/SHA256SUMS.part
7ccd8cb5185a4c1834f76d6e000d2a6f3299324971025d497e969f8b43e10b11  guix-build-a8cdc5872eaa/output/x86_64-w64-mingw32/bitcoin-a8cdc5872eaa-win64-codesigning.tar.gz
e022f885987d0232017810e610f3ebfe57ca81c7f332fead23fc96331282964c  guix-build-a8cdc5872eaa/output/x86_64-w64-mingw32/bitcoin-a8cdc5872eaa-win64-debug.zip
7f408eee780c177b31b306ad5833505d9ee6942b82fad31faea1eeb9d9d03e36  guix-build-a8cdc5872eaa/output/x86_64-w64-mingw32/bitcoin-a8cdc5872eaa-win64-setup-unsigned.exe
900619e260c79bffc4a9781a1c998729c97720a8a89ddef6994eb994670bf234  guix-build-a8cdc5872eaa/output/x86_64-w64-mingw32/bitcoin-a8cdc5872eaa-win64-unsigned.zip

ryanofsky commented at 10:06 PM on December 16, 2025: contributor

Current version of this PR is ok but I do think fanquake's suggested change #29963 (comment) passing along the requested compiler to config.guess would be an improvement.

I think his change had a typo because it suggests using CC_FOR_BUILD=$CC when this should probably be CC_FOR_BUILD=$(build_CC) (or CC=$(build_CC) which is equivalent) because if a depends user specifies build_CC it makes sense to have config.guess use it instead of ignoring it and probing for alternate compilers:

https://github.com/bitcoin/bitcoin/blob/13891a8a685d255cb13dd5018e3d5ccc18b07c34/depends/config.guess#L126-L130

sedited approved

sedited commented at 10:16 PM on January 2, 2026: contributor

ACK a8cdc5872eaaffd56a8c79c6d371feb0df12431a

Edit: ryanofsky's idea above (i.e. propagating build_CC seems like a good addition though.

depends: Do not consider `CC` environment variable when detecting system

Otherwise, the build system fails to detect cross-compiling mode
properly in some cases when `CC` is set.

b149a28f6b

in depends/Makefile:50 in a8cdc5872e

  46 | @@ -47,7 +47,7 @@ FALLBACK_DOWNLOAD_PATH ?= https://bitcoincore.org/depends-sources
  47 |  C_STANDARD ?= c11
  48 |  CXX_STANDARD ?= c++20
  49 |  
  50 | -BUILD = $(shell ./config.guess)
  51 | +BUILD = $(shell env --unset CC ./config.guess)

fanquake commented at 11:20 AM on January 20, 2026:

I don't think this is portable. i.e on Chimera Linux:

make -C depends/ -j15
make: Entering directory '/bitcoin/depends'
env: unrecognized option: -
usage: env [-0iv] [-C workdir] [-L|-U user[/class]] [-P utilpath] [-S string]
           [-u name] [name=value ...] [utility [argument ...]]
config.sub: missing argument

hebasto commented at 5:54 PM on January 20, 2026:

Thanks! Reworked in a portable way.

hebasto force-pushed on Jan 20, 2026

hebasto commented at 5:54 PM on January 20, 2026: member

Rebased. @fanquake's comment has been addressed.

hebasto commented at 6:01 PM on January 20, 2026: member

Current version of this PR is ok but I do think fanquake's suggested change #29963 (comment) passing along the requested compiler to config.guess would be an improvement.

I think his change had a typo because it suggests using CC_FOR_BUILD=$CC when this should probably be CC_FOR_BUILD=$(build_CC) (or CC=$(build_CC) which is equivalent) because if a depends user specifies build_CC it makes sense to have config.guess use it instead of ignoring it and probing for alternate compilers:

https://github.com/bitcoin/bitcoin/blob/13891a8a685d255cb13dd5018e3d5ccc18b07c34/depends/config.guess#L126-L130

I agree that using CC_FOR_BUILD is the preferred way to communicate with config.guess. However, it will require non-trivial refactoring of depends/Makefile, as build_CC is evaluated late in depends/builders/default.mk.

hebasto commented at 9:46 AM on January 21, 2026: member

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
aarch64
8c61dbdc73e273e9f336cdc64c48121037d0aed2a1a7f054184d827ac8499cd7  guix-build-b149a28f6b86/output/aarch64-linux-gnu/SHA256SUMS.part
b3ffed84220353f0ed0b4276e5705c5c4b8b8161e0f40cd45c69310f0ac41ff5  guix-build-b149a28f6b86/output/aarch64-linux-gnu/bitcoin-b149a28f6b86-aarch64-linux-gnu-debug.tar.gz
83989804e95ac165fe08fc6fe39ff529140a4c123dabac670686d8b86bbfa039  guix-build-b149a28f6b86/output/aarch64-linux-gnu/bitcoin-b149a28f6b86-aarch64-linux-gnu.tar.gz
a9e02d7909575292e4e1d5664b1ccaf649344bc940fef6d58f3334893ee0f3c3  guix-build-b149a28f6b86/output/arm-linux-gnueabihf/SHA256SUMS.part
937a9f8fbe5a0dcedd6a4b4480a3b0f31b4bea574150a19a5c7c9df30b91b666  guix-build-b149a28f6b86/output/arm-linux-gnueabihf/bitcoin-b149a28f6b86-arm-linux-gnueabihf-debug.tar.gz
9796fc4a2478b8dab6fadfca32e5f720df90b8c3fdc510855696ee8ab5c60df6  guix-build-b149a28f6b86/output/arm-linux-gnueabihf/bitcoin-b149a28f6b86-arm-linux-gnueabihf.tar.gz
25240da10e175e00ff7144985b60c1a791aa38a728fdf6ade0b478b791df82e5  guix-build-b149a28f6b86/output/arm64-apple-darwin/SHA256SUMS.part
39f0c66407749d1cec3014dc9f92f4550d7e01202e2b9ba074bce711f91c8e1b  guix-build-b149a28f6b86/output/arm64-apple-darwin/bitcoin-b149a28f6b86-arm64-apple-darwin-codesigning.tar.gz
96dcd8518b25904dad4679e40738783ffb387a32c5fb2417801ed5cf9857f959  guix-build-b149a28f6b86/output/arm64-apple-darwin/bitcoin-b149a28f6b86-arm64-apple-darwin-unsigned.tar.gz
b10fdcf921999bfeb2089f38cc73c95b3cd9044941e0b63ea1eada80bbaf78f2  guix-build-b149a28f6b86/output/arm64-apple-darwin/bitcoin-b149a28f6b86-arm64-apple-darwin-unsigned.zip
64d27a1b596be20bfd954d717cb3b0e4cd514af37f28ed020e12e1c11f602a4e  guix-build-b149a28f6b86/output/dist-archive/bitcoin-b149a28f6b86.tar.gz
45eb520337e8a5aab723e56ec48bd1c0fc70b74536f376c645f343a094ea1423  guix-build-b149a28f6b86/output/powerpc64-linux-gnu/SHA256SUMS.part
ee7eb54979168091733f74e6ef94d2b04a777b74323e9bc9d1e6bdee4bcedf1c  guix-build-b149a28f6b86/output/powerpc64-linux-gnu/bitcoin-b149a28f6b86-powerpc64-linux-gnu-debug.tar.gz
81350b0f2fd948dfe7b32d62f1ab9a29a66fa10747778180c7e7159c9ce0c91d  guix-build-b149a28f6b86/output/powerpc64-linux-gnu/bitcoin-b149a28f6b86-powerpc64-linux-gnu.tar.gz
5c1a05c5052168ce6624dcc17affa49fb9934fb14726fb567d3f6e092e4789f7  guix-build-b149a28f6b86/output/riscv64-linux-gnu/SHA256SUMS.part
1f4d807e17fa5519f41963a64f222ba329edd29e4c37404c195c77cc85e4e054  guix-build-b149a28f6b86/output/riscv64-linux-gnu/bitcoin-b149a28f6b86-riscv64-linux-gnu-debug.tar.gz
c028a52b1d516553994fe27d7f4d5ddde16f8e3f9d137acb141070b3786482a2  guix-build-b149a28f6b86/output/riscv64-linux-gnu/bitcoin-b149a28f6b86-riscv64-linux-gnu.tar.gz
1c7e0069aec956a38b3e6b65b2cb3deca31b26f0150779c446e1952f8af50d92  guix-build-b149a28f6b86/output/x86_64-apple-darwin/SHA256SUMS.part
f250735778c89347d920a57c48c1c359eab78b0f36d71298ceebdb2d806225ed  guix-build-b149a28f6b86/output/x86_64-apple-darwin/bitcoin-b149a28f6b86-x86_64-apple-darwin-codesigning.tar.gz
b91f645b3bbfb960315706ca03d80335c1546f1736bad1c157ba466533b5ad35  guix-build-b149a28f6b86/output/x86_64-apple-darwin/bitcoin-b149a28f6b86-x86_64-apple-darwin-unsigned.tar.gz
487a853c611780fc69d8c0661afeacfccb30b73a74d73e2808db0cdad292147e  guix-build-b149a28f6b86/output/x86_64-apple-darwin/bitcoin-b149a28f6b86-x86_64-apple-darwin-unsigned.zip
82e85f8b085d703e765d5c349ea8a3e5fbcaf9e21a734ac4e71c13869dc9e3c8  guix-build-b149a28f6b86/output/x86_64-linux-gnu/SHA256SUMS.part
61e8b2ee7156671ec763b7d3bd9ef61ec606a5757003d714a5f0ea0620e30360  guix-build-b149a28f6b86/output/x86_64-linux-gnu/bitcoin-b149a28f6b86-x86_64-linux-gnu-debug.tar.gz
7f433e6b6f2a6ca5c9c4e2b302a27164c545a80654257adb5be475824c4709b5  guix-build-b149a28f6b86/output/x86_64-linux-gnu/bitcoin-b149a28f6b86-x86_64-linux-gnu.tar.gz
7ed5214baf946578444de8d1201c7de12cb60f8493906da98d3804f227069182  guix-build-b149a28f6b86/output/x86_64-w64-mingw32/SHA256SUMS.part
3024741c291f97078dbf1097a67e73deb67f28e360f4cdbaaee106bae258ecf5  guix-build-b149a28f6b86/output/x86_64-w64-mingw32/bitcoin-b149a28f6b86-win64-codesigning.tar.gz
3c1a64176ddc05f926fa219cfebe58297eea9a918fa269f871cbfb6d0716ebd8  guix-build-b149a28f6b86/output/x86_64-w64-mingw32/bitcoin-b149a28f6b86-win64-debug.zip
67fa2ae79b13f35b7ccfb90a8f25e92362985399c9e0bb3b80119e1b60719f60  guix-build-b149a28f6b86/output/x86_64-w64-mingw32/bitcoin-b149a28f6b86-win64-setup-unsigned.exe
15d9dccd1d104aad970d9269e01d7d37d553a331b3355287294ea36d98205dbe  guix-build-b149a28f6b86/output/x86_64-w64-mingw32/bitcoin-b149a28f6b86-win64-unsigned.zip

hebasto referenced this in commit 28160c1e3d on Feb 6, 2026

in depends/Makefile:52 in b149a28f6b

  48 | @@ -49,7 +49,7 @@ FALLBACK_DOWNLOAD_PATH ?= https://bitcoincore.org/depends-sources
  49 |  C_STANDARD ?= c11
  50 |  CXX_STANDARD ?= c++20
  51 |  
  52 | -BUILD = $(shell ./config.guess)
  53 | +BUILD = $(shell unset CC && ./config.guess)

sedited commented at 2:39 PM on February 11, 2026:

Do we really need to use a utility for this? Can't we set CC=?

hebasto commented at 4:31 PM on February 11, 2026:

While CC= might work (I haven't test it), it relies on specific behavior in the configure script's implementation, making it a brittle solution.

sedited approved

sedited commented at 10:01 AM on February 12, 2026: contributor

Re-ACK b149a28f6b863c85ab45c393e7781d4769b282f6

DrahtBot requested review from ryanofsky on Feb 12, 2026

fanquake added the label DrahtBot Guix build requested on Feb 12, 2026

DrahtBot commented at 9:32 PM on February 19, 2026: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit b65ff0e5a1fd4ea2ae75e204729b8008c4ebb9ab<br>(master)	commit a959a541771fd500b9a0ce7b9fbbcf95ebbb93ab<br>(pull/29963/merge)
*-aarch64-linux-gnu-debug.tar.gz	`50e56b382cbc13b2...`	`40e8269f72a6a198...`
*-aarch64-linux-gnu.tar.gz	`43a9709bf4519808...`	`60baf92d9de6a2e1...`
*-arm-linux-gnueabihf-debug.tar.gz	`c6b2888003eabb60...`	`9b47e2c60dfbc922...`
*-arm-linux-gnueabihf.tar.gz	`0639e712812b4ed8...`	`e94f92ff8e02e608...`
*-arm64-apple-darwin-codesigning.tar.gz	`741a0a34d9e32089...`	`ef661adb9061b15a...`
*-arm64-apple-darwin-unsigned.tar.gz	`d5a1828c77b5b255...`	`c16ad6bb5a830e25...`
*-arm64-apple-darwin-unsigned.zip	`151fc9ef00a4d3a3...`	`04b43fae177ee7d7...`
*-powerpc64-linux-gnu-debug.tar.gz	`91559bd33e4040ff...`	`71ee3cbdcf873102...`
*-powerpc64-linux-gnu.tar.gz	`6e7c7b88b954aecf...`	`b0538137fc7704e4...`
*-riscv64-linux-gnu-debug.tar.gz	`07b1754be7cc4559...`	`1c34b40f3dfa8485...`
*-riscv64-linux-gnu.tar.gz	`ade2633a590f811c...`	`69f3c772c2a32202...`
*-win64-codesigning.tar.gz	`d414e1a06155de03...`	`04f4d03331059ef1...`
*-win64-debug.zip	`306ab33d40746cb3...`	`6edfbeeffed52dee...`
*-win64-setup-unsigned.exe	`787eb58220acf4b0...`	`a3eaa2dcddb8b9c7...`
*-win64-unsigned.zip	`0e3f1df2c7d49e09...`	`5923604d4de31c18...`
*-x86_64-apple-darwin-codesigning.tar.gz	`1662e1eb46db4ce6...`	`60c67eae78429a3f...`
*-x86_64-apple-darwin-unsigned.tar.gz	`e84a353b2fab7ba0...`	`a81f18c7e6774aa8...`
*-x86_64-apple-darwin-unsigned.zip	`69b7c0a328e2294c...`	`06652fe5e6f58722...`
*-x86_64-linux-gnu-debug.tar.gz	`b27f5b76cd7a74df...`	`21a35aede898a41b...`
*-x86_64-linux-gnu.tar.gz	`845cf140a743928a...`	`f2c9d9be745a9dbd...`
*.tar.gz	`151010c2f2cf4bbd...`	`da1b46715d991d45...`
SHA256SUMS.part	`7a5baeba2a6dbb51...`	`f3e9acbaa8e10c41...`
guix_build.log	`f50758d2ddfa1855...`	`6f56f67cad93042f...`
guix_build.log.diff		`a0932477a7c0d49a...`

DrahtBot removed the label DrahtBot Guix build requested on Feb 19, 2026

ryanofsky approved

ryanofsky commented at 7:53 PM on February 26, 2026: contributor

Code review ACK b149a28f6b863c85ab45c393e7781d4769b282f6. env --unset was replaced with unset && since last review. I still think it could be better to write CC=$(build_CC) here even if build_CC may not be defined at this point (https://github.com/bitcoin/bitcoin/pull/29963#issuecomment-3774229317) because it makes intent of the code more obvious, but current PR is already an improvement

fanquake merged this on Mar 23, 2026

fanquake closed this on Mar 23, 2026

hebasto deleted the branch on Mar 23, 2026