fuzz: Handle missing BDBRO errors #30172

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:bdbro-fuzz-skip-enc changing 1 files +14 −12
  1. achow101 commented at 5:16 PM on May 24, 2024: member

    Adds error messages that were not being handled. Also removes error messages that no longer exist.

    Fixes #30166

  2. DrahtBot commented at 5:16 PM on May 24, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on May 24, 2024
  4. in src/wallet/test/fuzz/wallet_bdb_parser.cpp:72 in 44e071be1d outdated 
      69 |              error.original == "Unexpected database flags, should only be 0x20 (subdatabases)" ||
  70 |              error.original == "Unexpected outer database root page type" ||
  71 |              error.original == "Unexpected number of entries in outer database root page" ||
  72 | -            error.original == "Subdatabase has an unexpected name" ||
  73 |              error.original == "Subdatabase page number has unexpected length" ||
  74 |              error.original == "Unexpected inner database page type" ||
    TheCharlatan commented at 7:28 PM on May 24, 2024:

    Is this still used?

    fanquake commented at 8:45 AM on May 29, 2024:

    @achow101 can you followup here? Would be good to merge this to avoid the fuzzing issues.

    achow101 commented at 9:01 AM on May 29, 2024:

    Removed

  5. dergoegge approved
  6. dergoegge commented at 8:34 AM on May 28, 2024: member

    tACK 44e071be1d3bc9cd48c776bcd49310d0f8189f5f - No longer running into errors when fuzzing

  7. fuzz: Handle missing BDBRO errors
    Adds error messages that were not being handled. Also removes error
messages that no longer exist.
    9ddf39dd87
  8. achow101 force-pushed on May 29, 2024
  9. dergoegge approved
  10. dergoegge commented at 9:10 AM on May 29, 2024: member

    reACK 9ddf39dd87a3729ceedaa05a207621a02c532536

  11. TheCharlatan approved
  12. TheCharlatan commented at 9:21 AM on May 29, 2024: contributor

    ACK 9ddf39dd87a3729ceedaa05a207621a02c532536

  13. fanquake merged this on May 29, 2024
  14. fanquake closed this on May 29, 2024
  15. bitcoin locked this on May 29, 2025
Contributors
achow101DrahtBotTheCharlatanfanquakedergoegge
Labels
Tests
Linked (view graph)
#30166 fuzz, wallet_bdb_parser: BDB builtin encryption is not supported
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 00:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me