depends: bump libmultiprocess for CMake fixes #30490

pull theuni wants to merge 1 commits into bitcoin:master from theuni:depends-multiprocess-bump changing 1 files +2 −2
  1. theuni commented at 6:38 pm on July 19, 2024: member

    Broken out of #30454 . Bumped even further after https://github.com/chaincodelabs/libmultiprocess/pull/98 was merged upstream.

    hebasto Presumably this approach works now with the CMake branch?

  2. depends: bump libmultiprocess for CMake fixes d318c4ef56
  3. DrahtBot commented at 6:38 pm on July 19, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Jul 19, 2024
  5. theuni commented at 6:38 pm on July 19, 2024: member
    Ping @ryanofsky for a quick concept ACK for bumping to this particular commit.
  6. ryanofsky approved
  7. ryanofsky commented at 7:55 pm on July 19, 2024: contributor

    Code review ACK d318c4ef56465ccad1a1d4d27c52216e0b69ad4e.

    I haven’t tested the cmake support, but I made the same version bump in 3e6c61fdc2839bdb74563538aaf0a5e7d0e07ea3, which is part of #10102 and #30437

  8. fanquake merged this on Jul 20, 2024
  9. fanquake closed this on Jul 20, 2024

  10. hebasto commented at 1:31 pm on July 20, 2024: member

    Presumably this approach works now with the CMake branch?

    Unfortunately, it doesn’t.

    The PR30454 branch rebased on the master branch @ efeb39785aeee9130584b865d886c6b46e59f147 fails:

    0$ make -C depends NO_QT=1 NO_WALLET=1 NO_UPNP=1 NO_NATPMP=1 NO_ZMQ=1 NO_USDT=1 MULTIPROCESS=1
    1$ cmake -B build --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake
    2...
    3CMake Error at CMakeLists.txt:158 (find_package):
    4  Could not find a package configuration file provided by
    5  "LibmultiprocessGen" with any of the following names:
    6
    7    LibmultiprocessGenConfig.cmake
    8    libmultiprocessgen-config.cmake
    

    I will look for a solution in the upstream repository.

    UPD. https://github.com/chaincodelabs/libmultiprocess/pull/98#issuecomment-2241236657

  11. hebasto added the label Needs CMake port on Jul 23, 2024
  12. hebasto commented at 7:13 pm on July 23, 2024: member
    Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/277.
  13. hebasto removed the label Needs CMake port on Jul 23, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me