test: remove unused src_dir param from run_tests after CMake migration #30733

1. 
   l0rinc commented at 1:11 pm on August 28, 2024: contributor

   The src_dir usage was removed in https://github.com/bitcoin/bitcoin/commit/a8a2e364acf55bbe18404ab21f852d52257bcb6d#diff-437d7f6e9f2229879b60aae574a8217f14c643bbf3cfa9225d8011d6d52df00cL598, making the parameter unused.
2. 
   DrahtBot commented at 1:11 pm on August 28, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Stale ACK	hebasto, davidgumberg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. l0rinc renamed this:
   Remove unused src_dir param from run_tests
   cmake: remove unused src_dir param from run_tests
   on Aug 28, 2024
4. 
   maflcko commented at 1:30 pm on August 28, 2024: member

   You are modifying test files, not build files, so I don’t think the cmake prefix makes sense. Also a two line trivial test-fix is easier to review in a single squashed commit, instead of being split up into several.
5. 
   maflcko commented at 1:31 pm on August 28, 2024: member

   Also, I think you can remove the mention where it is moved from. You left the comment in the thread where it was moved from and GitHub already registered the link. No need to put it into the pull description and merge commit forever.
6. DrahtBot added the label Build system on Aug 28, 2024
7. l0rinc force-pushed on Aug 28, 2024
8. 
   l0rinc commented at 3:23 pm on August 28, 2024: contributor

   Done, thank @maflcko
9. l0rinc renamed this:
   cmake: remove unused src_dir param from run_tests
   test: remove unused src_dir param from run_tests
   on Aug 28, 2024
10. l0rinc marked this as ready for review on Aug 28, 2024
11. maflcko removed the label Build system on Aug 29, 2024
12. DrahtBot added the label Tests on Aug 29, 2024
13. 
    maflcko commented at 6:20 am on August 29, 2024: member

    Not sure if it will be needed again for https://github.com/hebasto/bitcoin/pull/309#issuecomment-2282704754 (If that happens), but otherwise lgtm
14. in test/functional/test_runner.py:597 in 76a28306f1 outdated

    593@@ -595,7 +594,7 @@ def run_tests(*, test_list, src_dir, build_dir, tmpdir, jobs=1, enable_coverage=
    594         print(f"{BOLD[1]}WARNING!{BOLD[0]} There may be insufficient free space in {tmpdir} to run the Bitcoin functional test suite. "
    595               f"Running the test suite with fewer than {min_space // (1024 * 1024)} MB of free space might cause tests to fail.")
    596 
    597-    tests_dir = build_dir + '/test/functional/'
    598+    tests_dir = f"{build_dir}/test/functional/"
    

    ---

    ---

    

    hebasto commented at 9:46 am on August 29, 2024:

    nit: This change seems irrelevant.

    ---

    

    l0rinc commented at 10:14 am on August 29, 2024:

    I put it to a separate commit originally, @maflcko suggested I merge it into the same commit. If you feel strongly about it, I’ll revert - but seems more idiomatic Python this way.
15. hebasto approved
16. 
    hebasto commented at 9:46 am on August 29, 2024: member

    ACK 76a28306f1e2c0828590eded0bf6b178f6b889da.
17. l0rinc renamed this:
    test: remove unused src_dir param from run_tests
    test: remove unused src_dir param from run_tests after CMake migration
    on Aug 29, 2024
18. DrahtBot added the label CI failed on Aug 30, 2024
19. Remove unused src_dir param from run_tests 2ad560139b
20. l0rinc force-pushed on Aug 30, 2024
21. DrahtBot removed the label CI failed on Aug 30, 2024
22. 
    davidgumberg commented at 4:57 am on September 4, 2024: contributor

    ACK https://github.com/bitcoin/bitcoin/commit/76a28306f1e2c0828590eded0bf6b178f6b889da
23. DrahtBot added the label CI failed on Sep 7, 2024
24. DrahtBot removed the label CI failed on Sep 9, 2024
25. 
    fanquake commented at 11:08 am on September 12, 2024: member

    @davidgumberg fyi you’ve ack’d the previous commit hash here.
26. fanquake merged this on Sep 12, 2024
27. fanquake closed this on Sep 12, 2024

    ---

28. 
    davidgumberg commented at 8:54 am on September 13, 2024: contributor

    @fanquake thanks for catching,

    post-merge ACK https://github.com/bitcoin/bitcoin/pull/30733/commits/2ad560139b80e149844f285cd1456bb7cc0eb1ee

29. l0rinc deleted the branch on Sep 13, 2024

Contributors
l0rinc DrahtBot maflcko hebasto davidgumberg fanquake

Labels
Tests