In commit 9730288a0cd3f33021ef00fb2d95e5216d10ab61 many configs were removed from the CI without explanation.
Fix it by adding them back.
Can be reviewed by looking at:
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
71 | @@ -72,7 +72,7 @@ jobs: 72 | run: | 73 | # Run tests on commits after the last merge commit and before the PR head commit 74 | # Use clang++, because it is a bit faster and uses less memory than g++ 75 | - git rebase --exec "echo Running test-one-commit on \$( git log -1 ) && CC=clang CXX=clang++ cmake -B build -DBUILD_GUI=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWITH_BDB=ON -DWITH_NATPMP=ON -DWITH_MINIUPNPC=ON -DWITH_USDT=ON && cmake --build build -j $(nproc) && ctest --test-dir build -j $(nproc) && ./build/test/functional/test_runner.py -j $(( $(nproc) * 2 ))" ${{ env.TEST_BASE }} 76 | + git rebase --exec "echo Running test-one-commit on \$( git log -1 ) && CC=clang CXX=clang++ cmake -B build -DWITH_ZMQ=ON -DBUILD_GUI=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWITH_BDB=ON -DWITH_NATPMP=ON -DWITH_MINIUPNPC=ON -DWITH_USDT=ON && cmake --build build -j $(nproc) && ctest --test-dir build -j $(nproc) && ./build/test/functional/test_runner.py -j $(( $(nproc) * 2 ))" ${{ env.TEST_BASE }}
Should this job also be installing libzmq3-dev ?
I am using python3-zmq as a proxy for that, which should probably be enough, no? And if libzmq was missing, the CI would be failing, no?
Sure, it's likely fine, just inconsistent with the other CIs.
Yeah, I am happy to review a different pull request touching those lines, but I haven't touched them in this pull request, so I'll leave this as-is for now.
Looks like this doesn't work, given: https://github.com/bitcoin/bitcoin/actions/runs/10612371177/job/29413871228?pr=30749 ?
Yeah, sorry. This CI task doesn't run on pulls with one commit only.
Jup, I was wrong. Do you mind fixing it up in your pull?
many configs were removed from the CI without explanation.
Nice catch. It's not clear why a bunch of CI configs would have been removed..
many configs were removed from the CI without explanation.
Nice catch. It's not clear why a bunch of CI configs would have been removed..
Sorry for overlooking them.
many configs were removed from the CI without explanation.
Nice catch. It's not clear why a bunch of CI configs would have been removed..
Sorry for overlooking them.
No worries. It is my fault for not reviewing them properly before. Also, it looks like the other reviewers missed them as well, so not your fault again.
ACK fa80d39d82013b21a70677ac79bdff8c614379b7
Post-merge ACK fa80d39d82013b21a70677ac79bdff8c614379b7.