ci: Delete no longer needed workaround #30777

1. 
   hebasto commented at 3:03 am on August 31, 2024: member

   This PR removes a workaround that was necessary at some point during the development of the CMake staging branch.
2. ci: Delete no longer needed workaround

   It was necessary at some point during the development of the CMake
   staging branch.

   74da8cb286
3. hebasto added the label Windows on Aug 31, 2024
4. hebasto added the label Tests on Aug 31, 2024
5. 
   DrahtBot commented at 3:03 am on August 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. fanquake approved
7. 
   fanquake commented at 11:07 am on August 31, 2024: member

   ACK 74da8cb286ce057cbd8c5081bac3fda74781c279
8. fanquake merged this on Aug 31, 2024
9. fanquake closed this on Aug 31, 2024

   ---

10. 
    maflcko commented at 6:33 am on September 2, 2024: member

    Is there a reason why the msvc task no longer uses ccache?
11. 
    hebasto commented at 9:48 am on September 2, 2024: member

    Is there a reason why the msvc task no longer uses ccache?

    The internal ccache integration was dropped in https://github.com/hebasto/bitcoin/pull/215. I see two options for proceeding:

    • make another attempt to integrate ccache into the build system, which would benefit all MSVC users, or
    • re-add ccache support to the CI job
12. 
    maflcko commented at 10:00 am on September 2, 2024: member

    I see. I guess it is fine to not have it, given that it only shaves off a small percentage of the overall build time. Running the functional or fuzz tests in Debug here requires each more time than just the build without ccache.

    But up to you.

13. hebasto deleted the branch on Sep 2, 2024

Contributors
hebasto DrahtBot fanquake maflcko

Labels
Windows Tests