This PR removes a workaround that was necessary at some point during the development of the CMake staging branch.
ci: Delete no longer needed workaround #30777
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240830-ci-win changing 1 files +0 −4-
hebasto commented at 3:03 AM on August 31, 2024: member
-
74da8cb286
ci: Delete no longer needed workaround
It was necessary at some point during the development of the CMake staging branch.
- hebasto added the label Windows on Aug 31, 2024
- hebasto added the label Tests on Aug 31, 2024
-
DrahtBot commented at 3:03 AM on August 31, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- fanquake approved
-
fanquake commented at 11:07 AM on August 31, 2024: member
ACK 74da8cb286ce057cbd8c5081bac3fda74781c279
- fanquake merged this on Aug 31, 2024
- fanquake closed this on Aug 31, 2024
-
maflcko commented at 6:33 AM on September 2, 2024: member
Is there a reason why the msvc task no longer uses ccache?
-
hebasto commented at 9:48 AM on September 2, 2024: member
Is there a reason why the msvc task no longer uses ccache?
The internal
ccacheintegration was dropped in https://github.com/hebasto/bitcoin/pull/215. I see two options for proceeding:- make another attempt to integrate
ccacheinto the build system, which would benefit all MSVC users, or - re-add
ccachesupport to the CI job
- make another attempt to integrate
-
maflcko commented at 10:00 AM on September 2, 2024: member
I see. I guess it is fine to not have it, given that it only shaves off a small percentage of the overall build time. Running the functional or fuzz tests in
Debughere requires each more time than just the build without ccache.But up to you.
- hebasto deleted the branch on Sep 2, 2024
- bitcoin locked this on Sep 2, 2025
