ci: failure in win64 unit tests `err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."`)

fanquake commented at 5:12 pm on September 2, 2024: member

Seen in https://cirrus-ci.com/task/6387064294342656?logs=ci#L2492:

 0127/135 Test [#129](/bitcoin-bitcoin/129/): spend_tests ..........................   Passed    9.85 sec
 1128/135 Test [#135](/bitcoin-bitcoin/135/): db_tests .............................   Passed    3.32 sec
 2129/135 Test   [#1](/bitcoin-bitcoin/1/): util_test_runner .....................***Failed  154.46 sec
 32024-09-02 15:49:05,155 - ERROR - Error parsing command output as hex: non-hexadecimal number found in fromhex() arg at position 1
 42024-09-02 15:49:30,298 - ERROR - FAILED_TESTCASES:
 5['Creates a new transaction with one input, one address output and one data (zero value) output']
 6
 7130/135 Test [#134](/bitcoin-bitcoin/134/): walletload_tests .....................   Passed    6.06 sec
 8131/135 Test [#131](/bitcoin-bitcoin/131/): wallet_tests .........................   Passed   16.91 sec
 9132/135 Test [#121](/bitcoin-bitcoin/121/): coinselector_tests ...................   Passed   35.08 sec
10133/135 Test   [#5](/bitcoin-bitcoin/5/): noverify_tests .......................   Passed  186.81 sec
11134/135 Test   [#6](/bitcoin-bitcoin/6/): tests ................................   Passed  264.45 sec
12135/135 Test  [#10](/bitcoin-bitcoin/10/): allocator_tests ......................   Passed  266.16 sec
13
1499% tests passed, 1 tests failed out of 135
15
16Total Test time (real) = 266.20 sec
17
18The following tests FAILED:
19	  1 - util_test_runner (Failed)
20Errors while running CTest

maflcko added the label CI failed on Sep 3, 2024

maflcko added the label Windows on Sep 3, 2024

maflcko commented at 8:29 am on September 3, 2024: member

Interesting. I re-ran it 12 times on the same config/commit, but it passed every time: https://cirrus-ci.com/task/6025886804213760

It would be nice if the test failure was a bit more verbose to show the full traceback, as well as all values involved.

fanquake commented at 8:49 am on September 6, 2024: member

I wonder if it was an intermittent wine related issue, but the output was missing. Similar to something like: https://cirrus-ci.com/task/6309656165875712.

maflcko commented at 9:38 am on September 6, 2024: member

Yeah, possibly. I wonder why there is a presumed increase in those errors recently.

maflcko commented at 7:55 am on October 2, 2024: member

I was able to reproduce locally (in a CI container), but given that there is no useful output, it doesn’t help:

0# while ( LC_ALL=C.UTF-8 DIR_UNIT_TEST_DATA=/ci_container_base/ci/scratch/qa-assets/unit_test_data/ ctest --test-dir /ci_container_base/ci/scratch/build-x86_64-w64-mingw32 -j $( nproc ) ) ; do ( echo 1 >> /tmp/runs ) ; done
1
2...
3
4# cat /tmp/runs |wc -l
548

The log:

 0...
 11/136 Testing: util_test_runner
 21/136 Test: util_test_runner
 3Command: "/usr/bin/cmake" "-E" "env" "BITCOINUTIL=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-util.exe" "BITCOINTX=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-tx.exe" "/usr/bin/python3" "/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/test/util/test_runner.py"
 4Directory: /ci_container_base/ci/scratch/build-x86_64-w64-mingw32
 5"util_test_runner" start time: Oct 02 03:45 UTC
 6Output:
 7----------------------------------------------------------
 82024-10-02 03:46:17,710 - ERROR - Error parsing command output as hex: non-hexadecimal number found in fromhex() arg at position 1
 92024-10-02 03:47:38,991 - ERROR - FAILED_TESTCASES:
10['Creates a new transaction with a single empty output script']
11<end of output>
12Test time = 144.83 sec
13----------------------------------------------------------
14Test Failed.
15"util_test_runner" end time: Oct 02 03:47 UTC
16"util_test_runner" time elapsed: 00:02:24
17----------------------------------------------------------
18
19134/136 Testing: walletdb_tests
20...

maflcko commented at 8:36 am on October 2, 2024: member

Probably the fastest way to reproduce for now inside the CI container:

 0# while ( LC_ALL=C.UTF-8 BITCOINUTIL=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-util.exe BITCOINTX=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-tx.exe /usr/bin/python3 /ci_container_base/ci/scratch/build-x86_64-w64-mingw32/test/util/test_runner.py ) ; do ( echo '...' && echo 1 >> /tmp/runs ) ; done 
 1...
 2...
 3...
 4...
 5...
 6...
 7...
 8...
 9...
10...
11...
12...
13...
14...
15...
16...
17...
18...
19...
20...
21...
22...
23...
24...
252024-10-02 08:34:47,513 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
262024-10-02 08:35:34,704 - ERROR - FAILED_TESTCASES:
27['Parses a transaction with no inputs and a single output script (output in json)']

maflcko commented at 6:32 pm on October 10, 2024: member

Couldn’t reproduce so far after #31067, but I’ll keep trying.

maflcko commented at 5:38 am on October 11, 2024: member

Ok, with the current 31067 (fa43c4f93ca5b40734ec9b3ff91b74acf3ed7cf2):

 0# while ( LC_ALL=C.UTF-8 BITCOINUTIL=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-util.exe BITCOINTX=/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-tx.exe /usr/bin/python3 /ci_container_base/ci/scratch/build-x86_64-w64-mingw32/test/util/test_runner.py ) ; do ( echo '...' && echo 1 >> /tmp/runs ) ; done 
 1
 2...
 3...
 4...
 5...
 6...
 7...
 8...
 9...
10...
11...
12...
13...
14...
15...
16...
17...
18...
19...
20...
21...
22...
23...
24...
25...
26...
27...
28...
29...
30...
31...
32...
33...
34...
35...
36...
37...
38...
39...
40...
41...
42...
432024-10-10 20:06:36,340 - ERROR - Error parsing command output as json: 'Expecting value: line 1 column 1 (char 0)'; res: CompletedProcess(args=['/ci_container_base/ci/scratch/build-x86_64-w64-mingw32/src/bitcoin-tx.exe', '-json', '-create', 'outpubkey=0:02a5613bd857b7048924264d1e70e08fb2a7e6527d32b7ab1bb993ac59964ff397:WS', 'nversion=1'], returncode=0, stdout='', stderr='err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."\n')
442024-10-10 20:06:52,758 - ERROR - FAILED_TESTCASES:
45['Creates a new transaction with a single pay-to-pub-key output, wrapped in P2SH (output as json)']

DrahtBot renamed this:
~~ci: failure in win64 unit tests~~
ci: failure in win64 unit tests `err:virtual:virtual_alloc_first_teb wine: failed to map the shared user data: c0000018\n0444:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.\n0444:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."`)
on Oct 11, 2024

maflcko commented at 8:47 am on October 11, 2024: member

No idea how to fix this. I’d say to just replace the Wine tests finally: https://github.com/bitcoin/bitcoin/issues/31071

fanquake referenced this in commit 21e2f06a1c on Oct 16, 2024

maflcko commented at 4:09 pm on October 28, 2024: member

Let’s move discussion to #31071

maflcko closed this on Oct 28, 2024